Jump to content

[1.18.2] Check if block at given position is grass/foliage/water


Recommended Posts

Posted

Most Biomes in Minecraft have unique grass/foliage/water color. It can be accessed via methods .getFoliageColor(), .getGrassColor() and .getWaterColor() of the Biome class. That means, technically, that game has an awairness of whenever block is grass/foliage and fluid is water. Am I able to gain such awairness too? Considering that I have access to instance of ServerLevel class and BlockPosition, where I want to check these conditions.

Posted

You mean tags?

e.g. blockState.is(BlockTags.FLOWERS)

https://forge.gemwire.uk/wiki/Tags

 

But I think you will find what you are talking about works the opposite way.

i.e. A grass block asks the biome what color it should be when it is being drawn.

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Posted

what do you need?

if you need to know the type of block (which the title implies "Check if block at given position is grass/foliage/water"). try the isReplaceable method or compare the block material with something.

if you need the color...
those green stuff are usually gray (in png files) and those textures (in models) are assigned tint indexes.
then, the developer tells the game how to recolor these parts of the model. the problem for you is - there is more than one way to choose a tint color.

Posted
17 hours ago, warjort said:

But I think you will find what you are talking about works the opposite way.

So, maybe, it can be done like this?

block.getMaterial().getColor().col

I found out I can call such thing from a BlockState. Is that a current block color?

Posted
14 hours ago, MFMods said:

what do you need?

Well, to make things clear. You might know that things like BlockEntityRenderer are used by Minecraft to render things into our monitor. But lets say I have asked such renderers to render some portion of the world into my own buffer => I got Minecraft geometry as it is rendered right now in my screen. I also dumped current texture atlases as .png (basic ones, because I can't yet figure out how to get full list of atlases in code). So I got geometry, I got textures. But:

14 hours ago, MFMods said:

those green stuff are usually gray (in png files)

I need to know color for each block to setup Blender materials, so it will look exactly, like in my world. Because right now all grass/water/leaves are in greyscale. So, I want to know that:

14 hours ago, MFMods said:

then, the developer tells the game how to recolor these parts of the model.

Posted
32 minutes ago, Sireous said:

So, maybe, it can be done like this?

block.getMaterial().getColor().col

I found out I can call such thing from a BlockState. Is that a current block color?

No, that is the color when it is drawn on a map item.

 

If you want the custom color of a block, look at the BlockColors class e.g.

BlockColors.getColor(BlockState, Level, BlockPos)

The instance the game uses is a private field in the Minecraft class, so you will need to use an access transformer.

https://forge.gemwire.uk/wiki/Access_Transformers

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Posted
29 minutes ago, warjort said:

No, that is the color when it is drawn on a map item.

 

If you want the custom color of a block, look at the BlockColors class e.g.

BlockColors.getColor(BlockState, Level, BlockPos)

The instance the game uses is a private field in the Minecraft class, so you will need to use an access transformer.

https://forge.gemwire.uk/wiki/Access_Transformers

Thanks!

By the way, getColor returns int. How it is converted to RGB or something of that kind?

Posted

It is in the standard hex encoding for RGB. 0xRRGGBB

e.g. 0xFF0000 is pure red.

Minecraft's NativeImage class has some utility methods.

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Looks like I've figured it out, after entirely too much time wasted on trial-and-error.   The solution was to create /resources/data/minecraft/ and place the tags under there, rather than the mod's data directory. I also needed to add  "replace": false, to the JSON files under /resources/data/minecraft/tags/block/ -> needs_stone_tool.json and mineable/pickaxe.json.   I cannot overstate how dumb this is. I don't think developers should be needing to create additive Minecraft subdirectories for files that belong to a mod. These properties should belong to the block properties anyway, since we're specifying that a tool is required... we should be specifying what that tool is in the same place. (I'm so glad I came back to this mess!) Anyway, it is fixed. Hopefully this helps some poor unsuspecting newbie somewhere down the road.
    • I downloaded Forgematice, moved the file to the mods folder, but after starting Minecraft it does not detect any modifications, I need help
    • Upon registering a new account on here, there's a simple security question. Something along the lines of "name a tool you can craft in vanilla Minecraft" and "name a weapon you can craft in vanilla Minecraft". I answered these with answers that are correct. Yet I'm told I "didn't pass the security check". This happens with every answer to every question. If you can't craft a pickaxe, or use a sword as a weapon in vanilla Minecraft then you and I must be playing a totally different game!!
    • Hello, and happy new year! I've returned to modding while on break from work, and cannot make heads or tails of the method for setting the correct tool for breaking a custom block. This should be a simple affair, but after digging through the vanilla files, all I could find was  assets/data/minecraft/tags/block/mineable/pickaxe.json (and axe, hoe, shovel). So I figured this must be how they're specifying the tool for each block. Yet, after implementing a similar file in my own data folder, it still doesn't work. Plus, this doesn't address the issue of specifying what level of tool is required (wood/stone/iron, etc).   So, please... how should this be being done, properly? And could it be done through the Java code rather than JSON files, without overriding functions for block breaking? I'm either missing something obvious, or -- as is more likely the case -- this is just far more convoluted than it ought to be, for something that should just be a field or two in the Block Properties.
    • and this forge error, is just for forge 1.19.2
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.