Jump to content

Check "is single player" and not run mod at all


Roland

Recommended Posts

Hello. I write anti-griefer server-side-only mod. It has connection to database. So I need to run in on multiplayer only, not in single player.

I spent some time trying to determine is it singleplayer or not and how to "stop" (not load? not run?) mod correctly, but still no ideas.

Now I have the following code, that I copy in every method of my mod. Looks ugly and not right.

Checking:

private boolean isSinglePlayer() {
    try {
        if (ServerLifecycleHooks.getCurrentServer().isSingleplayer())
            return true;
    } catch (Exception e) {
        return true;
    }
    return false;
}

Using:

@SubscribeEvent
public void serverLoad(RegisterCommandsEvent event) throws IOException {
    if (isSinglePlayer()) {
        return;
    }
    // ...
}

Just in case: ServerLifeCycleHooks is needed because I don't know any other GLOBAL class that can return me current server. try-catch is needed because "current server" may not even exist. And using my "serverLoad" method in every other methods... Ugh. I'm speechless.

Can you tell me, guys, how to do it correctly?

Link to comment
Share on other sites

 

@Mod.EventBusSubscriber(modid = MODID, value = Dist.DEDICATED_SERVER)

Or for more details:

https://forge.gemwire.uk/wiki/Sides

Please familiarise yourself with the whole wiki.

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

1 hour ago, warjort said:

Or for more details:

I tried it:

@Mod(MyLogger.MOD_ID)
@Mod.EventBusSubscriber(modid = MyLogger.MOD_ID, value = Dist.DEDICATED_SERVER)
public class MyLogger {
    // ...

But:

1) It works only if I add "@OnlyIn(Dist.DEDICATED_SERVER)" above every event handler like this:

@SubscribeEvent
@OnlyIn(Dist.DEDICATED_SERVER)
public void onPlayerTick(TickEvent.PlayerTickEvent event) {
    // ...

2) My command event handler stop working. Handler:

@SubscribeEvent
@OnlyIn(Dist.DEDICATED_SERVER)
public void onPlayerEnteredCommand(CommandEvent event) {
    String playerName = Objects.requireNonNull(event.getParseResults().getContext().getSource().getPlayer()).getGameProfile().getName();
    if (playersCanExecListOfCommands.get(playerName) != true) {
        event.setCanceled(true);
    }
}

Error:

[Server thread/ERROR] [ne.mi.ev.EventBus/EVENTBUS]: Exception caught during firing event: null
        Index: 1
        Listeners:
                0: NORMAL
                1: ASM: ru.tester.mylogger.MyMod@59a50d8a onPlayerEnteredCommand(Lnet/minecraftforge/event/CommandEvent;)V
java.lang.NullPointerException
        at java.base/java.util.Objects.requireNonNull(Objects.java:208)
        at TRANSFORMER/[email protected]/ru.tester.mylogger.MyLogger.onPlayerEnteredCommand(PinMod.java:94)
        at TRANSFORMER/[email protected]/ru.tester.mylogger.__MyLogger_onPlayerEnteredCommand_CommandEvent.invoke(.dynamic)

 

Link to comment
Share on other sites

@ModEventBusSubscriber only works with static methods.

https://forge.gemwire.uk/wiki/Events (the very next entry on the wiki after the one I posted above).

if you are using @OnlyIn you are doing it wrong.

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.