[1.19.4] The needs_X_tool tag is ignored for doors

[JimiIT92]

I'm making custom doors in my mod and I noticed something odd. I've added my door to the needs_iron_tool tag and the mineable/pickaxe tag, both inside the minecraft namespace (although I don't think the namespace matters). But, when I mine the door with a wooden or stone pickaxe, I still get the drop. I've then tried to do the same with the vanilla Iron Door, adding it to the iron_tools tag as well, and sure enough I stil get the drop. The function isCorrectToolFroDrops inside the DiggerItem class is returning false when trying to mine my door with a lower tier pickaxe, so I really don't know why it gets ignored. I have other blocks in that tags as well and they all function as expected (drops when using iron or above tier pickaxe, no drop when using stone or wood pickaxe).

Just for context this is how I register my custom door
 

BLOCKS_REGISTRY.register("golden_door", () -> new DoorBlock(BlockBehaviour.Properties.copy(Blocks.IRON_DOOR), BlockSetType.GOLD));

Then, inside the minecraft/tags/blocks/mineable/pickaxe.json and minecraft/tags/blocks/needs_iron_tool.json I have this

{
  "replace": false,
  "values": [
    "mineworld:golden_door"
  ]
}

If you need more context I've everything available on GitHub 
Here is where I register the door: https://github.com/JimiIT92/MineWorld/blob/ab04acfee10569f2339f9877fddd95b58e34336a/src/main/java/org/mineworld/core/MWBlocks.java#L263
While here you can find the block tags: https://github.com/JimiIT92/MineWorld/tree/master/src/main/resources/data/minecraft/tags/blocks

[warjort]

In your registration code, you are copy the BlockBehaviour.Properties from the vanilla doors.

Neither of these has the requiresCorrectToolForDrops() property set.

See Player.hasCorrectToolForDrops()

[JimiIT92]

10 minutes ago, warjort said:

Neither of these has the requiresCorrectToolForDrops() property set.

In Blocks.java you can see that the Iron door has the requireCorrectToolForDrops() property set
 

public static final Block IRON_DOOR = register("iron_door", new DoorBlock(BlockBehaviour.Properties.of(Material.METAL, MaterialColor.METAL).requiresCorrectToolForDrops().strength(5.0F).noOcclusion(), BlockSetType.IRON));

By the way I've also tried to manually set the property myself, so doing like this
 

BlockBehaviour.Properties.copy(Blocks.IRON_DOOR).requiresCorrectToolForDrops()

but doesn't work as well.

The only difference is that vanilla doors doesn't have a tier set, but that doesn't explain why if you add them or a block with the same properties under that requirement it gets ignored

Edited April 9, 2023 by JimiIT92
Added more context

[warjort]

I don't know then.

You could use the PlayerEvent.HarvestCheck event to see what the actual values are for the BlockState and the player's held item when it does the check.

To see if they are what you expect.