Jump to content

[1.19.4] The needs_X_tool tag is ignored for doors


JimiIT92

Recommended Posts

I'm making custom doors in my mod and I noticed something odd. I've added my door to the needs_iron_tool tag and the mineable/pickaxe tag, both inside the minecraft namespace (although I don't think the namespace matters). But, when I mine the door with a wooden or stone pickaxe, I still get the drop. I've then tried to do the same with the vanilla Iron Door, adding it to the iron_tools tag as well, and sure enough I stil get the drop. The function isCorrectToolFroDrops inside the DiggerItem class is returning false when trying to mine my door with a lower tier pickaxe, so I really don't know why it gets ignored. I have other blocks in that tags as well and they all function as expected (drops when using iron or above tier pickaxe, no drop when using stone or wood pickaxe).

Just for context this is how I register my custom door
 

BLOCKS_REGISTRY.register("golden_door", () -> new DoorBlock(BlockBehaviour.Properties.copy(Blocks.IRON_DOOR), BlockSetType.GOLD));

Then, inside the minecraft/tags/blocks/mineable/pickaxe.json and minecraft/tags/blocks/needs_iron_tool.json I have this

{
  "replace": false,
  "values": [
    "mineworld:golden_door"
  ]
}

If you need more context I've everything available on GitHub 
Here is where I register the door: https://github.com/JimiIT92/MineWorld/blob/ab04acfee10569f2339f9877fddd95b58e34336a/src/main/java/org/mineworld/core/MWBlocks.java#L263
While here you can find the block tags: https://github.com/JimiIT92/MineWorld/tree/master/src/main/resources/data/minecraft/tags/blocks

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

In your registration code, you are copy the BlockBehaviour.Properties from the vanilla doors.

Neither of these has the requiresCorrectToolForDrops() property set.

See Player.hasCorrectToolForDrops()

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

10 minutes ago, warjort said:

Neither of these has the requiresCorrectToolForDrops() property set.

In Blocks.java you can see that the Iron door has the requireCorrectToolForDrops() property set
 

public static final Block IRON_DOOR = register("iron_door", new DoorBlock(BlockBehaviour.Properties.of(Material.METAL, MaterialColor.METAL).requiresCorrectToolForDrops().strength(5.0F).noOcclusion(), BlockSetType.IRON));

By the way I've also tried to manually set the property myself, so doing like this
 

BlockBehaviour.Properties.copy(Blocks.IRON_DOOR).requiresCorrectToolForDrops()

but doesn't work as well.

The only difference is that vanilla doors doesn't have a tier set, but that doesn't explain why if you add them or a block with the same properties under that requirement it gets ignored

Edited by JimiIT92
Added more context

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

I don't know then.

You could use the PlayerEvent.HarvestCheck event to see what the actual values are for the BlockState and the player's held item when it does the check.

To see if they are what you expect.

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Falling victim to a scam is a distressing reality many face. I found myself in such a predicament not too long ago, having invested a significant amount of money in what I believed to be a promising platform, only to discover it was nothing more than a fraudulent scheme. The devastating realization that my hard-earned funds had vanished and left me feeling helpless and vulnerable until I found a glimmer of hope in the form of TECHNOCRATE RECOVERY. Discovering TECHNOCRATE RECOVERY felt like stumbling upon a lifeline amidst the turbulent sea of financial fraud. Their reputation as a remarkable team of professionals specializing in assisting individuals in recovering funds lost to scams preceded them, offering a ray of hope in my darkest hour. With trepidation and a flicker of optimism, I reached out to them, hoping against hope for a chance at redemption. From the very first interaction, TECHNOCRATE RECOVERY proved themselves to be true lifesavers. Their compassion, professionalism, and unwavering dedication to my cause were evident from the outset, instilling a sense of trust and reassurance in their abilities. They wasted no time in springing into action, meticulously gathering the necessary information, and laying out a strategic plan for the recovery process. What followed was nothing short of miraculous. With precision and expertise, TECHNOCRATE RECOVERY navigated the complexities of cryptocurrency scams, uncovering the deceit and reclaiming what was rightfully mine. MAIL BOX: Technocratrecovery(@)contractor(.)net   WEBSITE INFO: www (.)technocraterecovery(.)site
    • Hello, I have been suffering with consistent crashes either during load up or during play-time. I have updated all drivers, updated and reinstalled java versions, and tried curseforge, GDLauncher, and PrismLauncher. I am struggling to find the issue of the crash as it is inhibiting me from playing. Please help, thanks. https://pastebin.com/GnQHr6sZ https://pastebin.com/6EyR1Sgk
    • Hello, I am trying to join a server with mods, specifically a Custom Profile Modpack I made. I have no idea how to identify the problem, please help. I attached the error, Modpack, and the Crash Report it gave me. Mods: https://ibb.co/N7p6Pgr Modpack: https://drive.google.com/file/d/1KCEyq_sGAF9q7tilKbdGOubpKeUdHRHx/view?usp=sharing Minecraft Crash Report: https://paste.ee/p/zISCN Minecraft Launcher Error Image: https://ibb.co/sbwQRb4
    • Thanks for the response. I ended up going with this:   public class PlayerDeathHandler { @SubscribeEvent public void playerKilled(LivingDeathEvent event) { if (event.getEntity() instanceof Player player) { ItemStack poppetStack = new ItemStack(ModItems.DEATH_PROTECTION_POPPET.get()); if (player.getInventory().contains(poppetStack)) { event.setCanceled(true); player.setHealth(player.getMaxHealth()); for (int i = 0; i < player.getInventory().getContainerSize(); i++) { ItemStack stackInSlot = player.getInventory().getItem(i); if (stackInSlot.getItem() == poppetStack.getItem()) { stackInSlot.shrink(1); if (stackInSlot.isEmpty()) { player.getInventory().setItem(i, ItemStack.EMPTY); } break; } } } } } } It works like a charm, but are there any issues that COULD arise using this? I don't have much experience with Forge, so I'm not sure about the common issues and whatnot.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.