Jump to content

[SOLVED] 152 -> 162 IItemRender changes (only uses item texture sheet)


shadowmage4513

Recommended Posts

So, finally updating my mod to 1.6.2.

 

Most things went as smooth as they could, but I've been banging my head against a problem for a few hours now, something that makes absolutely no sense.

 

What changed with IItemRenders between 1.5 and 1.6?  I had an item that rendered as a block in 1.5.2, but in 1.6.2 it refuses to bind the block icons.  It instead renders a random icon off of the items icon sheet -- it seems completely random as I get fish, golden carrots, and icons from my own mod used, though it is consistent for a give id/meta.  I'm guessing its not switching the base-texture sheet from the item sheet but still using the UV from my block Icon.

 

Any way to force it to use the block texture sheet?  Should I just double-register all of my icons for use as an item icon (no clue if this will work...)?  Any other simple methods for rendering an item as a block?  (the item is not an ItemBlock -- the Item and Block are completely separate for whatever reason I designed it that way....NFC anymore, and will probably just end up rewriting the whole system if I can't get this weird shit figured out)

 

 

Strangely, if I pull the icon instance out and query it for iconName -- it returns the proper icon path for what I would expect, only the texture that is rendered is wrong.

 

Anyhow..here is the render code.  Its pretty standard, taken almost exactly from the RenderBlocks methods.  It worked fine in 1.5.2.

 

(i have the par2/meta value set to 0 until I figure out the icon issues -- 0 is a valid meta and should be pulling up the same icon as the block uses to render)

 

@Override
public void renderItem(ItemRenderType type, ItemStack item, Object... data)
  {
  if(type==ItemRenderType.FIRST_PERSON_MAP)
    {
    return;
    }  
  RenderBlocks render = (RenderBlocks)data[0];
  int blockNum = item.getItemDamage()/16;

  
  Block blk = null;
  switch(blockNum)
    {
    case 0:
    blk = BlockLoader.civicBlock1;
    break;
    
    case 1:
    blk = BlockLoader.civicBlock2;
    break;
    
    case 2:
    blk = BlockLoader.civicBlock3;
    break;
    
    case 3:
    blk = BlockLoader.civicBlock4;
    break;
    
    default:
    blk = BlockLoader.civicBlock1;
    break;
    }
  
  GL11.glPushMatrix();
  if(type!=ItemRenderType.ENTITY)
    {
    GL11.glTranslatef(0.5f, 0.5f, 0.5f);
    GL11.glRotatef(180, 0, 1, 0);
    }
  else
    {
    GL11.glScalef(0.5f, 0.5f, 0.5f);
    }    
   
  int par2 = 0;//meta value
  Block par1Block = blk;
  Tessellator tessellator = Tessellator.instance;
  par1Block.setBlockBoundsForItemRender();
  render.setRenderBoundsFromBlock(par1Block);
  GL11.glRotatef(90.0F, 0.0F, 1.0F, 0.0F);
  GL11.glTranslatef(-0.5F, -0.5F, -0.5F);
  tessellator.startDrawingQuads();
  tessellator.setNormal(0.0F, -1.0F, 0.0F);
  render.renderFaceYNeg(par1Block, 0.0D, 0.0D, 0.0D, render.getBlockIconFromSideAndMetadata(par1Block, 0, par2));
  tessellator.draw();

  tessellator.startDrawingQuads();
  tessellator.setNormal(0.0F, 1.0F, 0.0F);
  render.renderFaceYPos(par1Block, 0.0D, 0.0D, 0.0D, render.getBlockIconFromSideAndMetadata(par1Block, 1, par2));
  tessellator.draw();


  tessellator.startDrawingQuads();
  tessellator.setNormal(0.0F, 0.0F, -1.0F);
  render.renderFaceZNeg(par1Block, 0.0D, 0.0D, 0.0D, render.getBlockIconFromSideAndMetadata(par1Block, 2, par2));
  tessellator.draw();
  tessellator.startDrawingQuads();
  tessellator.setNormal(0.0F, 0.0F, 1.0F);
  render.renderFaceZPos(par1Block, 0.0D, 0.0D, 0.0D, render.getBlockIconFromSideAndMetadata(par1Block, 3, par2));
  tessellator.draw();
  tessellator.startDrawingQuads();
  tessellator.setNormal(-1.0F, 0.0F, 0.0F);
  render.renderFaceXNeg(par1Block, 0.0D, 0.0D, 0.0D, render.getBlockIconFromSideAndMetadata(par1Block, 4, par2));
  tessellator.draw();
  tessellator.startDrawingQuads();
  tessellator.setNormal(1.0F, 0.0F, 0.0F);
  render.renderFaceXPos(par1Block, 0.0D, 0.0D, 0.0D, render.getBlockIconFromSideAndMetadata(par1Block, 5, par2));
  tessellator.draw();
  GL11.glTranslatef(0.5F, 0.5F, 0.5F);
  GL11.glPopMatrix();
  }

Link to comment
Share on other sites

Further testing reveals that if I register the same icon names as item icons (and duplicate all of my block textures =\ ), the IItemRenderer will render the block as intended.

 

More and more it is looking like the IItemRenderer is for some reason not checking the type/origin of the icon to bind the proper texture sheet.  Not sure why it worked in 1.5.2.

 

I will update with more information as I come across it.

Link to comment
Share on other sites

int blockNum = item.getItemDamage()/16;

  
  Block blk = null;
  switch(blockNum)
    {
    case 0:
    blk = BlockLoader.civicBlock1;
    break;

So what are those blocks in BlockLoader class ? Do they have a texture returned by block.getIcon(int,int) ?

 

Yes, the blocks return an icon from that method.  The blocks themselves render fine in the world once placed.  Only the IItemRenderer is binding icons from the item sheet with the same texture UV as the block icons that I am actually using to render.

 

I have a feeling its just a context problem -- e.g. IItemRenderer is called when the render-engine is setup to render items, and has the item texture sheet bound, with no easy way to force it to use the block texture sheet.  (Hence, I give it an icon...it pulls the UV from the icon, but never binds the texture-sheet the icon belongs to)

 

 

 

Link to comment
Share on other sites

It probably has to do with the item renderer pulling icons from the item texture sheet, as the Icon class does not (appear to) contain any information as to which stitched sheet the Icon resides in.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

It probably has to do with the item renderer pulling icons from the item texture sheet, as the Icon class does not (appear to) contain any information as to which stitched sheet the Icon resides in.

 

Thats pretty much what I'm thinking at this point.

 

I registered the same icons as item icons (after copying the textures to the /items/ path), and the blocks register just fine.  Going to have to find a different method though, as I don't like having to duplicate resources to work around a bug. 

 

I should probably just create a proper ItemBlock for the thing, as my other ItemBlock stuff renders fine pulling in block icons/textures.

 

Any way to manually set what texture sheet the render-engine pulls from? 

 

 

Thanks for the input -- one more problem solved/figured out :) (at least for now)

 

 

if(type==ItemRenderType.FIRST_PERSON_MAP)
    {
    return;
    }  

What about ItemRenderType.INVENTORY ? You don't check for that one ?

 

for all types but FIRST_PERSON_MAP it will execute the rest code block following the if/return block.  No need to check explicitly for the INVENTORY type, as that is included in the set of remaining render types.

 

The problem isn't that its not rendering, merely that it was binding textures from the wrong texture sheet for the passed in icon.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • rp.crazyheal.xyz mods  
    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.