Jump to content

Setting allowEdit to false?


SevenDeadly

Recommended Posts

I am trying to set allowEdit to false so that players cannot break certain blocks(vanilla blocks included) with a certain item(vanilla items included) or the fist. However, setting capabilities.allowEdit to false doesn't seem to work. Any ideas?

 

@ForgeSubscribe
public void onPlayerBlockInteraction(PlayerInteractEvent event) {
	if(event.entityPlayer.getHeldItem() != null && event.entityPlayer.getHeldItem().itemID == Item.pickaxeDiamond.itemID) {
		event.entityPlayer.capabilities.allowEdit = false;
		event.entityPlayer.sendPlayerAbilities();
		event.entityPlayer.addChatMessage("You cannot use this item yet!"); //This does successfully send the message, so the message works.
	} else {
		event.entityPlayer.capabilities.allowEdit = true; //Doesn't work whether this is here or not, so not a problem with this.
		event.entityPlayer.sendPlayerAbilities();
	}
}

 

This is all in an event handler. I have tried setting allowEdit to false in other classes too (like a tick handler), however it still fails to work. allowFlying and disableDamage work though, so I do not understand why this doesn't...

 

 

I am also trying to find a way to set allowEdit to false so the player can't edit any blocks at all for another mod I am making, so if anyone knows how to do that I would really appreciate your help. Thanks :)

Link to comment
Share on other sites

When I traced through the NetServerHandler code which handles Packet202 (created by .sendPlayerAbilities), I found this

 

    public Packet202PlayerAbilities(PlayerCapabilities par1PlayerCapabilities)
    {
        this.setDisableDamage(par1PlayerCapabilities.disableDamage);
        this.setFlying(par1PlayerCapabilities.isFlying);
        this.setAllowFlying(par1PlayerCapabilities.allowFlying);
        this.setCreativeMode(par1PlayerCapabilities.isCreativeMode);
        this.setFlySpeed(par1PlayerCapabilities.getFlySpeed());
        this.setWalkSpeed(par1PlayerCapabilities.getWalkSpeed());
    }

 

i.e. PlayerCapabilities.allowEdit is ignored by Packet202.

 

 

Which suggests a couple of workarounds...

either cancel the event like Lycanus suggests,

or write your own custom packet handler which copies allowedit as well as getFlying

 

-TGG

Link to comment
Share on other sites

That was one of my first thought (cancelling the event) before I tried to set allowEdit to false. However, setting the event to canceled did not affect anything at all. That's why I tried moving to setting allowEdit to false, as I hoped that would work. Neither or them worked, but I assume that finding a way to set allowEdit to false will be the easiest way to solve my problem.

Link to comment
Share on other sites

There are other ways of handling this.  Namely, doing something like this in the item's class

 

@Override
public float getStrVsBlock(ItemStack par1ItemStack, Block par2Block) {
	if (par2Block != Block.oreCoal && par2Block != Block.oreIron && par2Block != Block.oreEmerald && par2Block != Block.oreGold && par2Block != Block.oreDiamond && par2Block != Block.oreNetherQuartz && par2Block != Block.oreLapis && par2Block != Block.oreRedstone && par2Block != Block.oreRedstoneGlowing)
        {
		return 0;
        }
	else {
		return 15;
	}
}

 

If the strength vs. the block returns 0 (or less) then no progress is ever made towards breaking it (punching with no/inappropriate tool is roughly 0.25).

The 15 could be modified by material the item is made out of, etc. etc.  This was just a quick implementation for a mod I'm making where it is not yet important what value is being returned, only that it is sufficiently large.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

There are other ways of handling this.  Namely, doing something like this in the item's class

 

@Override
public float getStrVsBlock(ItemStack par1ItemStack, Block par2Block) {
	if (par2Block != Block.oreCoal && par2Block != Block.oreIron && par2Block != Block.oreEmerald && par2Block != Block.oreGold && par2Block != Block.oreDiamond && par2Block != Block.oreNetherQuartz && par2Block != Block.oreLapis && par2Block != Block.oreRedstone && par2Block != Block.oreRedstoneGlowing)
        {
		return 0;
        }
	else {
		return 15;
	}
}

 

If the strength vs. the block returns 0 (or less) then no progress is ever made towards breaking it (punching with no/inappropriate tool is roughly 0.25).

The 15 could be modified by material the item is made out of, etc. etc.  This was just a quick implementation for a mod I'm making where it is not yet important what value is being returned, only that it is sufficiently large.

 

That would work for custom items, but I need to disable the breaking of blocks with the fist and vanilla items somehow as well.

Link to comment
Share on other sites

That is a mite bit trickier, but doable.

 

Your options:

1) Reflections (tricky, as Reflections is not a simple thing)

2) Base class edits (I would hazard you would not like this)

3) Creating custom items and then forcing them into the items array where the vanilla items reside (not entirely kosher)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Where would you recommend I start with reflections? I haven't had any experience with reflections. (Not really that far into Java yet.)

 

I, myself, have only managed so far as to not completely fuck things up doing a minor thing, largely through the use of existing code, lots of Javadoc, and some blind luck.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Hi

 

Not so sure about the setHardness method.  It would probably work but modifying vanilla blocks doesn't sound like a very robust solution.  Apart from anything else, you would have to store the block hardnesses and return them to the original values which might be difficult to get right.

 

I'd suggest the custom packet method.  There are a few tutorials around and it looks like it should be pretty straightforward.  And robust.

 

eg

http://www.minecraftforge.net/wiki/Packet_Handling

 

-TGG

Link to comment
Share on other sites

I wouldn't be changing the base-class of the blocks. I would get the blocks default value, store it in a variable, then call the setHardness method from one of my custom classes. If the player needs to be able to edit the blocks, I can have a command that, when used, calls a method that resets all the blocks to their default value. Simple as that.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • rp.crazyheal.xyz mods  
    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.