[SOLVED] [1.19.4] Double stained glass slab renders as a solid cube

[JimiIT92]

I'm making some stained glass slabs, and by doing so, in the blockstates file, I reference the minecraft full block model for the double slab variant

{
  "variants": {
    "type=bottom": {
      "model": "mineworld:block/pink_stained_glass_slab"
    },
    "type=double": {
      "model": "minecraft:block/pink_stained_glass"
    },
    "type=top": {
      "model": "mineworld:block/pink_stained_glass_slab_top"
    }
  }
}

however the double slab renders as a solid cube in game (while the bottom and top slabs renders correctly since I added the render_type: translucent inside the model JSON file

For reference this is how I create the slab block (nothing too crazy)

new SlabBlock(BlockBehaviour.Properties.copy(Blocks.PINK_STAINED_GLASS)).requiresCorrectToolForDrops())

You can also see the full source here: https://github.com/JimiIT92/MineWorld/blob/master/src/main/java/org/mineworld/core/MWBlocks.java#L1039

So what am I missing here that causes this incorrect rendering?

Edited April 22, 2023 by JimiIT92
solved

[warjort]

The vanilla block models don't set the render_type in their models (that's a forge thing).

They register them programmatically. Which means the render type used comes from the block not the model.

Since you haven't set a render type for your block, it will use the default, which is solid.

 

So do one of;

* Programmatically register your block's render type as translucent: https://github.com/search?q=ItemBlockRenderTypes&type=code

* Copy the vanilla model and make your own with a render_type specified

[JimiIT92]

I was already thinking about duping the model, also since the ItemBlockRenderTypes#setRenderLayer is marked as deprecated. Was wondering if there was a way to don't dupe the model. Thank you anyway