[1.19.4] How did we add enchantments by default to items with getDefaultInstance?

[Feroov]

So I'm trying to add piercing by default already applied to my custom ranged weapon, I got this currently, I did this in the past but I forgot, I do remember it had something to do with getDefaultInstance:

 

    @Override
    public ItemStack getDefaultInstance()
    {
        ItemStack defaultInstance = new ItemStack(this);
        EnchantmentHelper.setEnchantments(Collections.singletonMap(Enchantments.PIERCING, 1), defaultInstance);
        return defaultInstance;
    }

 

Thank you so much in advance

[Feroov]

#Edit

 

Apparently getDefaultInstance is maybe not what we're looking for, in that case what can we do?

[warjort]

getDefaultInstance() is what you want, assuming that is what is actually used to create the ItemStack which is not always true.

e.g.

new ItemStack(item, 1)

wouldn't call that method.

 

For recipes you will likely need to use the Forge NBT extension:

https://docs.minecraftforge.net/en/latest/resources/server/recipes/#additional-features

or you might want create a custom recipe type with its own assemble() to do it programmatically

https://docs.minecraftforge.net/en/latest/resources/server/recipes/custom/#recipe

 

And loot tables have a number of LootItemFunctions for enchanting.

Edited May 2, 2023 by warjort