Jump to content

Recommended Posts

Posted

It is not the purpose of this forum to teach basic java.

But try this stripped down emulation of your code:

public class Test {

    public static record Fluid(Map<String, String> properties) {}

    public static Supplier<Fluid> FLUID = getFluid(Test.FLUID_PROPERTIES); // FLUID_PROPERTIES = null at this point
    public static Map<String, String> FLUID_PROPERTIES = Map.of("test", "Hello");

    public static Supplier<Fluid> getFluid(Map<String, String> properties) {
        return () -> new Fluid(properties);
    }

    public static void main(String[] args) {
        System.out.println(FLUID.get().properties()); // prints null
    }
}

Now try this:

public class Test {

    public static record Fluid(Map<String, String> properties) {}

    public static Supplier<Fluid> FLUID = getFluid(() -> Test.FLUID_PROPERTIES); // So pass a supplier instead to defer access
    public static Map<String, String> FLUID_PROPERTIES = Map.of("test", "Hello");

    public static Supplier<Fluid> getFluid(Supplier<Map<String, String>> properties) {
        return () -> new Fluid(properties.get());
    }

    public static void main(String[] args) {
        System.out.println(FLUID.get().properties()); // prints {test=Hello}
    }
}

 

If you don't understand how static initialisation and suppliers work, you have little chance at writing a mod correctly.

Both Forge and Vanilla use this technique ubiquitously.

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Posted (edited)

I think you solved my problem. Thank you so much! I changed the parameter in get fluid() from ForgeFlowingFluid.Properties to Supplier<ForgeFlowingFluid.Properties> and Minecraft finally launched!

Edited by NetherNoah777
  • NetherNoah777 changed the title to Crash in my mod's fluid setup class. What am I doing wrong here? [solved]

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • As the title states; I recently set up a modded server using a custom modpack. After some troubleshooting and figuring some things out since I'm not super experienced running servers, the server works just fine. As far as I can tell by running around in creative for 5-10 minutes, every mod is functioning as intended and the server held up just fine to whatever random stuff I did to try to get it or my client to crash. However, on the multiplayer screen when going to join a server, it says that it can't connect to the server. This seems to be a very minor issue and I think I know why it's being caused, that being a mismatched mod list - even though I've triple-checked that all mods required to be on the server are on the server and vice versa. Just making this post to see if anyone else could tell me why this is happening and if it even matters, this is just a small server for some friends and I, but I'd like to resolve it if possible so people can see if anyone's online without having to actually join the server to find out. Thanks for any help you might be able to give me!  
    • Are you saying I should change max-tick-time to -1 or are you asking if it's set to -1? "max-tick-time=60000" That's what the settings are currently on the server
    • Hi, Love the project, the team, and the mods! Been on for about 2 years since 47.0.16, loving every moment. When recently updating from 47.4.6 to 47.4.8 last night, been having troubles getting any flags to apply at startup, irregardless if done through a server GUI/modlauncher (auto-mcs) nor manually through the *.bat Aikir/Dakkar, none of them seem to apply. It seems 47.4.8 ignores flags, unless we are experiencing another issue. Also seems to be forcing JAVA 17 compatibility mode, a callout we hadn't seen before. Anyone experienced this? Cheers!
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.