Search the Forums BEFORE making a new post.

Item not creating NBT Tags

Posted September 21, 201312 yr

I'm currently trying to add NBT tags to my item when it's created, but it never adds the tags nor the information.

package tlhpoe.darkorigins.item;

import java.awt.List;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.ChunkCoordinates;
import net.minecraft.world.World;
import tlhpoe.darkorigins.helper.CreativeTabHelper;
import tlhpoe.darkorigins.util.InfoUtil;

public class ItemExpContainer extends ItemBase
{

public ItemExpContainer(int id, String name)
{

	super(id, name);

	setMaxStackSize(1);
	setUnlocalizedName(name);
	setCreativeTab(CreativeTabHelper.items);

}

@Override
public void onCreated(ItemStack itemstack, World world, EntityPlayer player)
{

	itemstack.stackTagCompound = new NBTTagCompound();

	itemstack.stackTagCompound.setFloat("stored", 0.0F);
	itemstack.stackTagCompound.setInteger("mode", 0);

}

public void addInformation(ItemStack itemStack, EntityPlayer player, List list, boolean par4)
{

	if (itemStack.stackTagCompound != null)
	{

		float amount = itemStack.stackTagCompound.getFloat("stored");
		int mode = itemStack.stackTagCompound.getInteger("mode");
		String modeD = "";

		switch(mode)
		{
		case(0):{modeD = "Deposit";}
		case(1):{modeD = "Withdraw";}
		}

		list.add("Exp Stored: " + amount);
		list.add("Mode: " + modeD);

	}

}

@Override
    public ItemStack onItemRightClick(ItemStack itemstack, World world, EntityPlayer player)
    {

	if(player.isSneaking())
	{

		int mode = itemstack.stackTagCompound.getInteger("mode");

		switch(mode)
		{

		case(0):{itemstack.stackTagCompound.setInteger("mode", 1);}
		case(1):{itemstack.stackTagCompound.setInteger("mode", 0);}

		}

	}

	if(!player.isSneaking())
	{

		int mode = itemstack.stackTagCompound.getInteger("mode");
		float xp = itemstack.stackTagCompound.getInteger("stored");

		switch(mode)
		{

		case(0):
		{

			if(player.experienceLevel >= 1)
			{

				player.experienceLevel--;
				itemstack.stackTagCompound.setFloat("stored", xp++);

			}

		}

		case(1):
		{

			if(xp >= 1)
			{

				player.experienceLevel++;
				itemstack.stackTagCompound.setFloat("stored", xp--);

			}

		}

		}

	}

	return itemstack;

    }

}

Kain

Quote

September 21, 201312 yr

onCreated is only called when the Item is crafted or smelted, while addInformation is called when you mouse over the item, such as in a Creative Tab, at which point it hasn't been created yet.

You need to check if the NBT tag is null and create a new one if so in any method that may need to access it.

http://i.imgur.com/NdrFdld.png[/img]

Quote

September 21, 201312 yr

Author

I added null checks, and if it was null, I created the NBT. It crashes on Right Click (I craft it and then right click it, still not information)

http://pastebin.com/j9dXXEC3

2013-09-21 19:20:44 [iNFO] [sTDERR] net.minecraft.util.ReportedException: Reading NBT data
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.network.NetworkListenThread.networkTick(NetworkListenThread.java:63)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.server.integrated.IntegratedServerListenThread.networkTick(IntegratedServerListenThread.java:109)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:691)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:587)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:129)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:484)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.server.ThreadMinecraftServer.run(ThreadMinecraftServer.java:16)
2013-09-21 19:20:44 [iNFO] [sTDERR] Caused by: java.lang.ClassCastException: net.minecraft.nbt.NBTTagFloat cannot be cast to net.minecraft.nbt.NBTTagInt
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.nbt.NBTTagCompound.getInteger(NBTTagCompound.java:233)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at tlhpoe.darkorigins.item.ItemExpContainer.onItemRightClick(ItemExpContainer.java:101)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.item.ItemStack.useItemRightClick(ItemStack.java:176)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.item.ItemInWorldManager.tryUseItem(ItemInWorldManager.java:353)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.network.NetServerHandler.handlePlace(NetServerHandler.java:542)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.network.packet.Packet15Place.processPacket(Packet15Place.java:79)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.network.MemoryConnection.processReadPackets(MemoryConnection.java:89)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.network.NetServerHandler.networkTick(NetServerHandler.java:141)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	at net.minecraft.network.NetworkListenThread.networkTick(NetworkListenThread.java:54)
2013-09-21 19:20:44 [iNFO] [sTDERR] 	... 6 more
2013-09-21 19:20:44 [sEVERE] [Minecraft-Server] Encountered an unexpected exception ReportedException
net.minecraft.util.ReportedException: Reading NBT data
at net.minecraft.network.NetworkListenThread.networkTick(NetworkListenThread.java:63)
at net.minecraft.server.integrated.IntegratedServerListenThread.networkTick(IntegratedServerListenThread.java:109)
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:691)
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:587)
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:129)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:484)
at net.minecraft.server.ThreadMinecraftServer.run(ThreadMinecraftServer.java:16)
Caused by: java.lang.ClassCastException: net.minecraft.nbt.NBTTagFloat cannot be cast to net.minecraft.nbt.NBTTagInt
at net.minecraft.nbt.NBTTagCompound.getInteger(NBTTagCompound.java:233)
at tlhpoe.darkorigins.item.ItemExpContainer.onItemRightClick(ItemExpContainer.java:101)
at net.minecraft.item.ItemStack.useItemRightClick(ItemStack.java:176)
at net.minecraft.item.ItemInWorldManager.tryUseItem(ItemInWorldManager.java:353)
at net.minecraft.network.NetServerHandler.handlePlace(NetServerHandler.java:542)
at net.minecraft.network.packet.Packet15Place.processPacket(Packet15Place.java:79)
at net.minecraft.network.MemoryConnection.processReadPackets(MemoryConnection.java:89)
at net.minecraft.network.NetServerHandler.networkTick(NetServerHandler.java:141)
at net.minecraft.network.NetworkListenThread.networkTick(NetworkListenThread.java:54)
... 6 more
2013-09-21 19:20:44 [sEVERE] [Minecraft-Server] This crash report has been saved to: C:\Users\Kavin\Desktop\Programming\Java\Modding\RPG Additions\forge\mcp\jars\.\crash-reports\crash-2013-09-21_19.20.44-server.txt
2013-09-21 19:20:44 [iNFO] [Minecraft-Server] Stopping server
2013-09-21 19:20:44 [iNFO] [Minecraft-Server] Saving players
2013-09-21 19:20:44 [iNFO] [Minecraft-Server] Player193 left the game
2013-09-21 19:20:44 [iNFO] [Minecraft-Server] Saving worlds
2013-09-21 19:20:44 [iNFO] [Minecraft-Server] Saving chunks for level 'New World'/Overworld
2013-09-21 19:20:44 [iNFO] [Minecraft-Server] Saving chunks for level 'New World'/Nether
2013-09-21 19:20:44 [iNFO] [Minecraft-Server] Saving chunks for level 'New World'/The End
2013-09-21 19:20:45 [iNFO] [ForgeModLoader] Unloading dimension 0
2013-09-21 19:20:45 [iNFO] [ForgeModLoader] Unloading dimension -1
2013-09-21 19:20:45 [iNFO] [ForgeModLoader] Unloading dimension 1
2013-09-21 19:20:45 [iNFO] [ForgeModLoader] The state engine was in incorrect state SERVER_STOPPING and forced into state SERVER_STOPPED. Errors may have been discarded.
2013-09-21 19:20:45 [iNFO] [sTDERR] net.minecraft.util.ReportedException: Reading NBT data
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at net.minecraft.nbt.NBTTagCompound.getInteger(NBTTagCompound.java:237)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at tlhpoe.darkorigins.item.ItemExpContainer.onItemRightClick(ItemExpContainer.java:101)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at net.minecraft.item.ItemStack.useItemRightClick(ItemStack.java:176)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at net.minecraft.client.multiplayer.PlayerControllerMP.sendUseItem(PlayerControllerMP.java:428)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.clickMouse(Minecraft.java:1415)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1866)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:908)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.run(Minecraft.java:836)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at net.minecraft.client.main.Main.main(Main.java:93)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at java.lang.reflect.Method.invoke(Unknown Source)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at net.minecraft.launchwrapper.Launch.launch(Launch.java:131)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at net.minecraft.launchwrapper.Launch.main(Launch.java:27)
2013-09-21 19:20:45 [iNFO] [sTDERR] Caused by: java.lang.ClassCastException: net.minecraft.nbt.NBTTagFloat cannot be cast to net.minecraft.nbt.NBTTagInt
2013-09-21 19:20:45 [iNFO] [sTDERR] 	at net.minecraft.nbt.NBTTagCompound.getInteger(NBTTagCompound.java:233)
2013-09-21 19:20:45 [iNFO] [sTDERR] 	... 14 more
2013-09-21 19:20:45 [iNFO] [sTDOUT] ---- Minecraft Crash Report ----
2013-09-21 19:20:45 [iNFO] [sTDOUT] // I bet Cylons wouldn't have this problem.
2013-09-21 19:20:45 [iNFO] [sTDOUT] 
2013-09-21 19:20:45 [iNFO] [sTDOUT] Time: 9/21/13 7:20 PM
2013-09-21 19:20:45 [iNFO] [sTDOUT] Description: Reading NBT data
2013-09-21 19:20:45 [iNFO] [sTDOUT] 
2013-09-21 19:20:45 [iNFO] [sTDOUT] java.lang.ClassCastException: net.minecraft.nbt.NBTTagFloat cannot be cast to net.minecraft.nbt.NBTTagInt
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.nbt.NBTTagCompound.getInteger(NBTTagCompound.java:233)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at tlhpoe.darkorigins.item.ItemExpContainer.onItemRightClick(ItemExpContainer.java:101)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.item.ItemStack.useItemRightClick(ItemStack.java:176)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.client.multiplayer.PlayerControllerMP.sendUseItem(PlayerControllerMP.java:428)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.client.Minecraft.clickMouse(Minecraft.java:1415)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1866)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:908)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.client.Minecraft.run(Minecraft.java:836)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.client.main.Main.main(Main.java:93)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at java.lang.reflect.Method.invoke(Unknown Source)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.launchwrapper.Launch.launch(Launch.java:131)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.launchwrapper.Launch.main(Launch.java:27)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 
2013-09-21 19:20:45 [iNFO] [sTDOUT] 
2013-09-21 19:20:45 [iNFO] [sTDOUT] A detailed walkthrough of the error, its code path and all known details is as follows:
2013-09-21 19:20:45 [iNFO] [sTDOUT] ---------------------------------------------------------------------------------------
2013-09-21 19:20:45 [iNFO] [sTDOUT] 
2013-09-21 19:20:45 [iNFO] [sTDOUT] -- Corrupt NBT tag --
2013-09-21 19:20:45 [iNFO] [sTDOUT] Details:
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	Tag type found: FLOAT
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	Tag type expected: INT
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	Tag name: stored
2013-09-21 19:20:45 [iNFO] [sTDOUT] Stacktrace:
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.nbt.NBTTagCompound.getInteger(NBTTagCompound.java:233)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at tlhpoe.darkorigins.item.ItemExpContainer.onItemRightClick(ItemExpContainer.java:101)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.item.ItemStack.useItemRightClick(ItemStack.java:176)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.client.multiplayer.PlayerControllerMP.sendUseItem(PlayerControllerMP.java:428)
2013-09-21 19:20:45 [iNFO] [sTDOUT] 	at net.minecraft.client.Minecraft.clickMouse(Minecraft.java:1415)

Kain

Quote

September 21, 201312 yr

The error log says it all: can't cast NBTTagFloat as NBTTagInt.

Do you see:

float xp = itemStack.stackTagCompound.getInteger("stored");

http://i.imgur.com/NdrFdld.png[/img]

Quote

September 22, 201312 yr

Author

It doesn't crash or give off errors any more, but it never displays the information.

http://pastebin.com/8Z8P8pUb

Kain

Quote

September 22, 201312 yr

All your switches are missing break statement.

Quote

September 22, 201312 yr

Author

The breaks fixed the depositing/withdrawing part. Information still doesn't display though. :I

Kain

Quote

September 22, 201312 yr

Perhaps try adding '@Override' annotation above your addInformation method?

http://i.imgur.com/NdrFdld.png[/img]

Quote

September 22, 201312 yr

Might be an error in the tags.

Store the String tags as static final fields and use them instead.

Quote

September 22, 201312 yr

Author

Oh, found the problem. I was using the wrong parameters for the addInformation method.

Kain

Quote

September 23, 201311 yr

Perhaps try adding '@Override' annotation above your addInformation method?

I don't think that annotation means what you think it means.

--Inigo Montoya

(Hint: That particular annotation only has an effect inside your IDE to trigger additional error checking; leaving it off has no effect once the program is compiled)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

September 23, 201311 yr

Perhaps try adding '@Override' annotation above your addInformation method?

I don't think that annotation means what you think it means.

--Inigo Montoya

(Hint: That particular annotation only has an effect inside your IDE to trigger additional error checking; leaving it off has no effect once the program is compiled)

Adding it helped him figure out he had the incorrect method signature. I'd say that's a pretty useful purpose even if at compile time it doesn't change the outcome.

http://i.imgur.com/NdrFdld.png[/img]

Quote

September 23, 201311 yr

Hello,

BTW, the onCreate wasn't being called for me, when i shift-clicked the item out of the crafting table.

ss7

You sir are a god damn hero.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/12364-item-not-creating-nbt-tags/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · 7 hours ago7 hr
Orbital strike cannon fishing rod mod

@FoxyWoxy do you potentially have an estimated time for fabric 1.21.5 and what will it be posted on (modrinth, etc.)

By JayKing014 · 10 hours ago10 hr
Orbital strike cannon fishing rod mod

By FoxyWoxy · 11 hours ago11 hr
New Forum Design/Update: Issues and Suggestions

I don't know that either - newer worked with Invision Community 😕

The Forum/Guides show a customized toolbar:
https://invisioncommunity.com/4guides/themes-and-customizations/editor-and-emoticons_327/customizing-editor-toolbars-r132/
But I have no idea if this applies to v5

Regarding the Forum, "Mark all as read" seems to be hidden as default but is available if I click on my profile:
https://invisioncommunity.com/forums/topic/481218-fix-for-unreadmark-read/

I saw that it works here and also fixes the one unread thread mentioned in my first post - so I had just overlooked it

The toolbar changes are just QoL - if there is no way to change it at the moment, that's fine

By TileEntity · 13 hours ago13 hr
New Forum Design/Update: Issues and Suggestions

I understand what you're asking for, but I don't know how to do that. The settings have moved around a bit in the admin panel and I can no longer see a way of customising the editor. If you know how to customise the editor in Invision Community 5, let me know and I'll try applying it.

By Paint_Ninja · 14 hours ago14 hr

Astoxy

Sign In

Item not creating NBT Tags

Featured Replies

Join the conversation

Posts

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

New Forum Design/Update: Issues and Suggestions

New Forum Design/Update: Issues and Suggestions

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)