Posted May 23, 20232 yr The ItemCraftedEvent only fires when I shift-click the result in the crafting table. When I looked closer, the event is fired in ResultSlot.checkTakeAchievements, but not when you take the result without shift-click Is this intended? I'd like to append an NBT to the result if certain conditions are met, but it won't work like this.
May 23, 20232 yr ItemCraftedEvent is not meant to modify the item. It is just a notification telling you something happened. Forge lets you add an "nbt" element to the item result in the json file - it's not something I have personally ever used. https://github.com/MinecraftForge/MinecraftForge/blob/42115d37d6a46856e3dc914b54a1ce6d33b9872a/src/main/java/net/minecraftforge/common/crafting/CraftingHelper.java#L181 Or the way Mojang do it is to use a custom recipe and override assemble() e.g. see FireworkRocketRecipe https://forge.gemwire.uk/wiki/Custom_Recipes You can find many other threads about the latter in this forum. Boilerplate: If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one. If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install Large files should be posted to a file sharing site like https://gist.github.com You should also read the support forum sticky post.
May 23, 20232 yr Author thanks for the resources, I'll check them out asap. Question still kinda remains though, is this working as intended?
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.