PlayerEvent.ItemCraftedEvent only fires on quickcraft [1.19.2]

[TaeoG]

The ItemCraftedEvent only fires when I shift-click the result in the crafting table. When I looked closer, the event is fired in ResultSlot.checkTakeAchievements, but not when you take the result without shift-click

Is this intended? I'd like to append an NBT to the result if certain conditions are met, but it won't work like this.

[warjort]

ItemCraftedEvent is not meant to modify the item. It is just a notification telling you something happened.

 

Forge lets you add an "nbt" element to the item result in the json file - it's not something I have personally ever used.

https://github.com/MinecraftForge/MinecraftForge/blob/42115d37d6a46856e3dc914b54a1ce6d33b9872a/src/main/java/net/minecraftforge/common/crafting/CraftingHelper.java#L181

 

Or the way Mojang do it is to use a custom recipe and override assemble() e.g. see FireworkRocketRecipe

https://forge.gemwire.uk/wiki/Custom_Recipes

You can find many other threads about the latter in this forum.

[TaeoG]

thanks for the resources, I'll check them out asap.
Question still kinda remains though, is this working as intended?