Jump to content

Forge hooks for Structure loot.


Recommended Posts

I've looked at the Forge hooks for Dungeon loot, and would like something like it for the various other map generated loot chests. Yes there are a lot of them. Basically I want to add items from Forge mods to chests, which is easy without Forge until Bukkit is involved.


The idea I have is to modify StructureComponent.class so the StructurePieceTreasure[] part is removed/ignored, and a class parameter used instead to determine what set of loot to generate (eg ComponentStrongholdLibrary.class). This way when Mojang add yet another structure with chest loots in it, the API doesn't need yet more changes.


I don't mind doing most/all of the code changes, just want to hear what others think of the implementation. Also should I go with 1.2.5 or is it likely to be a wasted effort ?

Link to comment
Share on other sites

Dont make anything for 1.2.5 anymore. As as soon as major mods update, nobody will use 1.2.5 anymore

As for the the Structure loot, I have planned for a while to expand this to any world gen chest loot, but that is a future feature, we are currently in the 'fix bugs' stage of Forge, not the 'Add new things'

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

I've added a few lines of code to StructureComponent so it can determine its called class, eg: ComponentMineshaftCorridor.class and use that name to store each set of loot. This way any structure created gets its own unique loot set, even ones added by modders. Still need to write a data structure to store it all, then look at the pull request.


StructureComponent.class contains:


Loot chests





So I might at well tap into the Dispenser code, so mean people can put fire arrows in them or something.

Link to comment
Share on other sites

  • 5 weeks later...
  • 3 weeks later...

Got enchanted dungeon loot thanks to the recent changes in Forge (4.2.x)

Thanks for that LexManos!

I had to brush up on sub-classes and such to get it going but I'll put what I found here (if that's ok)


The override class:



package net.minecraft.src;

import net.minecraft.client.Minecraft;

import net.minecraftforge.common.DungeonHooks;

import net.minecraftforge.common.DungeonHooks.DungeonLoot;

import net.minecraft.src.EnchantmentHelper;

import net.minecraft.src.EnchantmentData;

import java.util.*;


public class enchantedLoot extends DungeonHooks.DungeonLoot


        private ItemStack itemStack;

        private int minCount = 1;

        private int maxCount = 1;

        private int minEnchantLevel = 1;

        private int maxEnchantLevel = 1;

        private int enchantChance = 0;


public enchantedLoot(ItemStack item, int weight, int min, int max, int ench)


super(weight, item, 1, 1);

this.itemStack = item;

minEnchantLevel = min;

maxEnchantLevel = max;

if (max < min)


maxEnchantLevel = min;


enchantChance = ench;


// Enchantable items should never be stackable

minCount = 1;

maxCount = 1;



public ItemStack generateStack(Random rand)


ItemStack ret = this.itemStack.copy();


ret.stackSize = minCount + (rand.nextInt(maxCount - minCount + 1));

if (enchantChance > 0)


int i = rand.nextInt(100);

if (i < enchantChance)


int level = minEnchantLevel + (rand.nextInt(maxEnchantLevel - minEnchantLevel + 1));

ret.stackSize = 1;

List list = EnchantmentHelper.buildEnchantmentList(rand, ret, level);

if(list != null)


EnchantmentData enchantmentdata;

for(Iterator iterator = list.iterator(); iterator.hasNext(); ret.addEnchantment(enchantmentdata.enchantmentobj, enchantmentdata.enchantmentLevel))


enchantmentdata = (EnchantmentData)iterator.next();





            return ret;






Then to reference it, add a method to your code:



private void addEnchantedLoot(ItemStack item, int weight, int min, int max, int ench)


DungeonHooks newLoot = new DungeonHooks();

newLoot.addDungeonLoot((DungeonHooks.DungeonLoot)new enchantedLoot(item, weight, min, max, ench));





Then if you want to add, for instance, randomly enchanted bows, you could use:

addEnchantedLoot(new ItemStack(Item.bow),100, 1,30, 10);

where 100 is the weight (chance it will be in loot)

1 is the minimum enchantment level

30 is the maximum enchantment level

10 is the percent chance the item will have any enchantment

Link to comment
Share on other sites

  • 3 months later...


Yeah yeah. Copy-paste heaven and structure sucks. It's been like 10 years since I had a college course in Java. I'll learn better coding skills if/when I get a full time job writing code.

The main reason for this reply is because with the deprication of DungeonHooks, this all changes. The only way I can think of doing the same thing now is to either add one of every possible enchantment of every possible tool/armor/weapon or to create some kind of new fake item which replaces itself with an enchanted item when created. Not even sure if that would work.

So with the current structure, is it still possible to add dungeon loot that will have a random enchantment applied when generated? If so, any hints?

Link to comment
Share on other sites

This topic is now closed to further replies.

  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm currently implementing an Oil Pump block. It's bigger than a regular block and is loaded with the wavefront (.obj) loader provied by Forge. I'm trying to add collision boxes to my block but some of my collision boxes are bigger than 16x16x16, and i can walk through them... Here's what I override to create my bounding boxes : @Override public VoxelShape getShape(BlockState state, BlockGetter world, BlockPos pos, CollisionContext context) { return switch (state.getValue(FACING)) { default -> Shapes.or(box(-5, 2, 17, 37, 53, 32), box(-5, 2, -13, 37, 53, 2), box(-12, 0, -20, 44, 4, 53), box(6, 1, 43, 26, 26, 62), box(9, 49, 2, 23, 53, 17)); case NORTH -> Shapes.or(box(-21, 2, -16, 21, 53, -1), box(-21, 2, 14, 21, 53, 29), box(-28, 0, -37, 28, 4, 36), box(-10, 1, -46, 10, 26, -27), box(-7, 49, -1, 7, 53, 14)); case EAST -> Shapes.or(box(17, 2, -21, 32, 53, 21), box(-13, 2, -21, 2, 53, 21), box(-20, 0, -28, 53, 4, 28), box(43, 1, -10, 62, 26, 10), box(2, 49, -7, 17, 53, 7)); case WEST -> Shapes.or(box(-16, 2, -5, -1, 53, 37), box(14, 2, -5, 29, 53, 37), box(-37, 0, -12, 36, 4, 44), box(-46, 1, 6, -27, 26, 26), box(-1, 49, 9, 14, 53, 23)); }; } My question is : Is there a way to bypass the collision box size limit on blocks ?
    • Your drivers are in a broken state, follow the guide in the FAQ: https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/#:~:text=How do I update my drivers%3F
    • Delete the forge-client.toml file in your config folder and test it again
    • Idk how this works can someone help   --- Minecraft Crash Report ---- // Uh... Did I do that?   Time: 2024-02-22 21:57:45 Description: Rendering overlay   net.minecraftforge.fml.config.ConfigFileTypeHandler$ConfigLoadingException: Failed loading config file forge-client.toml of type CLIENT for modid forge       at net.minecraftforge.fml.config.ConfigFileTypeHandler.lambda$reader$1(ConfigFileTypeHandler.java:47) ~[fmlcore-1.20.4-49.0.30.jar:?] {}       at net.minecraftforge.fml.config.ConfigTracker.openConfig(ConfigTracker.java:60) ~[fmlcore-1.20.4-49.0.30.jar:?] {}       at net.minecraftforge.fml.config.ConfigTracker.lambda$loadConfigs$1(ConfigTracker.java:50) ~[fmlcore-1.20.4-49.0.30.jar:?] {}       at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?] {}       at java.util.Collections$SynchronizedCollection.forEach(Collections.java:2131) ~[?:?] {}       at net.minecraftforge.fml.config.ConfigTracker.loadConfigs(ConfigTracker.java:50) ~[fmlcore-1.20.4-49.0.30.jar:?] {}       at net.minecraftforge.fml.core.ModStateProvider.lambda$new$1(ModStateProvider.java:67) ~[forge-1.20.4-49.0.30-universal.jar:?] {re:classloading}       at net.minecraftforge.fml.DistExecutor.unsafeRunWhenOn(DistExecutor.java:111) ~[fmlcore-1.20.4-49.0.30.jar:1.0] {}       at net.minecraftforge.fml.core.ModStateProvider.lambda$new$3(ModStateProvider.java:66) ~[forge-1.20.4-49.0.30-universal.jar:?] {re:classloading}       at net.minecraftforge.fml.ModLoader.handleInlineTransition(ModLoader.java:217) ~[fmlcore-1.20.4-49.0.30.jar!/:1.0] {}       at net.minecraftforge.fml.ModLoader.lambda$dispatchAndHandleError$19(ModLoader.java:209) ~[fmlcore-1.20.4-49.0.30.jar!/:1.0] {}       at java.util.Optional.ifPresent(Optional.java:178) ~[?:?] {}       at net.minecraftforge.fml.ModLoader.dispatchAndHandleError(ModLoader.java:209) ~[fmlcore-1.20.4-49.0.30.jar!/:1.0] {}       at net.minecraftforge.fml.ModLoader.lambda$loadMods$15(ModLoader.java:190) ~[fmlcore-1.20.4-49.0.30.jar!/:1.0] {}       at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?] {}       at net.minecraftforge.fml.ModLoader.loadMods(ModLoader.java:190) ~[fmlcore-1.20.4-49.0.30.jar!/:1.0] {}       at net.minecraftforge.client.loading.ClientModLoader.lambda$startModLoading$5(ClientModLoader.java:80) ~[forge-1.20.4-49.0.30-universal.jar!/:?] {re:classloading,pl:runtimedistcleaner:A}       at net.minecraftforge.client.loading.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:72) ~[forge-1.20.4-49.0.30-universal.jar!/:?] {re:classloading,pl:runtimedistcleaner:A}       at net.minecraftforge.client.loading.ClientModLoader.startModLoading(ClientModLoader.java:80) ~[forge-1.20.4-49.0.30-universal.jar!/:?] {re:classloading,pl:runtimedistcleaner:A}       at net.minecraftforge.client.loading.ClientModLoader.lambda$onResourceReload$2(ClientModLoader.java:63) ~[forge-1.20.4-49.0.30-universal.jar!/:?] {re:classloading,pl:runtimedistcleaner:A}       at net.minecraftforge.client.loading.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:72) ~[forge-1.20.4-49.0.30-universal.jar!/:?] {re:classloading,pl:runtimedistcleaner:A}       at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}       at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?] {}       at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}       at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}       at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {}       at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {}       at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {} Caused by: com.electronwill.nightconfig.core.io.ParsingException: Not enough data available       at com.electronwill.nightconfig.core.io.ParsingException.notEnoughData(ParsingException.java:22) ~[core-3.6.4.jar:?] {}       at com.electronwill.nightconfig.core.io.ReaderInput.directReadChar(ReaderInput.java:36) ~[core-3.6.4.jar:?] {}       at com.electronwill.nightconfig.core.io.AbstractInput.readChar(AbstractInput.java:49) ~[core-3.6.4.jar:?] {}       at com.electronwill.nightconfig.core.io.AbstractInput.readCharsUntil(AbstractInput.java:123) ~[core-3.6.4.jar:?] {}       at com.electronwill.nightconfig.toml.TableParser.parseKey(TableParser.java:166) ~[toml-3.6.4.jar:?] {}       at com.electronwill.nightconfig.toml.TableParser.parseDottedKey(TableParser.java:145) ~[toml-3.6.4.jar:?] {}       at com.electronwill.nightconfig.toml.TableParser.parseNormal(TableParser.java:55) ~[toml-3.6.4.jar:?] {}       at com.electronwill.nightconfig.toml.TomlParser.parse(TomlParser.java:44) ~[toml-3.6.4.jar:?] {}       at com.electronwill.nightconfig.toml.TomlParser.parse(TomlParser.java:37) ~[toml-3.6.4.jar:?] {}       at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:113) ~[core-3.6.4.jar:?] {}       at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:219) ~[core-3.6.4.jar:?] {}       at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:202) ~[core-3.6.4.jar:?] {}       at com.electronwill.nightconfig.core.file.WriteSyncFileConfig.load(WriteSyncFileConfig.java:73) ~[core-3.6.4.jar:?] {}       at com.electronwill.nightconfig.core.file.AutosaveCommentedFileConfig.load(AutosaveCommentedFileConfig.java:85) ~[core-3.6.4.jar:?] {}       at net.minecraftforge.fml.config.ConfigFileTypeHandler.lambda$reader$1(ConfigFileTypeHandler.java:43) ~[fmlcore-1.20.4-49.0.30.jar:?] {}       ... 27 more     A detailed walkthrough of the error, its code path and all known details is as follows: ---------------------------------------------------------------------------------------   -- Head -- Thread: Render thread Suspected Mods: NONE Stacktrace:       at net.minecraftforge.fml.config.ConfigFileTypeHandler.lambda$reader$1(ConfigFileTypeHandler.java:47) ~[fmlcore-1.20.4-49.0.30.jar!/:?] {}       at net.minecraftforge.fml.config.ConfigTracker.openConfig(ConfigTracker.java:60) ~[fmlcore-1.20.4-49.0.30.jar!/:?] {}       at net.minecraftforge.fml.config.ConfigTracker.lambda$loadConfigs$1(ConfigTracker.java:50) ~[fmlcore-1.20.4-49.0.30.jar!/:?] {}       at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?] {}       at java.util.Collections$SynchronizedCollection.forEach(Collections.java:2131) ~[?:?] {}       at net.minecraftforge.fml.config.ConfigTracker.loadConfigs(ConfigTracker.java:50) ~[fmlcore-1.20.4-49.0.30.jar!/:?] {} -- Overlay render details -- Details:       Overlay name: net.minecraftforge.client.loading.ForgeLoadingOverlay Stacktrace:       at net.minecraft.client.renderer.GameRenderer.m_109093_(GameRenderer.java:934) ~[forge-1.20.4-49.0.30-client.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}       at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1250) ~[forge-1.20.4-49.0.30-client.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}       at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:801) ~[forge-1.20.4-49.0.30-client.jar:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}       at net.minecraft.client.main.Main.main(Main.java:234) ~[forge-1.20.4-49.0.30-client.jar:?] {re:classloading,pl:runtimedistcleaner:A}       at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}       at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}       at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}       at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}       at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:91) ~[fmlloader-1.20.4-49.0.30.jar:?] {}       at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.lambda$makeService$0(CommonLaunchHandler.java:75) ~[fmlloader-1.20.4-49.0.30.jar:?] {}       at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) ~[modlauncher-10.1.2.jar:?] {}       at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:74) ~[modlauncher-10.1.2.jar:?] {}       at cpw.mods.modlauncher.Launcher.run(Launcher.java:114) ~[modlauncher-10.1.2.jar:?] {}       at cpw.mods.modlauncher.Launcher.main(Launcher.java:73) ~[modlauncher-10.1.2.jar:?] {}       at cpw.mods.modlauncher.BootstrapEntry.main(BootstrapEntry.java:17) ~[modlauncher-10.1.2.jar:?] {}       at net.minecraftforge.bootstrap.Bootstrap.moduleMain(Bootstrap.java:97) ~[bootstrap-2.0.0.jar!/:?] {}       at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}       at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}       at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}       at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}       at net.minecraftforge.bootstrap.Bootstrap.start(Bootstrap.java:48) ~[bootstrap-2.0.0.jar!/:?] {}       at net.minecraftforge.bootstrap.ForgeBootstrap.main(ForgeBootstrap.java:18) ~[bootstrap-2.0.0.jar!/:?] {}     -- Uptime -- Details:       JVM uptime: 15.952s       Wall uptime: 2.599s       High-res time: 9.256s       Client ticks: 10 ticks / 0.500s   -- Last reload -- Details:       Reload number: 1       Reload reason: initial       Finished: No       Packs: vanilla, mod_resources   -- System Details -- Details:       Minecraft Version: 1.20.4       Minecraft Version ID: 1.20.4       Operating System: Windows 11 (amd64) version 10.0       Java Version: 17.0.8, Microsoft       Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft       Memory: 210563768 bytes (200 MiB) / 469762048 bytes (448 MiB) up to 2147483648 bytes (2048 MiB)       CPUs: 16       Processor Vendor: GenuineIntel       Processor Name: 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz       Identifier: Intel64 Family 6 Model 141 Stepping 1       Microarchitecture: unknown       Frequency (GHz): 2.30       Number of physical packages: 1       Number of physical CPUs: 8       Number of logical CPUs: 16       Graphics card #0 name: Intel(R) UHD Graphics       Graphics card #0 vendor: Intel Corporation (0x8086)       Graphics card #0 VRAM (MB): 1024.00       Graphics card #0 deviceId: 0x9a60       Graphics card #0 versionInfo: DriverVersion=       Graphics card #1 name: NVIDIA GeForce RTX 3060 Laptop GPU       Graphics card #1 vendor: NVIDIA (0x10de)       Graphics card #1 VRAM (MB): 4095.00       Graphics card #1 deviceId: 0x2560       Graphics card #1 versionInfo: DriverVersion=       Memory slot #0 capacity (MB): 8192.00       Memory slot #0 clockSpeed (GHz): 3.20       Memory slot #0 type: DDR4       Memory slot #1 capacity (MB): 8192.00       Memory slot #1 clockSpeed (GHz): 3.20       Memory slot #1 type: DDR4       Virtual memory max (MB): 27943.30       Virtual memory used (MB): 14154.98       Swap memory total (MB): 11776.00       Swap memory used (MB): 90.13       JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M       Launched Version: 1.20.4-forge-49.0.30       Launcher name: minecraft-launcher       Backend library: LWJGL version 3.3.2+13       Backend API: Intel(R) UHD Graphics GL version 4.6.0 - Build, Intel       Window size: 854x480       GL Caps: Using framebuffer using OpenGL 3.2       GL debug messages:       Using VBOs: Yes       Is Modded: Definitely; Client brand changed to 'forge'       Universe: 400921fb54442d18       Type: Client (map_client.txt)       Graphics mode: fast       Render Distance: 12/12 chunks       Resource Packs:       Current Language: en_us       Locale: en_US       CPU: 16x 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz       ModLauncher: 10.1.2       ModLauncher launch target: forge_client       ModLauncher naming: srg       ModLauncher services:             / slf4jfixer PLUGINSERVICE             / runtimedistcleaner PLUGINSERVICE             / runtime_enum_extender PLUGINSERVICE             / object_holder_definalize PLUGINSERVICE             / capability_token_subclass PLUGINSERVICE             / accesstransformer PLUGINSERVICE             / eventbus PLUGINSERVICE             / mixin PLUGINSERVICE             / fml TRANSFORMATIONSERVICE             / mixin TRANSFORMATIONSERVICE       FML Language Providers:             minecraft@1.0             lowcodefml@49             javafml@49.0.30       Mod List:             forge-1.20.4-49.0.30-client.jar                   |Minecraft                     |minecraft                     |1.20.4              |COMMON_SET|Manifest: NOSIGNATURE             forge-1.20.4-49.0.30-universal.jar                |Forge                         |forge                         |49.0.30             |COMMON_SET|Manifest: NOSIGNATURE       Crash Report UUID: 5380853b-d030-466a-8c5e-5c81ce00053c       FML: 0.0       Forge: net.minecraftforge:49.0.30
    • I am new at modding and i am in forge My question was how do i modify an already existing block property, like for blocks that you create its easy: public static final RegistryObject<Block> BURNEDWOOD = registerBlock("burnedwood", () -> new Block(BlockBehaviour.Properties.of().blablablabla)); but what do I put in for just vanilla blocks(I want to change the oak log to take more time to cut down, but idk how to access the properties of said block)
  • Topics

  • Create New...

Important Information

By using this site, you agree to our Terms of Use.