Dropping double the items than supposed to?

[TLHPoE]

I'm adding in an accessory system, but I have no clue what to do when the player dies. So I made a PlayerTickHandler class and made it check if the player was dead and if the world was not remote.

 

Everything works fine, except for the amount of items it drops. If I put in 2 blocks of wool into 2 slots, and I die, it drops 4 blocks of wool. It's like it just multiplies the amount of items I have and drops it.

 

Here's a snippet of my code:

 

	if(player.isDead && !player.worldObj.isRemote)
	{

		NBTTagCompound playerNBT = player.getEntityData();

		if(playerNBT != null)
		{

			NBTTagList nbtTag = playerNBT.getTagList("Accessories");

			for(int i = 0;i < nbtTag.tagCount();i++)
			{

				NBTTagCompound nbt = (NBTTagCompound)nbtTag.tagAt(i);

				byte slot = nbt.getByte("Slot");

				if(slot >= 0 && slot < 7);
				{

					player.dropPlayerItem(ItemStack.loadItemStackFromNBT(nbt));

				}

			}

		}

	}

[Draco18s]

Player dies -> Items automagically dropped.

[MineMaarten]

Not if he adds custom inventory, like he suggests he's doing.

 

Could it be that you're saving the data twice somewhere? You're checking for slots, but it would allow to drop two ItemStacks with the same slot number.

[Draco18s]

It's still a thought worth checking: disable the tick handler and see what happens.

[coolAlias]

Is it possible your TickHandler is being called on more than just one type of tick? For instance, both SERVER and PLAYER? According to Forge documentation, PLAYER ticks occur on both the client and the server, which would explain why it's called twice (once on the server tick and once on the player server-side tick).

[Conraad]

Add world.isRemote to your check and your problems of double dropping should be gone.