[Solved] 1.19.4 Access Transformer not transforming

[WalkerCase]

Hello,

I am attempting to change the modifier of a class from MrCrayfish gun mod with AT. I have observed that the AT file is loaded however it doesn't appear to be applying the transform. I am trying to set com.mrcrayfish.guns.client.screen.WorkbenchScreen$Tab to public however intellij is showing ''com.mrcrayfish.guns.client.screen.WorkbenchScreen.Tab' has private access in 'com.mrcrayfish.guns.client.screen.WorkbenchScreen''.

 

Any help would be greatly appreciated.

 

resources/META-INF/accesstransformer.cfg

public com.mrcrayfish.guns.client.screen.WorkbenchScreen$Tab

 

build.gradle

plugins {
    id 'eclipse'
    id 'maven-publish'
    id 'net.minecraftforge.gradle' version '5.1.+'
    id 'org.spongepowered.mixin' version '0.7.+'
}

version = '1.0.1'
group = 'com.cyphereion.ae' // http://maven.apache.org/guides/mini/guide-naming-conventions.html
archivesBaseName = 'ae'

// Mojang ships Java 17 to end users in 1.18+, so your mod should target Java 17.
java.toolchain.languageVersion = JavaLanguageVersion.of(17)

mixin {
    add sourceSets.main, "ae.refmap.json"
    config 'ae.mixins.json'
}

println "Java: ${System.getProperty 'java.version'}, JVM: ${System.getProperty 'java.vm.version'} (${System.getProperty 'java.vendor'}), Arch: ${System.getProperty 'os.arch'}"
minecraft {
    // The mappings can be changed at any time and must be in the following format.
    // Channel:   Version:
    // official   MCVersion             Official field/method names from Mojang mapping files
    // parchment  YYYY.MM.DD-MCVersion  Open community-sourced parameter names and javadocs layered on top of official
    //
    // You must be aware of the Mojang license when using the 'official' or 'parchment' mappings.
    // See more information here: https://github.com/MinecraftForge/MCPConfig/blob/master/Mojang.md
    //
    // Parchment is an unofficial project maintained by ParchmentMC, separate from MinecraftForge
    // Additional setup is needed to use their mappings: https://parchmentmc.org/docs/getting-started
    //
    // Use non-default mappings at your own risk. They may not always work.
    // Simply re-run your setup task after changing the mappings to update your workspace.
    mappings channel: 'official', version: '1.19.4'

    accessTransformer = file('src/main/resources/META-INF/accesstransformer.cfg') // Currently, this location cannot be changed from the default.

    // Default run configurations.
    // These can be tweaked, removed, or duplicated as needed.
    runs {
        client {
            workingDirectory project.file('run')

            // Recommended logging data for a userdev environment
            // The markers can be added/remove as needed separated by commas.
            // "SCAN": For mods scan.
            // "REGISTRIES": For firing of registry events.
            // "REGISTRYDUMP": For getting the contents of all registries.
            property 'forge.logging.markers', 'REGISTRIES'

            // Recommended logging level for the console
            // You can set various levels here.
            // Please read: https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels
            property 'forge.logging.console.level', 'debug'

            // Comma-separated list of namespaces to load gametests from. Empty = all namespaces.
            property 'forge.enabledGameTestNamespaces', 'ae'

            property 'mixin.env.remapRefMap', 'true'
            property 'mixin.env.refMapRemappingFile', "${projectDir}/build/createSrgToMcp/output.srg"

            mods {
                ae {
                    source sourceSets.main
                    ext.refMap = "ae.refmap.json"
                }
            }
        }

        server {
            workingDirectory project.file('run')

            property 'forge.logging.markers', 'REGISTRIES'

            property 'forge.logging.console.level', 'debug'

            property 'forge.enabledGameTestNamespaces', 'ae'

            property 'mixin.env.remapRefMap', 'true'
            property 'mixin.env.refMapRemappingFile', "${projectDir}/build/createSrgToMcp/output.srg"

            arg '-mixin.config=ae.mixins.json'
            mods {
                ae {
                    source sourceSets.main
                    ext.refMap = "ae.refmap.json"
                }
            }
        }

        // This run config launches GameTestServer and runs all registered gametests, then exits.
        // By default, the server will crash when no gametests are provided.
        // The gametest system is also enabled by default for other run configs under the /test command.
        gameTestServer {
            workingDirectory project.file('run')

            property 'forge.logging.markers', 'REGISTRIES'

            property 'forge.logging.console.level', 'debug'

            property 'forge.enabledGameTestNamespaces', 'ae'

            mods {
                ae {
                    source sourceSets.main
                    ext.refMap = "ae.refmap.json"
                    ext.refMap = "ae.refmap.json"
                }
            }
        }

        data {
            workingDirectory project.file('run')

            property 'forge.logging.markers', 'REGISTRIES'

            property 'forge.logging.console.level', 'debug'

            // Specify the modid for data generation, where to output the resulting resource, and where to look for existing resources.
            args '--mod', 'ae', '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/')

            arg '-mixin.config=ae.mixins.json'
            mods {
                ae {
                    source sourceSets.main
                    ext.refMap = "ae.refmap.json"
                }
            }
        }
    }
}

// Include resources generated by data generators.
sourceSets.main.resources { srcDir 'src/generated/resources' }

repositories {
    // Put repositories for dependencies here
    // ForgeGradle automatically adds the Forge maven and Maven Central for you

    // If you have mod jar dependencies in ./libs, you can declare them as a repository like so:
     //flatDir {
     //    dir 'libs'
     //}
    maven {
        url "https://www.cursemaven.com"
    }
}

dependencies {
    // Specify the version of Minecraft to use. If this is any group other than 'net.minecraft', it is assumed
    // that the dep is a ForgeGradle 'patcher' dependency, and its patches will be applied.
    // The userdev artifact is a special name and will get all sorts of transformations applied to it.
    minecraft 'net.minecraftforge:forge:1.19.4-45.1.0'

    annotationProcessor 'org.spongepowered:mixin:0.8.5:processor'
    // Real mod deobf dependency examples - these get remapped to your current mappings
    // implementation fg.deobf("com.tterrag.registrate:Registrate:MC${mc_version}-${registrate_version}") // Adds registrate as a dependency

    // Examples using mod jars from ./li
    // 9*6                                                                        bs
    // implementation fg.deobf("blank:coolmod-${mc_version}:${coolmod_version}")
    implementation fg.deobf('curse.maven:framework-549225:4718249')
    implementation fg.deobf('curse.maven:mrcrayfishs-gun-mod-289479:4718584')

    // For more info...
    // http://www.gradle.org/docs/current/userguide/artifact_dependencies_tutorial.html
    // http://www.gradle.org/docs/current/userguide/dependency_management.html
}

// Example for how to get properties into the manifest for reading at runtime.
jar {
    manifest {
        attributes([
                "Specification-Title"     : "Ammo Extensions",
                "Specification-Vendor"    : "ae",
                "Specification-Version"   : "1", // We are version 1 of ourselves
                "Implementation-Title"    : project.name,
                "Implementation-Version"  : project.jar.archiveVersion,
                "Implementation-Vendor"   : "ae",
                "Implementation-Timestamp": new Date().format("yyyy-MM-dd'T'HH:mm:ssZ"),
                'TweakClass': 'org.spongepowered.asm.launch.MixinTweaker',
                "MixinConfigs": "ae.mixins.json",
                'FMLCorePluginContainsFMLMod': 'true',
        ])
    }
}

// Example configuration to allow publishing using the maven-publish plugin
// This is the preferred method to reobfuscate your jar file
jar.finalizedBy('reobfJar')
// However if you are in a multi-project build, dev time needs unobfed jar files, so you can delay the obfuscation until publishing by doing
// publish.dependsOn('reobfJar')

publishing {
    publications {
        mavenJava(MavenPublication) {
            artifact jar
        }
    }
    repositories {
        maven {
            url "file://${project.projectDir}/mcmodsrepo"
        }
    }
}

tasks.withType(JavaCompile).configureEach {
    options.encoding = 'UTF-8' // Use the UTF-8 charset for Java compilation
}

 

Edited November 1, 2023 by WalkerCase
Mark solved.

[Luis_ST]

Why do you need to use an AT to another mod?

Have you reloaded the gradle project?

[WalkerCase]

I have refreshed the gradle project (Intellij command reload all gradle projects). I need to access a nested class that has a private modifier in order to instantiate a new object from it to add it to an array.

More specifically I am adding another tab to the workbench.

Edited November 1, 2023 by WalkerCase
clarification

[Luis_ST]

First of all it is highly recommended to not use an AT into another Mod.

Second, I tried this in my mod and it looks like only Minecraft classes can be edited via AT.
You can take a look at the generated accesstransform.log somewhere to check which AT's have be performed.
The log is located somewhere in your build folder, use the search tool of your explorer to find it.

I would recommend you to talk to the mod author and suggest your changes or create a pull request on GitHub that will make these changes.

Edited November 1, 2023 by Luis_ST

[WalkerCase]

I did check the logs, it just wasn't being applied but if it only works on base Minecraft classes that would make sense. I appreciate the help!