Keymappings don't appear in key binds menu [1.20.1, forge 47.1.30]

[SermisterOne]

Tried creating keymappings, but only mouse button one works, and both don't appear in mey binds menu

So here's the code:

@Mod(ExampleMod.MODID)
public class ExampleMod
{
	
	static KeyMapping y = new KeyMapping(
			  "key.categories.misc1", // Will be localized using this translation key
			  InputConstants.Type.KEYSYM, // Default mapping is on the keyboard
			  GLFW.GLFW_KEY_Y, // Default key is P
			  "key.categories.misc" // Mapping will be in the misc category
			);
	/*static KeyMapping mb5 = new KeyMapping(
			  "key.categories.misc1", // Will be localized using this translation key
			  InputConstants.Type.MOUSE, // Default mapping is on the keyboard
			  GLFW.GLFW_MOUSE_BUTTON_5, // Default key is P
			  "key.categories.misc" // Mapping will be in the misc category
			);*/
	
	
	public static final Lazy<KeyMapping> EXAMPLE_MAPPING = Lazy.of(() -> new KeyMapping(
			  "key.categories.misc1", // Will be localized using this translation key
			  InputConstants.Type.MOUSE, // Default mapping is on the keyboard
			  GLFW.GLFW_MOUSE_BUTTON_5, // Default key is P
			  "key.categories.misc" // Mapping will be in the misc category
			)/*...*/);
	
	public static int toggle = 0;
    // Define mod id in a common place for everything to reference
    public static final String MODID = "examplemod";
  
  public ExampleMod()
    {
        IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();
        modEventBus.addListener(this::commonSetup);
        MinecraftForge.EVENT_BUS.register(this);
        ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, Config.SPEC);
    }
  
   @SubscribeEvent
    public void onClientTick(ClientTickEvent event) {
    	  if (event.phase == TickEvent.Phase.END) { // Only call code once as the tick event is called twice every tick
    	    while (y.consumeClick()) {
    	      // Execute logic to perform on click here
    	    	if(toggle == 0) {
    	    		Minecraft.getInstance().player.connection.sendCommand("gamemode spectator");
    	    		toggle = 1;
    	    	} else if(toggle == 1) {
    	    		Minecraft.getInstance().player.connection.sendCommand("gamemode creative");
    	    		toggle = 0;
    	    	}
    	    }
    	    while(EXAMPLE_MAPPING.get().consumeClick()) {
    	    	Minecraft.getInstance().player.connection.sendCommand(Config.command); // Here I get command from config, can be any string
    	    }
    	  }
    	}
  
  @Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT)
    public static class ClientModEvents
    {
    	@SubscribeEvent
        public void registerBindings(RegisterKeyMappingsEvent event) {
    		event.register(y);
    		event.register(EXAMPLE_MAPPING.get()); // tried both lazy and static keymapping
        }
        @SubscribeEvent
        public static void onClientSetup(FMLClientSetupEvent event)
        {
          
        }
        
        
    }
    @Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.FORGE, value = Dist.CLIENT)
    public static class ClientForgeEvents
    {
    	@SubscribeEvent
        public static void registerCommands(RegisterClientCommandsEvent event){
        	register(event.getDispatcher()); // I register my command here
        }
    }
}

What am I doing wrong there?

Sorry if I posted it in the wrong section, I am new to forge forums

Edited November 4, 2023 by SermisterOne

[FinnT730]

Moved

[Luis_ST]

Both KeyMappings you have created use the same name, also try to include the mod name.

Have you tried to create a custom category?

[SermisterOne]

  On 11/6/2023 at 1:10 PM, Luis_ST said:

Both KeyMappings you have created use the same name, also try to include the mod name.

Have you tried to create a custom category?

Expand  

Is custom category specified in just keybind declaration? Does it need to be defined somewhere else?

Only thing that changed after changing keybinds name to different strings is that Y one started working, they are still missing in key binds menu

Edited November 6, 2023 by SermisterOne

[Luis_ST]

If i remember correctly the category is just a translation key, you must not register the category somewhere else

[SermisterOne]

  On 11/6/2023 at 2:44 PM, Luis_ST said:

If i remember correctly the category is just a translation key, you must not register the category somewhere else

Expand  

Also, do I need to create translation files? Or just basic category/key bind names will work too? 

[Luis_ST]

  On 11/6/2023 at 3:07 PM, SermisterOne said:

Also, do I need to create translation files?

Expand  

It is recommended to use translation files, but if Vanilla does not find a translation for the specified key, the raw text will be displayed

[SermisterOne]

  On 11/6/2023 at 8:06 PM, Luis_ST said:

It is recommended to use translation files, but if Vanilla does not find a translation for the specified key, the raw text will be displayed

Expand  

Maybe I'm registering them in wrong event? What about "@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.FORGE(or MOD), value = Dist.CLIENT)" part?

[SermisterOne]

Aint no way I'm that stupid

@SubscribeEvent
public void registerBindings(RegisterKeyMappingsEvent event) {
event.register(y);
event.register(EXAMPLE_MAPPING.get()); // tried both lazy and static keymapping
}

this should be

@SubscribeEvent
public static void registerBindings(RegisterKeyMappingsEvent event) {
event.register(y);
event.register(EXAMPLE_MAPPING.get()); // tried both lazy and static keymapping
}

lmao

Edited November 7, 2023 by SermisterOne

[SermisterOne]

Why the hell do forge docs contain this

@SubscribeEvent
public void registerBindings(RegisterKeyMappingsEvent event) {
  event.register(EXAMPLE_MAPPING.get());
}

and not this

@SubscribeEvent
public static void registerBindings(RegisterKeyMappingsEvent event) {
  event.register(EXAMPLE_MAPPING.get());
}

https://docs.minecraftforge.net/en/1.20.x/misc/keymappings/

[Luis_ST]

There are many differnt ways to register an EventHandler:

I know that the documents are outdated and do not contain all the necessary information, I am already working on it.