Jump to content

Recommended Posts

Posted

Hello,

I have basic understanding of the Forge API now.

What I am trying to do is to have a GUI drawn at the top right of the screen when the player has a special helmet.

The problem is that I cannot figure out the event that is triggered when the player changes his helmet, and also check if the player has that helmet when it joins the world to draw that gui. Any help is appreciated!

 

~Momo.

Posted

There's no event for that. However you can poll if the player has a certain helmet every tick. when you have the player you can do EntityPlayer#getCurrentArmor(3) to get the currently worn helmet. To do things every tick implement ITickHandler, listen for Render ticks, and don't forget to register it. Now you can draw 2D objects every time you tick and have a certain helmet on.

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

Here's your answer:

http://www.minecraftforge.net/forum/index.php/topic,13504.msg69629.html#msg69629

You add checks in there so you only render stuff when the player has a certain helmet on. 

 

If you really want to do it clean and don't want to use too much computing resources of the rendering you can also listen for player ticks and only check in there if the helmet's on. However I don't think checking for a inventory item is that resource intensive.

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

That wasn't that necessary for now, I only mentioned it for completeness. But if you want to listen for Player ticks as well you can do this in your implementation of ITickHandler:

 @Override
    public EnumSet<TickType> ticks(){
        return EnumSet.of(TickType.RENDER, TickType.PLAYER);
    }

Because you only register it for the client you'll only get client sided player ticks (which is great).

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

Thanks a lot for your patience.

I have this code now in my TickHandler class:

@SideOnly(Side.CLIENT)
public class TickHandler implements ITickHandler{

@Override
public void tickStart(EnumSet<TickType> type, Object... tickData) {

}

@Override
public void tickEnd(EnumSet<TickType> type, Object... tickData) {

	 if(type.contains(TickType.PLAYER)) {
		 if (Variables.status == 0){
			 FMLClientHandler.instance().getClient().fontRenderer.drawStringWithShadow("POTATO", 2, 2, 16777215);
             Variables.status = 1;
		 }
             
	 }
}

@Override
public EnumSet<TickType> ticks() {

	return EnumSet.of(TickType.PLAYER);
}

@Override
public String getLabel() {
	// TODO Auto-generated method stub
	return null;
}

}

 

I used the String POTATO as a test. When I join, I see the string, but it disappears on the next tick. How to let it stay there?

Also, what method do you suggest for detecting the Helmet. Creating a Minecraft instance?

Posted

You're rendering things. You need to do this every render tick. Thinking about this I can see two things:

1. You're listening for player ticks instead of render ticks. These are only ticked 20 times a second instead of FPS times (>20 times usually).

2. You're only calling the render method once. You need to draw POTATO every render tick. So no need for a variable to keep up if you already have rendered.

 

Also, what method do you suggest for detecting the Helmet. Creating a Minecraft instance?

Not creating a Minecraft instance! Getting the Minecraft instance (that's probably what you meant). This is only possible because you're working on the client side off course. So to get the player you can do FMLClientHandler.instance().getClient().thePlayer and go on from there to retrieve its helmet stack.

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

		 if (Variables.status == 0){
			 FMLClientHandler.instance().getClient().fontRenderer.drawStringWithShadow("POTATO", 2, 2, 16777215);
                         Variables.status = 1;
		 }

 

You are setting status to 1 after first display, so it does not pass the IF clause next time.

Posted

New code (tickEnd):

public void tickEnd(EnumSet<TickType> type, Object... tickData) {

	 if(type.contains(TickType.RENDER)) {

		 if (Variables.status == 0){
			 FMLClientHandler.instance().getClient().fontRenderer.drawStringWithShadow("POTATO", 2, 2, 16777215);
             

		 }
             
	 }
}

Now it also displays on the Main Menu!  :P How to check if it is ingame?

Posted

You'll automatically solve this when you check for the player wearing the helmet, because there's only a player object when you're in the world. So when player != null results in true you're in the world. Check out https://github.com/MineMaarten/Worms-Mod/blob/master/src/wormsmod/client/render/ProjectileChargeRenderer.java for an example ;). Minecraft#inGameHasFocus() returns true when you're not in the pause screen or other gui which is also a helpful method.

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

The tickEnd:

@Override
public void tickEnd(EnumSet<TickType> type, Object... tickData) {

	 if(type.contains(TickType.RENDER)) {
		 if (FMLClientHandler.instance().getClient().thePlayer != null){

			 if (FMLClientHandler.instance().getClient().thePlayer.getCurrentArmor(0)==GoogleGlassesMod.GoogleGlassStack){
				 FMLClientHandler.instance().getClient().fontRenderer.drawStringWithShadow("POTATO", 2, 2, 16777215);
			 }

		 }

             
	 }
}

And the GoogleGlassStack:

ublic static ItemStack GoogleGlassStack = new ItemStack(GoogleGlassHelmet);

I think I am doing it wrong at the GoogleGlassStack. Help?

Posted

Two things:

1. EntityPlayer#getCurrentArmor(0) returns the boots armor slot. You need EntityPlayer#getCurrentArmor(3).

2. Basic Java ;). With '==' you're checking if the checked objects are the same. This never is the case. You need to do:

ItemStack helmetStack = FMLClientHandler.instance().getClient().thePlayer.getCurrentArmor(3); //just a new variable because the if statement is getting long otherwise
if(helmetStack != null && helmetStack.itemID == GoogleGlassesMod.GoogleGlassStack.itemID){
    //render
}

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

OMG OMG THANK YOU!!!!

Final code (working):

@Override
public void tickEnd(EnumSet<TickType> type, Object... tickData) {

	 if(type.contains(TickType.RENDER)) {
		 if (FMLClientHandler.instance().getClient().thePlayer != null){
			 ItemStack helmetStack = FMLClientHandler.instance().getClient().thePlayer.getCurrentArmor(3);
			 if(helmetStack != null && helmetStack.itemID == GoogleGlassesMod.GoogleGlassHelmet.itemID){
				 FMLClientHandler.instance().getClient().fontRenderer.drawStringWithShadow("POTATO", 2, 2, 16777215); 
			 }




		 }




             
	 }
}

Posted

Lol! I was reinventing the wheel apparently...

 

None the less, it was a valuable thing to do (in case he wants to do other kinds of gui effects!)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i managed to fix it by reinstalling the modpack and re-add all the extra mods I've had previously.
    • Ah, it appears I spoke too soon, I still need a little help here. I now have the forceloading working reliably.  However, I've realized it's not always the first tick that loads the entity.  I've seen it take anywhere from 2-20ish to actually go through, in which time my debugging has revealed that the chunk is loaded, but during which time calling  serverLevelIn.getEntity(uuidIn) returns a null result.  I suspect this has to do with queuing and how entities are loaded into the game.  While not optimal, it's acceptable, and I don't think there's a whole ton I can do to avoid it. However, my concern is that occasionally teleporting an entity in this manner causes a lag spike.  It's not every time and gives the appearance of being correlated with when other chunks are loading in.  It's also not typically a long spike, but can last a second or two, which is less than ideal.  The gist of how I'm summoning is here (although I've omitted some parts that weren't relevant.  The lag occurs before the actual summon so I'm pretty confident it's the loading, and not the actual summon call). ChunkPos chunkPos = new ChunkPos(entityPosIn); if (serverLevelIn.areEntitiesLoaded(chunkPos.toLong())) { boolean isSummoned = // The method I'm using for actual summoning is called here. Apart from a few checks, the bulk of it is shown later on. if (isSummoned) { // Code that runs here just notifies the player of the summon, clears it from the queue, and removes the forceload } } else { // I continue forcing the chunk until the summon succeeds, to make sure it isn't inadvertently cleared ForgeChunkManager.forceChunk(serverLevelIn, MODID, summonPosIn, chunkPos.x, chunkPos.z, true, true); } The summon code itself uses serverLevelIn.getEntity(uuidIn) to retrieve the entity, and moves it as such.  It is then moved thusly: if (entity.isAlive()) { entity.moveTo(posIn.getX(), posIn.getY(), posIn.getZ()); serverLevelIn.playSound(null, entity, SoundEvents.ENDERMAN_TELEPORT, SoundSource.NEUTRAL, 1.0F, 1.0F); return true; } I originally was calling .getEntity() more frequently and didn't have the check for whether or not entities were loaded in place to prevent unnecessary code calls, but even with those safety measures in place, the lag still persists.  Could this just be an issue with 1.18's lack of optimization in certain areas?  Is there anything I can do to mitigate it?  Is there a performance boosting mod I could recommend alongside my own to reduce the chunk loading lag? At the end of the day, it does work, and I'm putting measures in place to prevent players from abusing the system to cause lag (i.e. each player can only have one queued summon at a time-- trying to summon another replaces the first call).  It's also not an unacceptable level of lag, IMO, given the infrequency of such calls, and the fact that I'm providing the option to toggle off the feature if server admins don't want it used.  However, no amount of lag is ideal, so if possible I'd love to find a more elegant solution-- or at least a mod recommendation to help improve it. Thanks!
    • When i start my forge server its on but when i try to join its come a error Internal Exception: java.lang.OutOfMemoryError: Requested array size exceeds VM limit Server infos: Linux Minecraft version 1.20.1 -Xmx11G -Xms8G
    • Also add the latest.log from your logs-folder
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.