Jump to content

Recommended Posts

Posted

Hello,

I have basic understanding of the Forge API now.

What I am trying to do is to have a GUI drawn at the top right of the screen when the player has a special helmet.

The problem is that I cannot figure out the event that is triggered when the player changes his helmet, and also check if the player has that helmet when it joins the world to draw that gui. Any help is appreciated!

 

~Momo.

Posted

There's no event for that. However you can poll if the player has a certain helmet every tick. when you have the player you can do EntityPlayer#getCurrentArmor(3) to get the currently worn helmet. To do things every tick implement ITickHandler, listen for Render ticks, and don't forget to register it. Now you can draw 2D objects every time you tick and have a certain helmet on.

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

Here's your answer:

http://www.minecraftforge.net/forum/index.php/topic,13504.msg69629.html#msg69629

You add checks in there so you only render stuff when the player has a certain helmet on. 

 

If you really want to do it clean and don't want to use too much computing resources of the rendering you can also listen for player ticks and only check in there if the helmet's on. However I don't think checking for a inventory item is that resource intensive.

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

That wasn't that necessary for now, I only mentioned it for completeness. But if you want to listen for Player ticks as well you can do this in your implementation of ITickHandler:

 @Override
    public EnumSet<TickType> ticks(){
        return EnumSet.of(TickType.RENDER, TickType.PLAYER);
    }

Because you only register it for the client you'll only get client sided player ticks (which is great).

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

Thanks a lot for your patience.

I have this code now in my TickHandler class:

@SideOnly(Side.CLIENT)
public class TickHandler implements ITickHandler{

@Override
public void tickStart(EnumSet<TickType> type, Object... tickData) {

}

@Override
public void tickEnd(EnumSet<TickType> type, Object... tickData) {

	 if(type.contains(TickType.PLAYER)) {
		 if (Variables.status == 0){
			 FMLClientHandler.instance().getClient().fontRenderer.drawStringWithShadow("POTATO", 2, 2, 16777215);
             Variables.status = 1;
		 }
             
	 }
}

@Override
public EnumSet<TickType> ticks() {

	return EnumSet.of(TickType.PLAYER);
}

@Override
public String getLabel() {
	// TODO Auto-generated method stub
	return null;
}

}

 

I used the String POTATO as a test. When I join, I see the string, but it disappears on the next tick. How to let it stay there?

Also, what method do you suggest for detecting the Helmet. Creating a Minecraft instance?

Posted

You're rendering things. You need to do this every render tick. Thinking about this I can see two things:

1. You're listening for player ticks instead of render ticks. These are only ticked 20 times a second instead of FPS times (>20 times usually).

2. You're only calling the render method once. You need to draw POTATO every render tick. So no need for a variable to keep up if you already have rendered.

 

Also, what method do you suggest for detecting the Helmet. Creating a Minecraft instance?

Not creating a Minecraft instance! Getting the Minecraft instance (that's probably what you meant). This is only possible because you're working on the client side off course. So to get the player you can do FMLClientHandler.instance().getClient().thePlayer and go on from there to retrieve its helmet stack.

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

		 if (Variables.status == 0){
			 FMLClientHandler.instance().getClient().fontRenderer.drawStringWithShadow("POTATO", 2, 2, 16777215);
                         Variables.status = 1;
		 }

 

You are setting status to 1 after first display, so it does not pass the IF clause next time.

Posted

New code (tickEnd):

public void tickEnd(EnumSet<TickType> type, Object... tickData) {

	 if(type.contains(TickType.RENDER)) {

		 if (Variables.status == 0){
			 FMLClientHandler.instance().getClient().fontRenderer.drawStringWithShadow("POTATO", 2, 2, 16777215);
             

		 }
             
	 }
}

Now it also displays on the Main Menu!  :P How to check if it is ingame?

Posted

You'll automatically solve this when you check for the player wearing the helmet, because there's only a player object when you're in the world. So when player != null results in true you're in the world. Check out https://github.com/MineMaarten/Worms-Mod/blob/master/src/wormsmod/client/render/ProjectileChargeRenderer.java for an example ;). Minecraft#inGameHasFocus() returns true when you're not in the pause screen or other gui which is also a helpful method.

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

The tickEnd:

@Override
public void tickEnd(EnumSet<TickType> type, Object... tickData) {

	 if(type.contains(TickType.RENDER)) {
		 if (FMLClientHandler.instance().getClient().thePlayer != null){

			 if (FMLClientHandler.instance().getClient().thePlayer.getCurrentArmor(0)==GoogleGlassesMod.GoogleGlassStack){
				 FMLClientHandler.instance().getClient().fontRenderer.drawStringWithShadow("POTATO", 2, 2, 16777215);
			 }

		 }

             
	 }
}

And the GoogleGlassStack:

ublic static ItemStack GoogleGlassStack = new ItemStack(GoogleGlassHelmet);

I think I am doing it wrong at the GoogleGlassStack. Help?

Posted

Two things:

1. EntityPlayer#getCurrentArmor(0) returns the boots armor slot. You need EntityPlayer#getCurrentArmor(3).

2. Basic Java ;). With '==' you're checking if the checked objects are the same. This never is the case. You need to do:

ItemStack helmetStack = FMLClientHandler.instance().getClient().thePlayer.getCurrentArmor(3); //just a new variable because the if statement is getting long otherwise
if(helmetStack != null && helmetStack.itemID == GoogleGlassesMod.GoogleGlassStack.itemID){
    //render
}

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted

OMG OMG THANK YOU!!!!

Final code (working):

@Override
public void tickEnd(EnumSet<TickType> type, Object... tickData) {

	 if(type.contains(TickType.RENDER)) {
		 if (FMLClientHandler.instance().getClient().thePlayer != null){
			 ItemStack helmetStack = FMLClientHandler.instance().getClient().thePlayer.getCurrentArmor(3);
			 if(helmetStack != null && helmetStack.itemID == GoogleGlassesMod.GoogleGlassHelmet.itemID){
				 FMLClientHandler.instance().getClient().fontRenderer.drawStringWithShadow("POTATO", 2, 2, 16777215); 
			 }




		 }




             
	 }
}

Posted

Lol! I was reinventing the wheel apparently...

 

None the less, it was a valuable thing to do (in case he wants to do other kinds of gui effects!)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.