Jump to content

Recommended Posts

Posted

Hey,

Just a little intro - I'm a graduating Computer Science Major with an avid love of Minecraft, and am picking up Modding one of my all time favorite games.

 

While I was attempting to create specific recipes for different purposes, I realized that I would have to copy-paste the existing Recipe Manager, or create my own class to manage recipes, if I only wanted them craftable from certain block containers. 

 

Long story short, I created a few modifications to the original CraftingManager that, instead of maintaining a singular RecipeList, changes it to managing an arbitrary number of different Lists, mapped by keys.  I only added methods, and all existing methods use a default key of "minecraft", which allows this to be dropped in as a replacement for the CraftingManager class and continue to have it work as advertised.

 

I'm not sure how useful others will find it, but I found it added quite a bit of functionality without breaking anything existing, and with only a small bit of code.  Also, having the ability to have separate crafting lists is something I feel Forge should support 'out of the box'.

 

Code is as follows:

https://gist.github.com/Itszuvalex/7409109

Posted

Meh, there really isnt much need for a special wrapper around an array list. The functionality is fairly basic, just a couple of loops over the list.

Also, a note about your implemnetation:

1) It breaks compatibility with anyone who reads the list from the field.

2) It should of been submitted in a Pull request

3) Please be a bit more efficient in your implementation. Only one lookup is needed. A single map.get(key) instead of hasKey, get, put, over and over.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Posted

Fair enough.  I only threw this together in a couple hours and figured it was more of a reference to what I was talking about than a final code structure (as I am barely beginning Java).

 

 

Will do as you suggested.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Here is the end of the log. it was way too big to put in pastebin, but I started from when I was online and everything was fine. Error should be in here: https://pastebin.com/Sdhdq593
    • Update: I stand corrected as I was able to dig up a relevant log from my earlier testing which highlights the overall issue but does not explain how to solve it. See, Diagnostic Logs for pack.mcmeta not found: https://pastebin.com/LXS8Rtna
    • Which mod was this? What are all the mods that were in use? It will help if enough information to replicate the problem is available.
    • I have been attempting to create a supplementary resource pack with Patchouli in order to add back the guidebook for Better End but unfortunately in every prototype I have made pack.mcmeta and my resource pack are not recognized. I have tested both zipped and unzipped and either way curseforge does not recognize my resource pack as existing. For testing I stripped my pack down to just the pack.mcmeta file and two empty folders labelled data and assets and I know the data folder is not the problem as firstly my first attempts just had an assets folder following Patchouli instructions and data came later in my flailing attempts to make anything in my pack work. The mcmeta file is not recognized whether or not I use this:  { "pack": { "pack_format": 15, "description": "A replacement for the BetterEnd Guide Book." } "language": { "en_US": { "name": "English", "region": "United States" } } } ,or this:  { "pack": { "pack_format": 15, "description": "A replacement for the BetterEnd Guide Book." } } I have made sure to only use lowercase and the pack folder is named better-end-guide. Is this some magic nonsense from me doing this manually instead of using an IDE or similar tool? Could it be because my files are by default in UTF-8 even though ANSI gives the same results? Is there a specific community secret tool I am supposed to use for zipping or specific settings? I am pulling my hair in distress. Unfortunately as there are no errors involved I lack logs to offer, if that disqualifies this thread please do not be harsh and instead if you can then please direct me to a forum with different rules and sufficiently respectful but knowledgeable as to be of assistance. Most of my experience with the programming community has been poor and so naturally I find myself wary.
    • I never picked up a tier 0 dragon skull to my knowledge. One of my other skulls must have bugged out and randomly became one. I was confused on what the heck it was and tried placing it, now the game will only crash because it can't render in whatever the heck the tier 0 skull is. This is on a server and it crashes anyone within render distance.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.