Jump to content

Recommended Posts

Posted

Ok, so I have a block with a custom block model, and it's animating just fine, but sometimes, the animation is really jerky and odd... any ideas?

 

(My only idea is that because it's changing a value in the model itself, it's changing on a global scale, therefore with every instance of the model, the rotation is added again, making an odd effect.... but I have no clue how to animate it otherwise. :P )

 

This is how I'm animating the model at the moment. The animation works, it's just not smooth (not all the time, at least).

 

public class TileEntityMachineCore extends TileEntity{
float y = 0.0F;
@Override
public void updateEntity() {
	y += 0.05F;
	ModelMachineCore.setRotation(ModelMachineCore.Axel, 0.0F, y, 0.0F);
	ModelMachineCore.setRotation(ModelMachineCore.Gear11, 0.0F, y, 0.0F);
	ModelMachineCore.setRotation(ModelMachineCore.Gear12, 0.0F, y + 0.8F, 0.0F);
	ModelMachineCore.setRotation(ModelMachineCore.Gear21, 0.0F, y, 0.0F);
	ModelMachineCore.setRotation(ModelMachineCore.Gear22, 0.0F, y + 0.8F, 0.0F);
}

}

Posted

You need to apply the rotation in the renderer so the model will update each frame. Just make sure to use the partialticktime variable to sync the animation with the time between the Frames.

PM's regarding modding questions should belong in the Modder Support sub-forum and won't be answered.

Posted

Ok, so partialTickTime, got it. Now just to figure out how and where. lol

 

EDIT: Ok, so I've noticed that it IS because of having multiple tile entities updating single variables in the model file. Is this what using partialTickTime fixes?

Posted

Hi

 

Not exactly, partialTickTime helps you synchronise your animations better if the frame rate is uneven. 

 

I'd suggest that there's a reasonably easy way to fix your problem with the model file being updated by multiple tile entites... i.e. don't update it in multiple tile entities.  Give responsibility for the updating to a single place in your code, eg a TickHandler which is called once per tick.

 

 

-TGG

 

 

 

Posted

Now that it's not the middle of the night, that makes a lot of sense. lol I had a tickk handler implemented in the past, and had re-written the mod from the ground up with 1.6, so yeah, I can do that. xD

 

EDIT: Huzzah! Not only does it not speed up with multiples placed, it now animates in the inventory, as well (before, it would only do so if one or more were placed and loaded)!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Please read the FAQ and post logs as described there.
    • Upon starting the server I get; [main/ERROR] [minecraft/Main]: Failed to start the minecraft server net.minecraftforge.fml.LoadingFailedException: Loading errors encountered: [     Framework (framework) has failed to load correctly §7java.lang.NoClassDefFoundError: net/minecraft/client/gui/components/toasts/Toast ] I suspect there is a (possibly a few) client-only mods installed on my server. Any help would be appreciated! (Yes I know there are a lot of mods...) Here is the crash log:   https://paste.ee/p/pRz5mhMl#s=0
    • That's basically what the failure does, my apologies for failing to specify.  It just tries again on the next tick until it detects the entities for that chunk are loaded, and then tries to load the entity.  From there it gets into different failure states depending on what goes wrong, but in short, if the entity fails to load once the entity list becomes available, the request is cleared and must be resubmitted by the end user.  There should be few cases where that actually happens. Yes, that is my understanding of forceloading.  That's why on a successful summon, it removes the forceload.  Otherwise it does just leave the chunks loaded long term. Thank you for your help, any knowledge is useful!  I don't often mess with forceloading and my prior experience is 1.16 so I'm also a bit out of my depth haha.
    • I will have to do more research about 1.18 chunk loading. You were unclear about how your code manages with the entity load failure. If you simply used a loop, I suggest submitting a tick task to the next tick which does the same thing, checking if the entities are loaded and if so teleporting the right one else submitting another tick task etc. Also I think forceloading permanently force loads the chunk, and it only starts to unload when you make a subsequent call to mark the chunk as not forceloaded. I may be completely wrong, I dont know much about 1.18, most of my experience is 1.20. Good luck I hope you figure it out after all this time 😅
    • i managed to fix it by reinstalling the modpack and re-add all the extra mods I've had previously.
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.