[solved]Sync client and server Extended Properties

[Bedrock_Miner]

Hi!

 

I made some Extended properties applied to EntityPlayer.

Everything works, except from the problem, that on startup the client doesn't sync with the server.

 

ExtendedProperties:

package magicum.minecraft.extendedproperties;

import java.util.HashMap;
import java.util.Map;

import magicum.Main;
import magicum.Resources;
import magicum.minecraft.entity.handler.packets.ManaPacket;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.world.World;
import net.minecraftforge.common.IExtendedEntityProperties;
import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.common.network.Player;

public class ExtendedProperties implements IExtendedEntityProperties {

private int playerMana;
private Map watchedObjects = new HashMap();
private EntityPlayer player;

public ExtendedProperties(EntityPlayer player) {
	this.watchedObjects.put("Mana", this.playerMana);
	this.player = player;
}

@Override
public void saveNBTData(NBTTagCompound compound) {
	compound.setInteger("Mana", (Integer) this.get("Mana"));
}

@Override
public void loadNBTData(NBTTagCompound compound) {
	this.set("Mana", compound.getInteger("Mana"), true);
	Main.proxy.playerMana = compound.getInteger("Mana");
}

@Override
public void init(Entity entity, World world) {
	this.set("Mana", 20, false);
}

public static ExtendedProperties get(EntityPlayerMP entity)
{
	return (ExtendedProperties) entity.getExtendedProperties(Resources.MOD_ID);
}

public void onChanged(String key)
{ 
	if (key == "Mana")
		PacketDispatcher.sendPacketToPlayer(new ManaPacket((Integer)this.get("Mana")).makePacket(), (Player) this.player);
}

//=============================================================================================
//Getters and Setters

public Object get(String key)
{
	return this.watchedObjects.get(key);
}

public void set(String key, Object value, boolean update)
{
	this.watchedObjects.put(key, value);
	if (update)
		this.onChanged(key);
}

public void set(String key, Object value)
{
	this.set(key, value, true);
}

public void add(String key, Object value, boolean update)
{
	this.watchedObjects.put(key, (Integer)this.watchedObjects.get(key) + (Integer)value);
	if (update)
		this.onChanged(key);
}

public void add(String key, Object value)
{
	this.add(key, value, true);
}

public void rem(String key, Object value, boolean update)
{
	this.watchedObjects.put(key, (Integer)this.watchedObjects.get(key) - (Integer)value);
	if (update)
		this.onChanged(key);
}

public void rem(String key, Object value)
{
	this.rem(key, value, true);
}
}

ModPacket:

package magicum.minecraft.entity.handler.packets;

import magicum.Resources;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.network.packet.Packet;

import com.google.common.collect.BiMap;
import com.google.common.collect.ImmutableBiMap;
import com.google.common.io.ByteArrayDataInput;
import com.google.common.io.ByteArrayDataOutput;
import com.google.common.io.ByteStreams;

import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.relauncher.Side;

public abstract class ModPacket {

        public static final String CHANNEL = Resources.MOD_ID;
        private static final BiMap<Integer, Class<? extends ModPacket>> idMap;
               
        static {
                ImmutableBiMap.Builder<Integer, Class<? extends ModPacket>> builder = ImmutableBiMap.builder();
                builder.put(Integer.valueOf(0), ManaPacket.class);   
                idMap = builder.build();
        }
        
        public static ModPacket constructPacket(int packetId) throws ProtocolException, ReflectiveOperationException {
            Class<? extends ModPacket> clazz = idMap.get(Integer.valueOf(packetId));
            if (clazz == null) {
                    throw new ProtocolException("Unknown Packet Id!");
            } else {
                    return clazz.newInstance();
            }
        }

        public static class ProtocolException extends Exception {

            public ProtocolException() {
            }

            public ProtocolException(String message, Throwable cause) {
                    super(message, cause);
            }

            public ProtocolException(String message) {
                    super(message);
            }

            public ProtocolException(Throwable cause) {
                    super(cause);
            }
        }
        
        public final int getPacketId() {
            if (idMap.inverse().containsKey(getClass())) {
                    return idMap.inverse().get(getClass()).intValue();
            } else {
                    throw new RuntimeException("Packet " + getClass().getSimpleName() + " is missing a mapping!");
            }
        }
   
        public final Packet makePacket() {
            ByteArrayDataOutput out = ByteStreams.newDataOutput();
            out.writeByte(getPacketId());
            write(out);
            return PacketDispatcher.getPacket(CHANNEL, out.toByteArray());
        }
        
        public abstract void write(ByteArrayDataOutput out);
        
        public abstract void read(ByteArrayDataInput in) throws ProtocolException;
       
        public abstract void execute(EntityPlayer player, Side side) throws ProtocolException;
}

ManaPacket:

package magicum.minecraft.entity.handler.packets;

import magicum.Main;
import magicum.minecraft.extendedproperties.ExtendedProperties;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;

import com.google.common.io.ByteArrayDataInput;
import com.google.common.io.ByteArrayDataOutput;

import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.common.network.Player;
import cpw.mods.fml.relauncher.Side;

public class ManaPacket extends ModPacket {

private int mana;

public ManaPacket(int manaValue) {
	this.mana = manaValue;
}

public ManaPacket() {}

@Override
public void write(ByteArrayDataOutput out) {
	out.writeInt(this.mana);
}

@Override
public void read(ByteArrayDataInput in) throws ProtocolException {
	this.mana = in.readInt();
}

@Override
public void execute(EntityPlayer player, Side side) throws ProtocolException {
	if (side.isClient())
	{
		if (this.mana < 0)  this.mana = 0;
		if (this.mana > 20) this.mana = 20;
		Main.proxy.playerMana = this.mana;
		System.out.println("Mana received! " + Main.proxy.playerMana);
	} else {
		if (this.mana < 0)  this.mana = 0;
		if (this.mana > 20) this.mana = 20;
		ExtendedProperties.get((EntityPlayerMP) player).set("Mana", this.mana, false);
		PacketDispatcher.sendPacketToPlayer(this.makePacket(), (Player) player);
	}
}
}

Initialization:

@ForgeSubscribe(priority=EventPriority.NORMAL)
public void onEntityConstructing(EntityConstructing e)
{
	if (e.entity instanceof EntityPlayer)
	{
		e.entity.registerExtendedProperties(Resources.MOD_ID, new ExtendedProperties( (EntityPlayer) e.entity ));
	}
}

 

The Value should Auto-sync on startup but it doesnt.

How can this be fixed?

 

(Write if i missed important classes)

[Bedrock_Miner]

You can't compare strings with ==. Use equals.

It also works with == in all my earlier mods.

 

But even if I change it it won't work.

[Bedrock_Miner]

When I join a world (SP/MP) the Mana Bar shows a value of 0.

When I perform an action to change the Mana it gets synchronized and shows the right value. This is the first time when "Mana received!" is printed out.

 

I think, the PacketDispatcher is not started when I join or something else.

[coolAlias]

I typically use the EntityJoinWorldEvent to send a packet syncing extended properties, as you can't sync during the entity constructing phase of the process.

[TheGreyGhost]

Hi

 

Just something I noticed you said

 

It's really important for you to understand the difference between

 

object1 == object2

and

object1.equals(object2)

 

If you don't, it will cause you endless head damage in Java.

http://www.javabeat.net/2013/02/what-is-difference-between-equals-and/#

http://java67.blogspot.com.au/2012/11/difference-between-operator-and-equals-method-in.html

 

-TGG

 

 

[Bedrock_Miner]

Hi

 

Just something I noticed you said

 

It's really important for you to understand the difference between

 

object1 == object2

and

object1.equals(object2)

 

If you don't, it will cause you endless head damage in Java.

http://www.javabeat.net/2013/02/what-is-difference-between-equals-and/#

http://java67.blogspot.com.au/2012/11/difference-between-operator-and-equals-method-in.html

 

-TGG

 

Thank you, I didn't know that before.

 

@coolAlias:

 

Thanks, it works now..

I added this code:

@ForgeSubscribe(priority=EventPriority.NORMAL)
public void onEntityJoinWorld(EntityJoinWorldEvent e)
{
	if (e.entity instanceof EntityPlayerMP)
	{
		ExtendedProperties.get((EntityPlayerMP) e.entity).updateAll();
		System.out.println("UPDATED");
	}
}

 

 

I tried this before, but with this code, so I got casting-errors:

@ForgeSubscribe(priority=EventPriority.NORMAL)
public void onEntityJoinWorld(EntityJoinWorldEvent e)
{
	if (e.entity instanceof EntityPlayer) //only check for EntityPlayer, not for EntityPlayerMP!
	{
		ExtendedProperties.get((EntityPlayerMP) e.entity).updateAll();
		System.out.println("UPDATED");
	}
}

 

 

 

[Draco18s]

EntityPlayerMP (and it's relatives, like EntityPlayerClientMP) only exist either Server side or Client side, not both.

 

You should check for if(world.isRemote) or if(!world.isRemote)

(e.entity.worldObject being an appropriate stand-in if you don't have a world object already)

 

After you've determine you are on the client (or server, as appropriate) can you check for typecasting.

[coolAlias]

Yep, Draco's right about that. Why not just check if instanceof EntityPlayer and cast to that? You don't need a specifically sided version for this.