[PullReq]Player NameTag Render Range change

[DarkGuardsman]

Original Post

 

  Reveal hidden contents

I've made a suggestion like this before so sorry if i didn't revive that post. i'm looking for a way i can access var12 in renderName method in RenderPlayer.class. My suggestion is too move the variable out of renderName method and in to the class itself. This way name tag render range can be accessed and changed.  Also so i no longer conflict with other mods like smart moving when i edit the class. If there is a better way than listed bellow do make changes.

 

 protected void renderName(EntityPlayer par1EntityPlayer, double par2, double par4, double par6)
    {
        if (Minecraft.isGuiEnabled() && par1EntityPlayer != this.renderManager.livingPlayer)
        {
            float var8 = 1.6F;
            float var9 = 0.016666668F * var8;
            double var10 = par1EntityPlayer.getDistanceSqToEntity(this.renderManager.livingPlayer);
           [b] float var12 = par1EntityPlayer.isSneaking() ? 32.0F : 64.0F;[/b]

            if (var10 < (double)(var12 * var12))
            {

to

[b]public static float RenderRange1 =  32.0F;
public static float RenderRange2 =  64.0F;[/b]
protected void renderName(EntityPlayer par1EntityPlayer, double par2, double par4, double par6)
    {
        if (Minecraft.isGuiEnabled() && par1EntityPlayer != this.renderManager.livingPlayer)
        {
            float var8 = 1.6F;
            float var9 = 0.016666668F * var8;
            double var10 = par1EntityPlayer.getDistanceSqToEntity(this.renderManager.livingPlayer);
           [b] float var12 = par1EntityPlayer.isSneaking() ? RenderRange1 : RenderRange2;[/b]

            if (var10 < (double)(var12 * var12))
            {

I would make a pull request on forge github but i don't understand how to add it to the patch folder correctly.

 

I finally figured out how to make a patch and made the changes i original asked for. So could a forge dev pull my request or implement the changes. I really would love to use this in my ComeCloser mod so its compatible with several mods. Also thank you in advance

https://github.com/MinecraftForge/MinecraftForge/pull/174

Also if i messed up making the patch file do tell me so i can fix it and know what to look for next time i make one.

[OvermindDL1]

updatepatches.bat/sh

[DarkGuardsman]

  On 8/21/2012 at 7:04 AM, OvermindDL1 said:

updatepatches.bat/sh

could you add to that a little, do i just run it in my mcp after i make the changes in my src?

edit: i don't have an updatePatch.bat/sh in my mcp?

[Alex_hawks]

You fork the repo to work on the source. Downloading the source from the release thread (or Jenkins) is for working with forge.

[DarkGuardsman]

I made the changes to the patch file could a forge dev pull my request. I really would love to use this in my ComeCloser mod so its compatible with several mods.

https://github.com/MinecraftForge/MinecraftForge/pull/174