Jump to content

[PullReq]Player NameTag Render Range change


DarkGuardsman

Recommended Posts

Original Post

 

I've made a suggestion like this before so sorry if i didn't revive that post. i'm looking for a way i can access var12 in renderName method in RenderPlayer.class. My suggestion is too move the variable out of renderName method and in to the class itself. This way name tag render range can be accessed and changed.  Also so i no longer conflict with other mods like smart moving when i edit the class. If there is a better way than listed bellow do make changes.

 

 protected void renderName(EntityPlayer par1EntityPlayer, double par2, double par4, double par6)
    {
        if (Minecraft.isGuiEnabled() && par1EntityPlayer != this.renderManager.livingPlayer)
        {
            float var8 = 1.6F;
            float var9 = 0.016666668F * var8;
            double var10 = par1EntityPlayer.getDistanceSqToEntity(this.renderManager.livingPlayer);
           [b] float var12 = par1EntityPlayer.isSneaking() ? 32.0F : 64.0F;[/b]

            if (var10 < (double)(var12 * var12))
            {

to

[b]public static float RenderRange1 =  32.0F;
public static float RenderRange2 =  64.0F;[/b]
protected void renderName(EntityPlayer par1EntityPlayer, double par2, double par4, double par6)
    {
        if (Minecraft.isGuiEnabled() && par1EntityPlayer != this.renderManager.livingPlayer)
        {
            float var8 = 1.6F;
            float var9 = 0.016666668F * var8;
            double var10 = par1EntityPlayer.getDistanceSqToEntity(this.renderManager.livingPlayer);
           [b] float var12 = par1EntityPlayer.isSneaking() ? RenderRange1 : RenderRange2;[/b]

            if (var10 < (double)(var12 * var12))
            {

I would make a pull request on forge github but i don't understand how to add it to the patch folder correctly.

 

I finally figured out how to make a patch and made the changes i original asked for. So could a forge dev pull my request or implement the changes. I really would love to use this in my ComeCloser mod so its compatible with several mods. Also thank you in advance :)

https://github.com/MinecraftForge/MinecraftForge/pull/174

Also if i messed up making the patch file do tell me so i can fix it and know what to look for next time i make one.

Link to comment
Share on other sites

  • 5 weeks later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.