Items use last item's info

[Casual Dutchman]

So I made say 10 item within forge.

I made a custom Sword.

The only thing it add is a new int.

That int call the texture of the item.

 

Now all items use that info from the last item.

Last item in was 10, all items use 10.

 

It worked perfectly fine when I created it.

But it is rubbish now, I have no clue about the problem or how to fix it.

 

Please help

[Casual Dutchman]

The Item instances are singletons. You have to store your information in the ItemStack.

Could you give me some more info about that?

I'm dutch so I don't understad some things

[MineMaarten]

Storing in the ItemStack can either be done in 1. damagevalues or 2. NBT. As you're damagevalue probably already has been taken by how much the item is damaged you need to use NBT. And for a beginner that's quite advanced stuff.

[TheGreyGhost]

Hi

 

If you've only got a couple of different textures, I'd suggest you just make a different sword for each texture.  That's a lot easier when you're just starting with modding.

 

-TGG

[Casual Dutchman]

To create a new Item you create an instance of it, right? (

new ItemFoobar()

)

There is only this single instance of the item, so if you store data in it, it will remain consistent for all stacks that contain your item. Therefor you have to store the data in the ItemStack.

By creating an instance for every sword worked out the first time.

I made that (lets say) 10 swords, used the new int and it worked fine.

This was the result : http://minecraft.curseforge.com/mc-mods/potion-blade/

It worked all fine.

Until I opened Eclipse a next time.

I runned it and it used only the new int of the last sword.

 

I think this is really wierd.

that's why I putted it up here.

[Draco18s]

Post code.

[Casual Dutchman]

Post code.

Here:

I deleted some stuff that is not related to the problem.

Sword with potion

 

public class PotionSword extends ItemSword{

private Icon sword;
private Icon overlay;

private String unlocname;
private static int potionID;

public PotionSword(int id, int pot, String name, EnumToolMaterial mat)
{
	super(id, mat);
	unlocname = name;
	potionID = pot;
	this.setCreativeTab(Core.tabBlades);
	this.setUnlocalizedName(unlocname + "_" + potion[potionID]);
}

@Override
public Icon getIconFromDamageForRenderPass(int damage, int pass) {
  if(pass == 0) {
    return this.sword;
  }
  else {
    return this.overlay;
  }
}

@SideOnly(Side.CLIENT)
    public boolean requiresMultipleRenderPasses()
    {
        return true;
    }

public boolean hitEntity(ItemStack par1ItemStack, EntityLivingBase par2EntityLivingBase, EntityLivingBase par3EntityLivingBase)
    {
    	par2EntityLivingBase.addPotionEffect(new PotionEffect(potionID, 100 + rand.nextInt(20)));
        par1ItemStack.damageItem(1, par3EntityLivingBase);
        return true;
    }

@Override 
public void registerIcons(IconRegister i) {

this.sword = i.registerIcon(unlocname);	
this.overlay = i.registerIcon(Core.getModid() + ":" + "overlay_" + potion[potionID]);

}
}

 

main file

 

protected static final String modID = "potionblade";

public static String getModid() {
	return modID;
}

private static int itemID = 5000;

@SidedProxy(clientSide="potionblade.Main.ClientProxy", serverSide="potionblade.Main.CommonProxy")
public static CommonProxy proxy;

@Mod.Instance(Core.modID)
public static Core instance;

public static CreativeTabs tabBlades = new CreativeTabs("tabBlades") {
	public ItemStack getIconItemStack() { return new ItemStack(WoodSwordMovespeed, 1, 0); }};

public static final Item WoodSwordMovespeed = new PotionSword(++itemID, 1, "wood_sword", EnumToolMaterial.WOOD);
public static final Item StoneSwordMovespeed = new PotionSword(++itemID, 1, "stone_sword", EnumToolMaterial.STONE);
public static final Item IronSwordMovespeed = new PotionSword(++itemID, 1, "iron_sword", EnumToolMaterial.IRON);
public static final Item GoldSwordMovespeed = new PotionSword(++itemID, 1, "gold_sword", EnumToolMaterial.GOLD);
public static final Item DiamondSwordMovespeed = new PotionSword(++itemID, 1, "diamond_sword", EnumToolMaterial.EMERALD);

public static final Item WoodSwordmoveslowdown = new PotionSword(++itemID, 2, "wood_sword", EnumToolMaterial.WOOD);
public static final Item StoneSwordmoveslowdown = new PotionSword(++itemID, 2, "stone_sword", EnumToolMaterial.STONE);
public static final Item IronSwordmoveslowdown = new PotionSword(++itemID, 2, "iron_sword", EnumToolMaterial.IRON);
public static final Item GoldSwordmoveslowdown = new PotionSword(++itemID, 2, "gold_sword", EnumToolMaterial.GOLD);
public static final Item DiamondSwordmoveslowdown = new PotionSword(++itemID, 2, "diamond_sword", EnumToolMaterial.EMERALD);

public static final Item WoodSworddamageboost = new PotionSword(++itemID, 5, "wood_sword", EnumToolMaterial.WOOD);
public static final Item StoneSworddamageboost = new PotionSword(++itemID, 5, "stone_sword", EnumToolMaterial.STONE);
public static final Item IronSworddamageboost = new PotionSword(++itemID, 5, "iron_sword", EnumToolMaterial.IRON);
public static final Item GoldSworddamageboost = new PotionSword(++itemID, 5, "gold_sword", EnumToolMaterial.GOLD);
public static final Item DiamondSworddamageboost = new PotionSword(++itemID, 5, "diamond_sword", EnumToolMaterial.EMERALD);

public static final Item WoodSwordharm = new PotionSword(++itemID, 7, "wood_sword", EnumToolMaterial.WOOD);
public static final Item StoneSwordharm = new PotionSword(++itemID, 7, "stone_sword", EnumToolMaterial.STONE);
public static final Item IronSwordharm = new PotionSword(++itemID, 7, "iron_sword", EnumToolMaterial.IRON);
public static final Item GoldSwordharm = new PotionSword(++itemID, 7, "gold_sword", EnumToolMaterial.GOLD);
public static final Item DiamondSwordharm = new PotionSword(++itemID, 7, "diamond_sword", EnumToolMaterial.EMERALD);

deleted some here, just too long

public static final Item StoneSwordWither = new PotionSword(++itemID, 20, "stone_sword", EnumToolMaterial.STONE);
public static final Item IronSwordWither = new PotionSword(++itemID, 20, "iron_sword", EnumToolMaterial.IRON);
public static final Item GoldSwordWither = new PotionSword(++itemID, 20, "gold_sword", EnumToolMaterial.GOLD);
public static final Item DiamondSwordWither = new PotionSword(++itemID, 20, "diamond_sword", EnumToolMaterial.EMERALD);

inside the load file are all the addNames and addRecipes
this is to related to the problem

The first WoodSwordmovespeed hase the wither effect to it.

but it has the potion id of 1 to it.

btw, all sowrds have the wither effect applied to them.

 

btw, Could I use the getPotionColor methode liek the one in the ItemPotion to color the overlay only?

or would it olso give the sword an extra color?

just a question, maybe someone knows?

[Draco18s]

private static int potionID;

 

Go learn Java.  This line is your problem and it's really easy to fix and if you knew anything about any object oriented language you'd know what the problem is.

[Casual Dutchman]

private static int potionID;

 

Go learn Java.  This line is your problem and it's really easy to fix and if you knew anything about any object oriented language you'd know what the problem is.

I have learned it for a bit, not very indepth or something.

 

I think I know how to fix it?

correct me if I'm wrong.

 

I need to make the potionID a non-static int.

Then I need to make a static getter for the int.

 

 

I have no time to try this out, so I'm just asking.

[Draco18s]

Then I need to make a static getter for the int.

 

Wat.

[Casual Dutchman]

I was not at home to check the code

I know I need to just deleted the static reference.

it is not needed.

 

I changed it some how?