Hey,

in my RealWeather mod I have a problem, the maximum Temperature in minecraft is 2.0f but then i wana set ALL biomes to that value, its crash with:

java.lang.ArrayIndexOutOfBoundsException: -255 at net.minecraft.world.ColorizerGrass.getGrassColor(ColorizerGrass.java:25)

 

I need to set the Temperature so high for support the EnviroMine Mod, its check the Temperature.

What humidity value are you trying to use?

dessert have normal 2.0

with temp >= 1.1 its crashs

ERROR: QUESTION NOT ANSWERED.  UNABLE TO FORMULATE REPLY.

QUITTING PROGRAM.

APPLICATION QUIT UNEXPECTEDLY: BAD INPUT.

lol sry ... dident know humidity is the rainfall, my english isent so perfect.

did try

biom.setTemperatureRainfall(2.0f, 0.0f);

biom.setTemperatureRainfall(2.0f, 0.5f);

biom.setTemperatureRainfall(2.0f, 1.0f);

 

Thats the list for the Bioms (Original):

2013-12-11 20:54:26 [iNFO] [cherry_realweather] Ocean - Temp:0.5- Rainfall:0.5
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Plains - Temp:0.8- Rainfall:0.4
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Desert - Temp:2.0- Rainfall:0.0
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Extreme Hills - Temp:0.2- Rainfall:0.3
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Forest - Temp:0.7- Rainfall:0.8
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Taiga - Temp:0.05- Rainfall:0.8
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Swampland - Temp:0.8- Rainfall:0.9
2013-12-11 20:54:26 [iNFO] [cherry_realweather] River - Temp:0.5- Rainfall:0.5
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Hell - Temp:2.0- Rainfall:0.0
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Sky - Temp:0.5- Rainfall:0.5
2013-12-11 20:54:26 [iNFO] [cherry_realweather] FrozenOcean - Temp:0.0- Rainfall:0.5
2013-12-11 20:54:26 [iNFO] [cherry_realweather] FrozenRiver - Temp:0.0- Rainfall:0.5
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Ice Plains - Temp:0.0- Rainfall:0.5
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Ice Mountains - Temp:0.0- Rainfall:0.5
2013-12-11 20:54:26 [iNFO] [cherry_realweather] MushroomIsland - Temp:0.9- Rainfall:1.0
2013-12-11 20:54:26 [iNFO] [cherry_realweather] MushroomIslandShore - Temp:0.9- Rainfall:1.0
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Beach - Temp:0.8- Rainfall:0.4
2013-12-11 20:54:26 [iNFO] [cherry_realweather] DesertHills - Temp:2.0- Rainfall:0.0
2013-12-11 20:54:26 [iNFO] [cherry_realweather] ForestHills - Temp:0.7- Rainfall:0.8
2013-12-11 20:54:26 [iNFO] [cherry_realweather] TaigaHills - Temp:0.05- Rainfall:0.8
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Extreme Hills Edge - Temp:0.2- Rainfall:0.3
2013-12-11 20:54:26 [iNFO] [cherry_realweather] Jungle - Temp:1.2- Rainfall:0.9
2013-12-11 20:54:26 [iNFO] [cherry_realweather] JungleHills - Temp:1.2- Rainfall:0.9

DesertHills have 2.0f, 0.0f ... but that will dont work for some bioms and with a try n catch block, i cant get the Bioms what give me that exception, couse its a render method at client side

Ok, I looked into things.

 

Even though Deserts have a temp greater than 1, when the color is polled, that value is capped at 1:

 

BiomeGenBase line 370

    /**
     * Provides the basic grass color based on the biome temperature and rainfall
     */
    public int getBiomeGrassColor()
    {
        double d0 = (double)MathHelper.clamp_float(this.getFloatTemperature(), 0.0F, 1.0F);
        double d1 = (double)MathHelper.clamp_float(this.getFloatRainfall(), 0.0F, 1.0F);
        return getModdedBiomeGrassColor(ColorizerGrass.getGrassColor(d0, d1));
    }

 

So either, you've overridden this method causing the values to be uncapped, you're your doing something else Bad and passing uncapped values to the grass colorizer.

nice! it was the BiomeGenSwamp!! Thx

wow, thats well. but the last question ... I need to Override that with ASM or ... ?

nice! it was the BiomeGenSwamp!! Thx

wow, thats well. but the last question ... I need to Override that with ASM or ... ?

 

?!?

 

You shouldn't be override-ing the method at all.

sry, i did wrote it a bit bad, the BiomeGenSwamp havent that calc:

 

    public int getBiomeGrassColor()
    {
        double d0 = (double)this.getFloatTemperature();
        double d1 = (double)this.getFloatRainfall();
        return ((ColorizerGrass.getGrassColor(d1, d0) & 16711422) + 5115470) / 2;
    }

    @SideOnly(Side.CLIENT)

    /**
     * Provides the basic foliage color based on the biome temperature and rainfall
     */
    public int getBiomeFoliageColor()
    {
        double d0 = (double)this.getFloatTemperature();
        double d1 = (double)this.getFloatRainfall();
        return ((ColorizerFoliage.getFoliageColor(d0, d1) & 16711422) + 5115470) / 2;
    }

Yes...it also overrides the function from BiomeGenBase...

 

    @SideOnly(Side.CLIENT)

    /**
     * Provides the basic grass color based on the biome temperature and rainfall
     */
    public int getBiomeGrassColor()
    {
        double d0 = (double)MathHelper.clamp_float(this.getFloatTemperature(), 0.0F, 1.0F);
        double d1 = (double)MathHelper.clamp_float(this.getFloatRainfall(), 0.0F, 1.0F);
        return getModdedBiomeGrassColor(ColorizerGrass.getGrassColor(d0, d1));
    }

    @SideOnly(Side.CLIENT)

    /**
     * Provides the basic foliage color based on the biome temperature and rainfall
     */
    public int getBiomeFoliageColor()
    {
        double d0 = (double)MathHelper.clamp_float(this.getFloatTemperature(), 0.0F, 1.0F);
        double d1 = (double)MathHelper.clamp_float(this.getFloatRainfall(), 0.0F, 1.0F);
        return getModdedBiomeFoliageColor(ColorizerFoliage.getFoliageColor(d0, d1));
    }

and now i have to override that with asm or is there a another way ... have to learn that first ...

Why ever for?

I'm writing a RealWeather mod and want add support for that mod: http://www.minecraftforum.net/topic/2150779-enviromine-a-little-bit-of-realism-164-109/

 

So then its cold at my door, its cold in minecraft too ^^ I think that mod is perfectly with my together ^^