MCPatcher/FML Incompatibility

[JRoush]

I'm having this problem (posted on Aug. 19th).  While the author of that thread may not have been very diplomatic, what he was reporting is an actual issue.

 

The problem appears to be the way that the newest FML for 1.2.5/1.3.x searches for mods.  It uses the minecraft classpath(s) as a starting point to look for mods in minecraft.jar.  MCPatcher adds the root ".minecraft" directory as a classpath, causing FML to attempt to load all mods in the .minecraft folder and all subfolders.  Any unwanted mods that happen to be lying around (for example older versions or in my case the contents of the MCP folder) get picked up and loaded.  Those unwanted mods are what cause the crash.

 

I reported this to the author of MCPatcher as well.  I know that some people are not fond of MCPatcher, but I think that this might be something worth changing about FML regardless.  Checking the classpaths may seem more elegant than checking minecraft.jar explicitly, but I would suggest that a more limited approach (only load mods from predetermined locations) would be better.

 

FML Log Excerpt (the whole thing is on pastebin):

 

 

...

2012-08-22 21:24:39 [FINE] Found a minecraft related file at C:\Users\John\AppData\Roaming\.minecraft\bin\minecraft.jar, loading

2012-08-22 21:24:39 [FINE] Found a mod class mod_MinecraftForge in file minecraft.jar, attempting to load it

2012-08-22 21:24:39 [FINE] ModLoader BaseMod class mod_MinecraftForge found, loading

2012-08-22 21:24:39 [FINE] ModLoader BaseMod class mod_MinecraftForge loaded

2012-08-22 21:24:39 [FINE] Mod class mod_MinecraftForge loaded successfully

2012-08-22 21:24:39 [FINE] Found a minecraft related file at C:\Users\John\AppData\Roaming\.minecraft\bin\lwjgl.jar, loading

2012-08-22 21:24:39 [FINE] Found a minecraft related file at C:\Users\John\AppData\Roaming\.minecraft\bin\lwjgl_util.jar, loading

2012-08-22 21:24:39 [FINE] Found a minecraft related file at C:\Users\John\AppData\Roaming\.minecraft\bin\jinput.jar, loading

2012-08-22 21:24:39 [FINE] Found a minecraft related directory at C:\Users\John\AppData\Roaming\.minecraft, loading

2012-08-22 21:24:39 [FINEST] Recursing into package bin

...

 

 

 

MCPatcher Log:

 

MCPatcher version is 2.4.2
OS: Windows Vista 6.0 amd64
JVM: Oracle Corporation 1.7.0_03 (64 bit)
Classpath: C:\Users\John\AppData\Roaming\.minecraft\mcpatcher-2.4.2.exe
Minecraft version is 1.2.5 (md5 8e8778078a175a33603a585257f28563)

Analyzing C:\Users\John\AppData\Roaming\.minecraft\bin\minecraft-1.2.5.jar (1524 files)
  GLAllocation matches ew.class
   createDirectByteBuffer matches c (I)Ljava/nio/ByteBuffer;
  GameSettings matches hu.class
  Minecraft matches net/minecraft/client/Minecraft.class
  Minecraft matches net/minecraft/client/Minecraft.class
   runGameLoop matches x ()V
   startGame matches a ()V
  Minecraft matches net/minecraft/client/Minecraft.class
   runGameLoop matches x ()V
   startGame matches a ()V
  Minecraft matches net/minecraft/client/Minecraft.class
   runGameLoop matches x ()V
   startGame matches a ()V
  Minecraft matches net/minecraft/client/Minecraft.class
  Minecraft matches net/minecraft/client/Minecraft.class
   runGameLoop matches x ()V
  Minecraft matches net/minecraft/client/Minecraft.class
  Minecraft matches net/minecraft/client/Minecraft.class
  TexturePackDefault matches lc.class
  TexturePackDefault matches lc.class
  TexturePackList matches gi.class
   updateAvailableTexturePacks matches a ()V
  TexturePackList matches gi.class
   updateAvailableTexturePacks matches a ()V
  TexturePackCustom matches aju.class
  TexturePackCustom matches aju.class
  TexturePackFolder matches aiq.class
  TexturePackFolder matches aiq.class
  TexturePackBase matches h.class
   getInputStream matches a (Ljava/lang/String;)Ljava/io/InputStream;
  TexturePackBase matches h.class
   getInputStream matches a (Ljava/lang/String;)Ljava/io/InputStream;
  EntityDropParticleFX matches ga.class
   onUpdate matches J_ ()V
  EntityAuraFX matches xy.class
  EntityPortalFX matches aep.class
  EntitySplashFX matches nw.class
  EntityRainFX matches rg.class
  EntityReddustFX matches aab.class
  EntityFX matches rt.class
  EntitySuspendFX matches ky.class
  EntityBubbleFX matches vg.class
  EntityRenderer matches lr.class
   updateFogColor matches g (F)V
   updateLightmap matches e ()V
  RenderEngine matches aaw.class
   updateDynamicTextures matches a ()V
   refreshTextures matches b ()V
  RenderEngine matches aaw.class
  RenderEngine matches aaw.class
  Tessellator matches adz.class
   draw matches a ()I
   addVertexWithUV matches a (DDDDD)V
   startDrawingQuads matches b ()V
   addVertex matches a (DDD)V
   startDrawing matches a (I)V
   setTextureUV matches a (DD)V
  Tessellator matches adz.class
   draw matches a ()I
   addVertexWithUV matches a (DDDDD)V
   reset matches d ()V
   startDrawingQuads matches b ()V
   addVertex matches a (DDD)V
   startDrawing matches a (I)V
   setTextureUV matches a (DD)V
  RenderGlobal matches l.class
   renderSky matches a (F)V
   renderClouds matches b (F)V
  RenderGlobal matches l.class
   renderSky matches a (F)V
  ItemRenderer matches mn.class
  ItemRenderer matches mn.class
   renderItem matches a (Lacq;Laan;I)V
  RenderBlocks matches vl.class
   renderStandardBlockWithAmbientOcclusion matches a (Lpb;IIIFFF)Z
   renderStandardBlockWithColorMultiplier matches b (Lpb;IIIFFF)Z
   non-AO multipliers (R G B) = (14 15 16)
   AO faces (N S E W) = (17 18 15 16)
  RenderBlocks matches vl.class
   renderBlockRedstoneWire matches g (Lpb;III)Z
   renderBlockFallingSand matches a (Lpb;Lxd;III)V
   renderBlockFluids matches n (Lpb;III)Z
  RenderBlocks matches vl.class
   renderBlockPane matches a (Lakq;III)Z
   renderStandardBlock matches o (Lpb;III)Z
  WorldRenderer matches ct.class
   updateRenderer matches a ()V
  TileEntitySignRenderer matches ll.class
   renderTileSignEntityAt matches a (Lsc;DDDF)V
  RenderLiving matches fe.class
   doRenderLiving matches a (Lacq;DDDFF)V
  RenderXPOrb matches tb.class
   render matches a (Lbz;DDDFF)V
  Render matches um.class
  RenderSpider matches amo.class
  RenderMooshroom matches cl.class
   doRenderLiving matches a (Lacq;DDDFF)V
   loadTexture matches a (Ljava/lang/String;)V
   renderEquippedItems1 matches a (Lof;F)V
  RenderEnderman matches st.class
  RenderSnowman matches afm.class
   doRenderLiving matches a (Lacq;DDDFF)V
   renderEquippedItems1 matches a (Lq;F)V
  TextureFX matches tt.class
   onTick matches a ()V
  Watch matches ht.class
  StillWater matches qa.class
  Fire matches nh.class
  Compass matches tu.class
  FlowLava matches gf.class
  FlowWater matches ael.class
  StillLava matches bv.class
  Portal matches zp.class
  FontRenderer matches nl.class
   <init> matches <init> (Lhu;Ljava/lang/String;Laaw;Z)V
  FontRenderer matches nl.class
   renderString matches a (Ljava/lang/String;IIIZ)I
  NBTTagCompound matches ady.class
  Potion matches aad.class
   setPotionName matches a (Ljava/lang/String;)Laad;
  Entity matches nn.class
   setPositionAndRotation matches b (DDDFF)V
  Entity matches nn.class
   setPositionAndRotation matches b (DDDFF)V
  EntityList matches aao.class
  EntityLiving matches acq.class
   setPositionAndRotation matches b (DDDFF)V
  EntityLiving matches acq.class
   setPositionAndRotation matches b (DDDFF)V
  EntitySheep matches cu.class
  ItemDye matches hm.class
  Item matches yr.class
   getColorFromDamage matches b (II)I
   getColorFromDamage(II)I has 2 params
  ItemSpawnerEgg matches acv.class
   getItemNameIS matches d (Laan;)Ljava/lang/String;
   getColorFromDamage matches b (II)I
  ItemBlock matches vd.class
   getColorFromDamage matches b (II)I
  PotionHelper matches hx.class
  ColorizerFoliage matches gu.class
  World matches .class
   getSkyColor matches a (Lnn;F)Lbo;
   getSunAngle matches b (F)F
  World matches .class
   getCelestialAngle matches c (F)F
   getRainStrength matches j (F)F
  IBlockAccess matches ali.class
  IBlockAccess matches ali.class
  IBlockAccess matches ali.class
  BiomeGenBase matches abn.class
   getTemperaturef matches j ()F
   getRainfallf matches i ()F
   setBiomeName matches a (Ljava/lang/String;)Labn;
  WorldChunkManager matches rs.class
  BiomeGenSwamp matches ahs.class
   getTemperaturef matches j ()F
   getRainfallf matches i ()F
   setBiomeName matches a (Ljava/lang/String;)Labn;
  WorldProvider matches alb.class
   getFogColor matches b (FF)Lbo;
  WorldProviderHell matches akf.class
   getFogColor matches b (FF)Lbo;
  WorldProviderEnd matches ii.class
   getFogColor matches b (FF)Lbo;
  Material matches acn.class
  MapColor matches wh.class
  BlockCauldron matches xm.class
   colorMultiplier matches c (Lali;III)I
  BlockGrass matches qy.class
   getBlockTexture matches d (Lali;IIII)I
  BlockLeaves matches uf.class
   colorMultiplier matches c (Lali;III)I
  BlockFluid matches agv.class
   colorMultiplier matches c (Lali;III)I
  BlockMycelium matches alr.class
   getBlockTexture matches d (Lali;IIII)I
  BlockRedstoneWire matches ahi.class
   randomDisplayTick matches b (Lxd;IIILjava/util/Random;)V
   colorMultiplier matches c (Lali;III)I
  BlockStem matches aei.class
   getRenderColor matches d (I)I
  Block matches pb.class
  Block matches pb.class
   colorMultiplier matches c (Lali;III)I
   getRenderColor matches d (I)I
  Block matches pb.class
   getBlockTextureFromSideAndMetadata matches a (II)I
   getBlockTexture matches d (Lali;IIII)I
  BlockLilyPad matches ye.class

Analyzing C:\Users\John\AppData\Roaming\.minecraft\bin\minecraft-1.2.5.jar (3 dependent classes)
  ColorizerWater matches zt.class (pass 2)
   loadColorBuffer matches a ([i)V
  ColorizerGrass matches zv.class (pass 2)
   loadColorBuffer matches a ([i)V
  ColorizerFoliage matches gu.class (pass 2)
   loadColorBuffer matches a ([i)V

Analyzing C:\Users\John\AppData\Roaming\.minecraft\bin\minecraft-1.2.5.jar (methods and fields)
  Minecraft (net/minecraft/client/Minecraft.class)
  Minecraft (net/minecraft/client/Minecraft.class)
   field texturePackList matches E Lgi;
  TexturePackList (gi.class)
   method setTexturePack matches a (Lh;)Z
   field selectedTexturePack matches a Lh;
   field defaultTexturePack matches c Lh;
  TexturePackBase (h.class)
   field texturePackFileName matches a Ljava/lang/String;
  TexturePackDefault (lc.class)
  TexturePackCustom (aju.class)
   field file matches h Ljava/io/File;
   field zipFile matches e Ljava/util/zip/ZipFile;
  TexturePackFolder (aiq.class)
   field folder matches g Ljava/io/File;
  Minecraft (net/minecraft/client/Minecraft.class)
   field texturePackList matches E Lgi;
  TexturePackList (gi.class)
   method setTexturePack matches a (Lh;)Z
   field selectedTexturePack matches a Lh;
   field defaultTexturePack matches c Lh;
  TexturePackBase (h.class)
   field texturePackFileName matches a Ljava/lang/String;
  TexturePackDefault (lc.class)
  TexturePackCustom (aju.class)
   field file matches h Ljava/io/File;
   field zipFile matches e Ljava/util/zip/ZipFile;
  TexturePackFolder (aiq.class)
   field folder matches g Ljava/io/File;
  RenderEngine (aaw.class)
   field imageData matches h Ljava/nio/ByteBuffer;
   field textureList matches i Ljava/util/List;
   method registerTextureFX matches a (Ltt;)V
   method readTextureImage matches a (Ljava/io/InputStream;)Ljava/awt/image/BufferedImage;
   method setupTexture matches a (Ljava/awt/image/BufferedImage;I)V
   method getTexture matches b (Ljava/lang/String;)I
   method getImageRGB matches a (Ljava/awt/image/BufferedImage;[i)[i
   method readTextureImageData matches a (Ljava/lang/String;)[i
  TextureFX (tt.class)
   field imageData matches f [b
   field tileNumber matches g I
   field tileSize matches j I
   field tileImage matches k I
   method bindImage matches a (Laaw;)V
  Compass (tu.class)
  Fire (nh.class)
  StillLava (bv.class)
  FlowLava (gf.class)
  StillWater (qa.class)
  FlowWater (ael.class)
  ItemRenderer (mn.class)
  Watch (ht.class)
  Portal (zp.class)
  Minecraft (net/minecraft/client/Minecraft.class)
   field renderEngine matches p Laaw;
  GLAllocation (ew.class)
  ColorizerWater (zt.class)
   field colorBuffer matches a [i
  ColorizerGrass (zv.class)
   field colorBuffer matches a [i
  ColorizerFoliage (gu.class)
   field colorBuffer matches a [i
  Minecraft (net/minecraft/client/Minecraft.class)
   field fontRenderer matches q Lnl;
   field alternateFontRenderer matches r Lnl;
   field renderEngine matches p Laaw;
   field gameSettings matches A Lhu;
  FontRenderer (nl.class)
   method getStringWidth matches a (Ljava/lang/String;)I
   method getCharWidth matches a (C)I
  RenderEngine (aaw.class)
  GameSettings (hu.class)
  Material (acn.class)
   field ground matches b Lacn;
  Block (pb.class)
   field blockID matches bO I
   field blocksList matches m [Lpb;
   method getBlockTexture matches d (Lali;IIII)I
  BlockGrass (qy.class)
  BlockMycelium (alr.class)
  IBlockAccess (ali.class)
   method getBlockId matches a (III)I
   method getBlockMetadata matches e (III)I
   method getBlockMaterial matches f (III)Lacn;
  RenderBlocks (vl.class)
   field blockAccess matches a Lali;
  RenderLiving (fe.class)
  RenderSpider (amo.class)
  RenderEnderman (st.class)
  Entity (nn.class)
   field entityId matches f I
   field nextEntityID matches a I
  EntityLiving (acq.class)
   method getEntityTexture matches v_ ()Ljava/lang/String;
   method writeToNBT matches b (Lady;)V
   method readFromNBT matches a (Lady;)V
  NBTTagCompound (ady.class)
   method getLong matches g (Ljava/lang/String;)J
   method setLong matches a (Ljava/lang/String;J)V
   method getInteger matches f (Ljava/lang/String;)I
   method setInteger matches a (Ljava/lang/String;I)V
  Tessellator (adz.class)
   field instance matches a Ladz;
  Render (um.class)
   method loadTexture matches a (Ljava/lang/String;)V
  RenderSnowman (afm.class)
  RenderMooshroom (cl.class)
  Minecraft (net/minecraft/client/Minecraft.class)
   field theWorld matches f Lxd;
  IBlockAccess (ali.class)
   method getBlockId matches a (III)I
   method getBlockMetadata matches e (III)I
   method getBiomeGenAt matches a (II)Labn;
  Block (pb.class)
   field blockID matches bO I
   field blocksList matches m [Lpb;
  BiomeGenBase (abn.class)
   method getGrassColor matches k ()I
   method getFoliageColor matches l ()I
   field color matches z I
  BiomeGenSwamp (ahs.class)
  BlockFluid (agv.class)
  BlockCauldron (xm.class)
  Item (yr.class)
  ItemBlock (vd.class)
   field blockID matches a I
  ItemRenderer (mn.class)
  Potion (aad.class)
  PotionHelper (hx.class)
  ColorizerFoliage (gu.class)
  BlockLeaves (uf.class)
  World (.class)
   method getWorldChunkManager matches i ()Lrs;
  WorldProvider (alb.class)
  WorldProviderHell (akf.class)
  WorldProviderEnd (ii.class)
  WorldChunkManager (rs.class)
   method getBiomeGenAt matches a (II)Labn;
  Entity (nn.class)
   field worldObj matches k Lxd;
  EntityFX (rt.class)
  EntityRainFX (rg.class)
  EntityDropParticleFX (ga.class)
  EntitySplashFX (nw.class)
  EntityBubbleFX (vg.class)
  EntitySuspendFX (ky.class)
  EntityPortalFX (aep.class)
  EntityAuraFX (xy.class)
  EntityLiving (acq.class)
  EntityRenderer (lr.class)
  BlockLilyPad (ye.class)
  BlockRedstoneWire (ahi.class)
  RenderBlocks (vl.class)
   method renderBlockCauldron matches a (Lxm;III)Z
  EntityReddustFX (aab.class)
  RenderGlobal (l.class)
  BlockStem (aei.class)
  MapColor (wh.class)
   field mapColorArray matches a [Lwh;
   field colorValue matches p I
   field colorIndex matches q I
  ItemDye (hm.class)
   field dyeColorNames matches a [Ljava/lang/String;
   field dyeColors matches b [i
  EntitySheep (cu.class)
   field fleeceColorTable matches a [[F
  EntityList (aao.class)
   method addMapping matches a (Ljava/lang/Class;Ljava/lang/String;III)V
  ItemSpawnerEgg (acv.class)
  FontRenderer (nl.class)
  TileEntitySignRenderer (ll.class)
  RenderXPOrb (tb.class)
  Minecraft (net/minecraft/client/Minecraft.class)
   field renderEngine matches p Laaw;
  RenderEngine (aaw.class)
   method getTexture matches b (Ljava/lang/String;)I
   method allocateAndSetupTexture matches a (Ljava/awt/image/BufferedImage;)I
  IBlockAccess (ali.class)
   method getBlockId matches a (III)I
   method getBlockMetadata matches e (III)I
  Block (pb.class)
   field blockID matches bO I
   field blocksList matches m [Lpb;
  Tessellator (adz.class)
   field instance matches a Ladz;
   field instance matches a Ladz;
  RenderBlocks (vl.class)
   field blockAccess matches a Lali;
   method renderBottomFace matches a (Lpb;DDDI)V
   method renderTopFace matches b (Lpb;DDDI)V
   method renderNorthFace matches c (Lpb;DDDI)V
   method renderSouthFace matches d (Lpb;DDDI)V
   method renderWestFace matches e (Lpb;DDDI)V
   method renderEastFace matches f (Lpb;DDDI)V
   method drawCrossedSquares matches a (Lpb;IDDD)V
  WorldRenderer (ct.class)
  Minecraft (net/minecraft/client/Minecraft.class)
   field theWorld matches f Lxd;
  World (.class)
   method getWorldTime matches w ()J
  RenderGlobal (l.class)

28 available mods:
[YES] minecraftforge-client-3.3.7.135  - 284 files to add or replace.
[YES] FMLPatch  - 1 file to add or replace.
[YES] SinglePlayerCommands-MC1.2.5_v3.2.2  - 26 files to add or replace.
[YES] WorldEditCUI-1.2  - 716 files to add or replace.
[YES] CodeChickenCore-Client 0.5.2  - 26 files to add or replace.
[YES] NotEnoughItems-Client 1.2.2  - 104 files to add or replace.
[YES] NEI_RedPowerPlugin 1.2.2  - 10 files to add or replace.
[YES] More Stackables  - 1 file to add or replace.
[YES] [1.2.5]ReiMinimap_v3.1  - 64 files to add or replace.
[YES] [1.2.5] Somnia v24  - 8 files to add or replace.
[YES] OptiFine_1.2.5_HD_A6  - 38 files to add or replace.
[YES] CustomOreGen.[1.2.5]v5.Client  - 33 files to add or replace.
[YES] NoSwissCheese.1.2.5.Client  - 1 file to add or replace.
[YES] UnbreakableBoats.1.2.5.Client  - 1 file to add or replace.
[YES] NoCollisionLilyPads.1.2.5.Client  - 1 file to add or replace.
[YES] millenaire2.7.3  - 408 files to add or replace.
[YES] RedPower-2.0pr5b2  - 397 files to add or replace.
[YES] Redpower-2.0pr5b2-JRoushHacks  - 3 files to add or replace.
[YES] ThaumCraft2.1.6  - 601 files to add or replace.
[YES] Thaumcraft.2.1.6-JRoushHacks  - 8 files to add or replace.
[YES] InvTweaks-1.41b-1.2.4  - 56 files to add or replace.
[YES] __Base 1.0 - Internal mod required by the patcher.
[YES] __TexturePackBase 1.0 - Internal mod required by the patcher.
[YES] HD Textures 1.4 - Provides support for high-resolution texture packs and custom animations.
[YES] HD Font 1.4 - Provides support for higher resolution fonts.
[YES] Better Grass 1.0 - Improves the look of the sides of grass blocks. Inspired by MrMessiah's mod.
[YES] Random Mobs 1.3 - Randomize mob skins if texture pack supports it. Based on Balthichou's mod.
[YES] Custom Colors 1.4 - Gives texture packs control over hardcoded colors in the game.
[YES] Connected Textures 1.4 - Connects adjacent blocks of the same type.
[YES] Better Skies 1.1 - Adds support for custom skyboxes.

Launching C:\Users\John\AppData\Roaming\.minecraft\bin\minecraft.jar
java -cp C:\Users\John\AppData\Roaming\.minecraft\bin/minecraft.jar;C:\Users\John\AppData\Roaming\.minecraft\bin/lwjgl.jar;C:\Users\John\AppData\Roaming\.minecraft\bin/lwjgl_util.jar;C:\Users\John\AppData\Roaming\.minecraft\bin/jinput.jar; -Djava.library.path=C:\Users\John\AppData\Roaming\.minecraft\bin\natives -Xmx1024M -Xms512M net.minecraft.client.Minecraft
MCPatcherUtils initialized. Directory C:\Users\John\AppData\Roaming\.minecraft\.
27 achievements
182 recipes
LWJGL Version: 2.4.2
Aug 22, 2012 9:24:39 PM cpw.mods.fml.common.FMLCommonHandler beginLoading
INFO: Attempting early MinecraftForge initialization
Aug 22, 2012 9:24:39 PM cpw.mods.fml.common.FMLCommonHandler beginLoading
INFO: Completed early MinecraftForge initialization
2012-08-22 21:24:39 [iNFO] Forge Mod Loader version 2.2.48.135 for Minecraft 1.2.5 loading
2012-08-22 21:24:39 [WARNING] Failed to load mod class mod_MinecraftForge.class in C:\Users\John\AppData\Roaming\.minecraft\MCP\bin\minecraft\net\minecraft\src
2012-08-22 21:24:39 [sEVERE] File mod_MinecraftForge.class failed to read properly
2012-08-22 21:24:39 [WARNING] Failed to load mod class mod_MinecraftForge.class in C:\Users\John\AppData\Roaming\.minecraft\MCP\bin\minecraft_server\net\minecraft\src
2012-08-22 21:24:39 [sEVERE] File mod_MinecraftForge.class failed to read properly
2012-08-22 21:24:39 [WARNING] Failed to load mod class mod_MinecraftForge.class in C:\Users\John\AppData\Roaming\.minecraft\MCP\custom\temp\bin\minecraft\net\minecraft\src
2012-08-22 21:24:39 [sEVERE] File mod_MinecraftForge.class failed to read properly
2012-08-22 21:24:39 [WARNING] Failed to load mod class mod_ThaumCraft.class in C:\Users\John\AppData\Roaming\.minecraft\MCP\custom\temp\bin\minecraft\net\minecraft\src
2012-08-22 21:24:39 [sEVERE] File mod_ThaumCraft.class failed to read properly
2012-08-22 21:24:39 [WARNING] Failed to load mod class mod_MinecraftForge.class in C:\Users\John\AppData\Roaming\.minecraft\MCP\custom\temp\cls\minecraft\net\minecraft\src
2012-08-22 21:24:39 [sEVERE] File mod_MinecraftForge.class failed to read properly
2012-08-22 21:24:39 [WARNING] Failed to load mod class mod_ThaumCraft.class in C:\Users\John\AppData\Roaming\.minecraft\MCP\custom\temp\cls\minecraft\net\minecraft\src
2012-08-22 21:24:39 [sEVERE] File mod_ThaumCraft.class failed to read properly
2012-08-22 21:24:40 [WARNING] Failed to load mod class mod_MinecraftForge.class in C:\Users\John\AppData\Roaming\.minecraft\MCP\eclipse\Client\bin\net\minecraft\src
2012-08-22 21:24:40 [sEVERE] File mod_MinecraftForge.class failed to read properly
2012-08-22 21:24:40 [WARNING] Failed to load mod class mod_CustomOreGen.class in C:\Users\John\AppData\Roaming\.minecraft\MCP\eclipse\Server\bin\net\minecraft\src
2012-08-22 21:24:40 [sEVERE] File mod_CustomOreGen.class failed to read properly
2012-08-22 21:24:40 [WARNING] Failed to load mod class mod_MinecraftForge.class in C:\Users\John\AppData\Roaming\.minecraft\MCP\eclipse\Server\bin\net\minecraft\src
2012-08-22 21:24:40 [sEVERE] File mod_MinecraftForge.class failed to read properly
2012-08-22 21:24:41 [iNFO] Loading mods from C:\Users\John\AppData\Roaming\.minecraft\mods
2012-08-22 21:24:41 [iNFO] Directory 1.2.5 contained no mods
2012-08-22 21:24:41 [iNFO] Directory rei_minimap contained no mods
2012-08-22 21:24:41 [iNFO] Directory sppcommands contained no mods
2012-08-22 21:24:41 [iNFO] Directory WorldEditCUI contained no mods
2012-08-22 21:24:41 [sEVERE] A problem has occured during mod loading. Likely a corrupt jar is located in your mods directory
cpw.mods.fml.common.LoaderException: cpw.mods.fml.common.LoaderException: java.lang.NoClassDefFoundError: MCP/eclipse/Server/bin/net/minecraft/src/mod_MinecraftForge (wrong name: net/minecraft/src/mod_MinecraftForge)
    at cpw.mods.fml.common.Loader.load(Loader.java:436)
    at cpw.mods.fml.common.Loader.loadMods(Loader.java:592)
    at cpw.mods.fml.client.FMLClientHandler.onPreLoad(FMLClientHandler.java:193)
    at net.minecraft.client.Minecraft.a(Minecraft.java:383)
    at net.minecraft.client.Minecraft.run(Minecraft.java:735)
    at java.lang.Thread.run(Unknown Source)
Caused by: cpw.mods.fml.common.LoaderException: java.lang.NoClassDefFoundError: MCP/eclipse/Server/bin/net/minecraft/src/mod_MinecraftForge (wrong name: net/minecraft/src/mod_MinecraftForge)
    at cpw.mods.fml.common.Loader.loadModClass(Loader.java:527)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:474)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.load(Loader.java:385)
    ... 5 more
Caused by: java.lang.NoClassDefFoundError: MCP/eclipse/Server/bin/net/minecraft/src/mod_MinecraftForge (wrong name: net/minecraft/src/mod_MinecraftForge)
    at java.lang.ClassLoader.defineClass1(Native Method)
    at java.lang.ClassLoader.defineClass(Unknown Source)
    at java.security.SecureClassLoader.defineClass(Unknown Source)
    at java.net.URLClassLoader.defineClass(Unknown Source)
    at java.net.URLClassLoader.access$100(Unknown Source)
    at java.net.URLClassLoader$1.run(Unknown Source)
    at java.net.URLClassLoader$1.run(Unknown Source)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at java.lang.Class.forName0(Native Method)
    at java.lang.Class.forName(Unknown Source)
    at cpw.mods.fml.common.Loader.loadModClass(Loader.java:494)
    ... 14 more
2012-08-22 21:24:41 [sEVERE] A critical error has occurred.
cpw.mods.fml.common.LoaderException: cpw.mods.fml.common.LoaderException: java.lang.NoClassDefFoundError: MCP/eclipse/Server/bin/net/minecraft/src/mod_MinecraftForge (wrong name: net/minecraft/src/mod_MinecraftForge)
    at cpw.mods.fml.common.Loader.load(Loader.java:436)
    at cpw.mods.fml.common.Loader.loadMods(Loader.java:592)
    at cpw.mods.fml.client.FMLClientHandler.onPreLoad(FMLClientHandler.java:193)
    at net.minecraft.client.Minecraft.a(Minecraft.java:383)
    at net.minecraft.client.Minecraft.run(Minecraft.java:735)
    at java.lang.Thread.run(Unknown Source)
Caused by: cpw.mods.fml.common.LoaderException: java.lang.NoClassDefFoundError: MCP/eclipse/Server/bin/net/minecraft/src/mod_MinecraftForge (wrong name: net/minecraft/src/mod_MinecraftForge)
    at cpw.mods.fml.common.Loader.loadModClass(Loader.java:527)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:474)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.attemptDirLoad(Loader.java:463)
    at cpw.mods.fml.common.Loader.load(Loader.java:385)
    ... 5 more
Caused by: java.lang.NoClassDefFoundError: MCP/eclipse/Server/bin/net/minecraft/src/mod_MinecraftForge (wrong name: net/minecraft/src/mod_MinecraftForge)
    at java.lang.ClassLoader.defineClass1(Native Method)
    at java.lang.ClassLoader.defineClass(Unknown Source)
    at java.security.SecureClassLoader.defineClass(Unknown Source)
    at java.net.URLClassLoader.defineClass(Unknown Source)
    at java.net.URLClassLoader.access$100(Unknown Source)
    at java.net.URLClassLoader$1.run(Unknown Source)
    at java.net.URLClassLoader$1.run(Unknown Source)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)
    at java.lang.Class.forName0(Native Method)
    at java.lang.Class.forName(Unknown Source)
    at cpw.mods.fml.common.Loader.loadModClass(Loader.java:494)
    ... 14 more
2012-08-22 21:24:41 [sEVERE] 1 mod loaded
Minecraft Forge 3.3.7.135
FML v2.2.48.135
Forge Mod Loader version 2.2.48.135 for Minecraft 1.2.5
    mod_MinecraftForge : Loaded (minecraft.jar)

 

[LexManos]

This is nothing to do with the other thread, the other thread states that he is adding things specifically to the mods folder, that he does not want to be loaded as a mod. I think we can all agree that's fucking moronic.

 

Now, onto your issue. This does indeed seem odd, it stems from, as you say, MCPatcher adding the root minecraft folder to the classpath. For what reason we do not know. However, I've made cpw aware of this and he is taking a look into what needs to be done to play nicer together. From my understanding the full classpath walk was designed so that modders could debug there mods easily in MCP. And in any package/folder they wished. Being limited to just "<MinecraftHome>/mods" would cause issues on that front.

 

So ya, cpw is working on it.

[JRoush]

I know that MCPatcher asks you to store mod packages in a subfolder of .minecraft/mods by default, since the original ModLoader only checked the top level.  It's not a good idea, obviously, but I guess that would explain the other thread.

 

I've gotten around the problem by using MultiMC for the time being.  I never had any problems developing pure Modloader mods with MCP/Eclipse, so the somewhat ugly loading strategy that Risugami used apparently worked pretty well.  That said, I will leave it to cpw to figure out the best overall solution.  Thanks for passing the message on to him.

 

[LexManos]

mm, ModLoader limits you to just the net.minecraft.src package for mods when developing, which is unacceptable. Hence the searching along the entire classpath. However, we'll see if something can be done to clean up excessive searching. Wouldn't be an issue if MCPatcher didn't add the root for no reason