Item id check not working with custom item

[Toblexson]

I am making a block which holds music disks or my own special item. The music disks can be placed inside the inventory but my item cannot. Here is the 'isItemValidForSlot' method for the tile entity:

@Override
public boolean isItemValidForSlot(int i, ItemStack itemstack) {
	return itemstack.itemID == soundcontrol.item.ItemInfo.DISKSLEEVE_ID || itemstack.itemID == Item.record11.itemID || itemstack.itemID == Item.record13.itemID || itemstack.itemID == Item.record13.itemID || itemstack.itemID == Item.recordBlocks.itemID || itemstack.itemID == Item.recordCat.itemID || itemstack.itemID == Item.recordChirp.itemID || itemstack.itemID == Item.recordFar.itemID || itemstack.itemID == Item.recordMall.itemID || itemstack.itemID == Item.recordMellohi.itemID || itemstack.itemID == Item.recordStal.itemID || itemstack.itemID == Item.recordStrad.itemID || itemstack.itemID == Item.recordWait.itemID || itemstack.itemID == Item.recordWard.itemID;
}

 

The first option, for the disksleeve item, is the one I am having trouble with. The code for the slot which is used in the container/inventory is identical.

 

Please help because I cannot think of what could be wrong.

 

 

[GotoLink]

Use your item instance item id, not some random number.

[Toblexson]

Sorry, I am new to modding, but what is the item instance item id and how would I use it?

[Draco18s]

  On 1/2/2014 at 11:39 AM, Toblexson said:

Sorry, I am new to modding, but what is the item instance item id and how would I use it?

 

Items are singletons and inherit from the class Item.

Classes have instances called instance objects.

itemID is a non-static public property of the Item class.

[Toblexson]

  On 1/2/2014 at 1:27 PM, Draco18s said:

  Quote

Sorry, I am new to modding, but what is the item instance item id and how would I use it?

 

Items are singletons and inherit from the class Item.

Classes have instances called instance objects.

itemID is a non-static public property of the Item class.

 

Thanks

I think I get what you mean, I needed to reference the item where I have initialised it rather than the actual class. I've done this and now it works.

@Override
public boolean isItemValid(ItemStack itemstack) {
	return itemstack.itemID == Items.disksleeve.itemID || itemstack.itemID == Item.record11.itemID || itemstack.itemID == Item.record13.itemID || itemstack.itemID == Item.record13.itemID || itemstack.itemID == Item.recordBlocks.itemID || itemstack.itemID == Item.recordCat.itemID || itemstack.itemID == Item.recordChirp.itemID || itemstack.itemID == Item.recordFar.itemID || itemstack.itemID == Item.recordMall.itemID || itemstack.itemID == Item.recordMellohi.itemID || itemstack.itemID == Item.recordStal.itemID || itemstack.itemID == Item.recordStrad.itemID || itemstack.itemID == Item.recordWait.itemID || itemstack.itemID == Item.recordWard.itemID; 
}

[Draco18s]

You can also check for item equivalence.

 

itemstack.getItem() == Items.disksleeve

 

For instance.  Which is how things will work come 1.7