[SOLVED][1.6.4]Helmet that adds Infinity to Items Help

[Clawx207]

As the title says, i am trying to make this item. Here's my current code for it:

 

 

public void onArmorTickUpdate(World world, EntityPlayer player, ItemStack item)

{

        if (player.getCurrentItemOrArmor(4) != null)

        {

            ItemStack helmet = player.getCurrentItemOrArmor(4);

            if (helmet.getItem() == this)

            {

            if(player.getCurrentEquippedItem().getItem() instanceof ItemBow)

            {

                player.getCurrentEquippedItem().addEnchantment(Enchantment.infinity, 1);

            }

            }

        }

}

 

 

It "Kind of works". As it keeps enchanting the bow to the point where it looks like this then crashes:

 

infinity I

infinity I

infinity I

infinity I

infinity I

infinity I

infinity I

 

 

How would i make it so it only enchants the item once?

 

 

 

[larsgerrits]

if(!player.getCurrentEquippedItem().hasEnchantment(Enchantment.infinity, 1))
{
     player.getCurrentEquippedItem().addEnchantment(Enchantment.infinity, 1);
}

[Draco18s]

You will also need to find a way to remove the enchantment when they're no longer holding it.

[Clawx207]

if(!player.getCurrentEquippedItem().hasEnchantment(Enchantment.infinity, 1))
{
     player.getCurrentEquippedItem().addEnchantment(Enchantment.infinity, 1);
}

 

.hasEnchantment does not exist...?

 

 

Edit:

 

Ahhh but this works:

 

if(!player.getCurrentEquippedItem().hasEffect(Enchantment.infinity.effectId))

 

 

[Draco18s]

Also:

 

You will also need to find a way to remove the enchantment when they're no longer holding it.

 

Tip:

There are multiple ways to get rid of an item so it's no longer your active one.

Tip #2:

One of them involves Item Frames.  An item that goes into a frame ceases to exist with no function calls or events.  So unless your plan is to let the player have infinite* free infinity bows, this is an idea that is doomed to failure.

Tip #3:

The helmet no longer being worn / ceasing to exist will also need to be covered.

 

*Pun not intended, but enjoyed.  And only "inifinite-until-helmet-breaks" of course.

[Clawx207]

I will work on that next, but right now every time i wear the helmet and hold a bow i get this crash:

 

 

2014-01-20 23:07:43 [iNFO] [sTDOUT] Description: Ticking player

2014-01-20 23:07:43 [iNFO] [sTDOUT]

2014-01-20 23:07:43 [iNFO] [sTDOUT] java.lang.NullPointerException

2014-01-20 23:07:43 [iNFO] [sTDOUT] at MGM.InfBandana.onArmorTickUpdate(InfBandana.java:35)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.entity.player.InventoryPlayer.decrementAnimations(InventoryPlayer.java:367)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.entity.player.EntityPlayer.onLivingUpdate(EntityPlayer.java:606)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.entity.EntityLivingBase.onUpdate(EntityLivingBase.java:1826)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.entity.player.EntityPlayer.onUpdate(EntityPlayer.java:342)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.entity.player.EntityPlayerMP.onUpdateEntity(EntityPlayerMP.java:328)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.network.NetServerHandler.handleFlying(NetServerHandler.java:304)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.network.packet.Packet10Flying.processPacket(Packet10Flying.java:51)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.network.MemoryConnection.processReadPackets(MemoryConnection.java:89)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.network.NetServerHandler.networkTick(NetServerHandler.java:141)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.network.NetworkListenThread.networkTick(NetworkListenThread.java:54)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.server.integrated.IntegratedServerListenThread.networkTick(IntegratedServerListenThread.java:109)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:691)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:587)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:129)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:484)

2014-01-20 23:07:43 [iNFO] [sTDOUT] at net.minecraft.server.ThreadMinecraftServer.run(ThreadMinecraftServer.java:16)

 

 

This is my updated code:

 

 

public void onArmorTickUpdate(World world, EntityPlayer player, ItemStack item)

{

int i;

        if (player.getCurrentItemOrArmor(4) != null)

        {

            ItemStack helmet = player.getCurrentItemOrArmor(4);

            if (helmet.getItem() == this)

            {

            if(player.getCurrentEquippedItem().getItem() instanceof ItemBow)

            {

            if(!player.getCurrentEquippedItem().hasEffect(Enchantment.infinity.effectId))

            {

                player.getCurrentEquippedItem().addEnchantment(Enchantment.infinity, 1);

            }

            }

            }

        }

}

 

 

"if(player.getCurrentEquippedItem().getItem() instanceof ItemBow)" is the line of code it is having issues with

[Clawx207]

Haha! One up to you good sir!

 

Changed some things around here's what i'm going with for right now!

 

 

public void onArmorTickUpdate(World world, EntityPlayer player, ItemStack item)

{

ItemStack itemstack = player.getCurrentEquippedItem();

 

        if (player.getCurrentItemOrArmor(4) != null)

        {

            ItemStack helmet = player.getCurrentItemOrArmor(4);

            if (helmet.getItem() == this)

            {

            if(itemstack != null && itemstack.itemID == Item.bow.itemID)

            {

            if(!itemstack.hasEffect(Enchantment.infinity.effectId))

            {

            itemstack.addEnchantment(Enchantment.infinity, 1);

            }

            }

            }

        }

}

 

 

Thank you guys! Much more responsive than the minecraft forums!