How might I toggle off my night vision when the player unequips my helm? I've currently got a keybind that only toggles the night vision on and off when the helmet is equipped but when the player unequips the helm the night vision stays toggled on, which could be used as an exploit

 

Anyway, here's the code I'm using in the helmet class:

 

private float regBrightness;
public boolean nightVisionToggle;

@Override
public void onArmorTickUpdate(World world, EntityPlayer player, ItemStack itemStack) {
	if(player.getCurrentItemOrArmor(4) !=null) {
		ItemStack helmet = player.getCurrentItemOrArmor(4);

		if(helmet.getItem() == RoboEye.diamondEyeHelm && VisionKeyBind.keyPressed) {
			nightVisionToggle = !nightVisionToggle;
			this.mc.sndManager.playSoundFX("random.click", 1.0F, 1.0F);
			VisionKeyBind.keyPressed = false;
			if (nightVisionToggle) {
				regBrightness = mc.gameSettings.gammaSetting;
				mc.gameSettings.gammaSetting = 1500.0F;
			} else if (!nightVisionToggle) {
				mc.gameSettings.gammaSetting = regBrightness;
			}
		}
	}
}

 

 

And here's the relevant part of my keybind handler:

 

 

public boolean keyHasBeenPressed = false;
public static boolean keyPressed = false;

@Override
    public void keyDown(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd, boolean isRepeat)
    {
        keyHasBeenPressed = true;
    }
    @Override
    public void keyUp(EnumSet<TickType> types, KeyBinding kb, boolean tickEnd)
    {
            if (keyHasBeenPressed) {
            	keyHasBeenPressed = false;
            	keyPressed = true;
            }

 

onUpdate is called for ALL inventory items.

onEntityItemUpdate is called for dropped items.

 

You'll need to use both to insure that the effect is removed.

Hey draco, thanks for your reply. I think what you're referencing is if the item itself has an effect if I'm not mistaken. However, I've got a night vision mode that is only toggle-able when the helmet is equipped. What I had in mind was when the player takes off the helmet the toggle is turned off as well. If this is what you were pointing me to, please explain just a tad so I can get this sucker exploit free

 

Cheers!

Robosphinx

When the helmet comes off, the player can only do one of two things with it:

a) add it to their regular inventory

b) drop it on the ground

 

If they add it to their regular inventory, the item will receive an onUpdate call every tick.

If they drop it on the ground, the item will receive an onEntityItemUpdate call every tick (or so; I have a vague recollection that it was more like once every 4, but you only need a once-off so it doesn't matter).

Worst key handler ever. It doesn't do anything.

 

Move the night vision code into the key handler. Check that the player is wearing the helmet before doing anything.

Eventually send packets if effect should be server side.

Works perfectly for what I need it to do, thanks. Draco, I feel like a noob now you say that, overrode those functions and everything works perfectly now.

 

Here's what I did in the codemabobs:

@Override
public void onUpdate(ItemStack par1ItemStack, World par2World, Entity par3Entity, int par4, boolean par5){
	nightVisionToggle = false;
	VisionKeyBind.keyPressed = false;
	mc.gameSettings.gammaSetting = regBrightness;		
}

@Override
public boolean onEntityItemUpdate(EntityItem entityItem){
	nightVisionToggle = false;
	VisionKeyBind.keyPressed = false;
	mc.gameSettings.gammaSetting = regBrightness;
	return false;
}