Busti Posted March 17, 2014 Posted March 17, 2014 Hello, I tried to add an ore to the world gen and I followed the common tutorials. I tried to add some structure to it to make it easier, but somehow it isn't working: Registration: public static void Init() { //Generators OreGen oreGen = new OreGen(); oreGen.addOre(block_CopperOre, 10); GameRegistry.registerWorldGenerator(oreGen, 500); } Gen Class: /* * Copyright (c) 2013-2014 Busti2000. * * Technica is distributed under the terms of the Minecraft Mod Public * License 1.0, or MMPL. Please check the contents of the license located in * http://www.mod-buildcraft.com/MMPL-1.0.txt */ package mlb.technica.core.world; import cpw.mods.fml.common.IWorldGenerator; import net.minecraft.block.Block; import net.minecraft.world.World; import net.minecraft.world.chunk.IChunkProvider; import net.minecraft.world.gen.feature.WorldGenMinable; import net.minecraft.world.gen.feature.WorldGenerator; import net.minecraftforge.event.terraingen.OreGenEvent; import net.minecraftforge.event.terraingen.TerrainGen; import java.util.ArrayList; import java.util.Iterator; import java.util.List; import java.util.Random; public class OreGen implements IWorldGenerator{ private final List<WorldGenMinable> oreGenList = new ArrayList<WorldGenMinable>(); public void addOre(Block block, int number) { oreGenList.add(new WorldGenMinable(block, number)); } public void genStandardOre(int count, World world, WorldGenerator worldGen, Random random, int chunkX, int chunkZ, int min, int max) { for (int i = 0; i < count; i++) { int x = chunkX + random.nextInt(16); int y = random.nextInt(max - min) + min; int z = chunkZ + random.nextInt(16); worldGen.generate(world, random, x, y, z); } } @Override public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) { Iterator<WorldGenMinable> iter = oreGenList.iterator(); while(iter.hasNext()) { WorldGenMinable ore = iter.next(); if (TerrainGen.generateOre(world, random, ore, chunkX, chunkZ, OreGenEvent.GenerateMinable.EventType.CUSTOM)) genStandardOre(20, world, ore, random, chunkX, chunkZ, 0, 96); } } } Quote PM's regarding modding questions should belong in the Modder Support sub-forum and won't be answered.
Aspect Posted March 17, 2014 Posted March 17, 2014 I also have this problem, my ore and trees wont generate at all. My code is very similar to yours, I also register my World Generators under the FMLIntializationEvent, I'm guessing you're doing something similar? Quote
Busti Posted March 17, 2014 Author Posted March 17, 2014 Yes I am. The generate method gets called but nothing generates. It also takes a very long time but i cant imagine where the delay comes from. Quote PM's regarding modding questions should belong in the Modder Support sub-forum and won't be answered.
Busti Posted March 17, 2014 Author Posted March 17, 2014 When I do it with my blocks each chunk takes about 10 seconds more to generate but when I do it with a Vanilla block it doesn't. Even though nothing is really generating Quote PM's regarding modding questions should belong in the Modder Support sub-forum and won't be answered.
TLHPoE Posted March 18, 2014 Posted March 18, 2014 You need to multiply chunkX and chunkZ by 16 before passing it on to the other generate methods. Quote Kain
sequituri Posted March 18, 2014 Posted March 18, 2014 Change this: genStandardOre(20, world, ore, random, chunkX, chunkZ, 0, 96); to this: genStandardOre(20, world, ore, random, chunkX*16, chunkZ*16, 0, 96); Quote -S- (if I helped, please click Thank and applaud) http://6upnqa.dm2301.livefilestore.com/y2mtf-vG7Tqq1TiiVpIm53KWj7294NDPoHfSHHb4PzZiMAUfRCfK0UY0MwOu7Q3zTBNVTKqWjr2-xgBfFRpQT5p-QivtvknPpoABMNUw9br9WuZcBFkjePhnAbW500gVm-P/sequiturian.png[/img]
Jwosty Posted March 18, 2014 Posted March 18, 2014 *ahem* bitshift *ahem* Quote I like to make mods, just like you. Here's one worth checking out
sequituri Posted March 19, 2014 Posted March 19, 2014 The multiply will automagically get implemented by a <<4 in the JVM optimizer (Bytecode compiler), no need to fret. Same as divide by constant power of 2. Quote -S- (if I helped, please click Thank and applaud) http://6upnqa.dm2301.livefilestore.com/y2mtf-vG7Tqq1TiiVpIm53KWj7294NDPoHfSHHb4PzZiMAUfRCfK0UY0MwOu7Q3zTBNVTKqWjr2-xgBfFRpQT5p-QivtvknPpoABMNUw9br9WuZcBFkjePhnAbW500gVm-P/sequiturian.png[/img]
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.