Jump to content

Ore not generating...


Recommended Posts


I tried to add an ore to the world gen and I followed the common tutorials. I tried to add some structure to it to make it easier, but somehow it isn't working:


public static void Init() {
        OreGen oreGen = new OreGen();
        oreGen.addOre(block_CopperOre, 10);
        GameRegistry.registerWorldGenerator(oreGen, 500);


Gen Class:

* Copyright (c) 2013-2014 Busti2000.
* Technica is distributed under the terms of the Minecraft Mod Public
* License 1.0, or MMPL. Please check the contents of the license located in
* http://www.mod-buildcraft.com/MMPL-1.0.txt

package mlb.technica.core.world;

import cpw.mods.fml.common.IWorldGenerator;
import net.minecraft.block.Block;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.event.terraingen.OreGenEvent;
import net.minecraftforge.event.terraingen.TerrainGen;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.Random;

public class OreGen implements IWorldGenerator{

    private final List<WorldGenMinable> oreGenList = new ArrayList<WorldGenMinable>();

    public void addOre(Block block, int number) {
        oreGenList.add(new WorldGenMinable(block, number));

    public void genStandardOre(int count, World world, WorldGenerator worldGen, Random random, int chunkX, int chunkZ, int min, int max) {
        for (int i = 0; i < count; i++) {
            int x = chunkX + random.nextInt(16);
            int y = random.nextInt(max - min) + min;
            int z = chunkZ + random.nextInt(16);
            worldGen.generate(world, random, x, y, z);

    public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {
        Iterator<WorldGenMinable> iter = oreGenList.iterator();
        while(iter.hasNext()) {
            WorldGenMinable ore = iter.next();
            if (TerrainGen.generateOre(world, random, ore, chunkX, chunkZ, OreGenEvent.GenerateMinable.EventType.CUSTOM))
                genStandardOre(20, world, ore, random, chunkX, chunkZ, 0, 96);

PM's regarding modding questions should belong in the Modder Support sub-forum and won't be answered.

Link to comment
Share on other sites

Change this:

    genStandardOre(20, world, ore, random, chunkX, chunkZ, 0, 96);

to this:

    genStandardOre(20, world, ore, random, chunkX*16, chunkZ*16, 0, 96);

Link to comment
Share on other sites

The multiply will automagically get implemented by a <<4 in the JVM optimizer (Bytecode compiler), no need to fret. Same as divide by constant power of 2.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...

Important Information

By using this site, you agree to our Terms of Use.