Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.7.2]World Generation Not Working


Recommended Posts

You have to multiply the chunkX and chunkZ by 16. Or just use my class:

Then just use the addOre method in your Registry...

 

import cpw.mods.fml.common.IWorldGenerator;
import net.minecraft.block.Block;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.event.terraingen.OreGenEvent;
import net.minecraftforge.event.terraingen.TerrainGen;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.Random;

public class OreGen implements IWorldGenerator{

    private class OreData {
        protected final WorldGenMinable oreGen;
        protected final int min;
        protected final int max;
        protected final int count;

        protected OreData(WorldGenMinable ore, int minHeight, int maxHeight, int clusterCount) {
            oreGen = ore;
            min = minHeight;
            max = maxHeight;
            count = clusterCount;
        }
    }

    private final List<OreData> oreGenList = new ArrayList<OreData>();

    public void addOre(Block block, int size, int minHeight, int maxHeight, int clusterCount) {
        OreData data = new OreData(new WorldGenMinable(block, size), minHeight, maxHeight, clusterCount);
        oreGenList.add(data);
    }

    public void addOre(Block block, int size) {
        OreData data = new OreData(new WorldGenMinable(block, size), 0, 64, 20);
        oreGenList.add(data);
    }

    public void addOre(Block block) {
        OreData data = new OreData(new WorldGenMinable(block, , 0, 64, 20);
        oreGenList.add(data);
    }

    public void genStandardOre(int count, World world, WorldGenerator worldGen, Random rand, int chunkX, int chunkZ, int min, int max) {
        for (int i = 0; i < count; i++) {
            int x = chunkX + rand.nextInt(16);
            int y = rand.nextInt(max - min) + min;
            int z = chunkZ + rand.nextInt(16);
            worldGen.generate(world, rand, x, y, z);
        }
    }

    @Override
    public void generate(Random rand, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {
        Iterator<OreData> iter = oreGenList.iterator();
        while(iter.hasNext()) {
            OreData ore = iter.next();
            if (TerrainGen.generateOre(world, rand, ore.oreGen, chunkX, chunkZ, OreGenEvent.GenerateMinable.EventType.CUSTOM))
                genStandardOre(ore.count, world, ore.oreGen, rand, chunkX * 16, chunkZ * 16, ore.min, ore.max);
        }
    }
}

 

 

EDIT: I forgot the package :/

PM's regarding modding questions should belong in the Modder Support sub-forum and won't be answered.

Link to post
Share on other sites

I'm wondering why everybody following some tutorial is making the same mistake in oreGen? Maybe we should blacklist the tutorial.

Link to post
Share on other sites

You have to multiply the chunkX and chunkZ by 16. Or just use my class:

Then just use the addOre method in your Registry...

 

import cpw.mods.fml.common.IWorldGenerator;
import net.minecraft.block.Block;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.event.terraingen.OreGenEvent;
import net.minecraftforge.event.terraingen.TerrainGen;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.Random;

public class OreGen implements IWorldGenerator{

    private class OreData {
        protected final WorldGenMinable oreGen;
        protected final int min;
        protected final int max;
        protected final int count;

        protected OreData(WorldGenMinable ore, int minHeight, int maxHeight, int clusterCount) {
            oreGen = ore;
            min = minHeight;
            max = maxHeight;
            count = clusterCount;
        }
    }

    private final List<OreData> oreGenList = new ArrayList<OreData>();

    public void addOre(Block block, int size, int minHeight, int maxHeight, int clusterCount) {
        OreData data = new OreData(new WorldGenMinable(block, size), minHeight, maxHeight, clusterCount);
        oreGenList.add(data);
    }

    public void addOre(Block block, int size) {
        OreData data = new OreData(new WorldGenMinable(block, size), 0, 64, 20);
        oreGenList.add(data);
    }

    public void addOre(Block block) {
        OreData data = new OreData(new WorldGenMinable(block, , 0, 64, 20);
        oreGenList.add(data);
    }

    public void genStandardOre(int count, World world, WorldGenerator worldGen, Random rand, int chunkX, int chunkZ, int min, int max) {
        for (int i = 0; i < count; i++) {
            int x = chunkX + rand.nextInt(16);
            int y = rand.nextInt(max - min) + min;
            int z = chunkZ + rand.nextInt(16);
            worldGen.generate(world, rand, x, y, z);
        }
    }

    @Override
    public void generate(Random rand, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {
        Iterator<OreData> iter = oreGenList.iterator();
        while(iter.hasNext()) {
            OreData ore = iter.next();
            if (TerrainGen.generateOre(world, rand, ore.oreGen, chunkX, chunkZ, OreGenEvent.GenerateMinable.EventType.CUSTOM))
                genStandardOre(ore.count, world, ore.oreGen, rand, chunkX * 16, chunkZ * 16, ore.min, ore.max);
        }
    }
}

 

 

EDIT: I forgot the package :/

Sorry, but...when you say use the addOre with your registry...what do you mean? For my ore I've got:

RadialOre = new RadialOre().setBlockName("radialore").setHardness(5.0F).setResistance(5.0F).setLightLevel(0.8F).setStepSound(Block.soundTypeStone).setCreativeTab(RadialTabs).setBlockTextureName(modid + ":radialore");
	GameRegistry.registerBlock(RadialOre, "radialore").addOre(RadialOre);
	RadialOre.setHarvestLevel("pickaxe", 3);

That gives me an error, though. Am I putting it in the wrong spot?

Link to post
Share on other sites

SureenInk, Busti is referring to the Forge OreDictionary (i believe). If you are creating new ores, you would do well to register them in the Ore registry so other mods can use them in recipes, too. Or simply not have a conflict about it when there are more than 1 lead ores in the game.

Link to post
Share on other sites

[quote name="sequituri" post="88900" timestamp="1395475684"]
SureenInk, Busti is referring to the Forge OreDictionary (i believe). If you are creating new ores, you would do well to register them in the Ore registry so other mods can use them in recipes, too. Or simply not have a conflict about it when there are more than 1 lead ores in the game.
[/quote]
Sorry...I'm horribly new at this...so then I just have to add [codepublic static void oreRegistration()
{
	OreDictionary.registerOre("radialore", RadialOre);
}

I'm sorry...I really am new at this (just started the other day), so I'm still very confused x.x

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.