Jump to content

[1.7.2] Geting the damage of a weapon?


Kinniken

Recommended Posts

Hi guys,

 

It seems stupid, but I haven't managed to get the damage from an Item (like ItemSword or ItemTool). Here was my attempt:

 

public static double getItemWeaponDamage(Item item) {

Multimap multimap = item.getItemAttributeModifiers();

 

if (multimap.containsKey(SharedMonsterAttributes.attackDamage.getAttributeUnlocalizedName())) {

if (multimap.get(SharedMonsterAttributes.attackDamage.getAttributeUnlocalizedName()) instanceof AttributeModifier) {

AttributeModifier weaponModifier=(AttributeModifier) multimap.get(SharedMonsterAttributes.attackDamage.getAttributeUnlocalizedName());

return weaponModifier.getAmount();

}

}

return 0;

}

 

However multimap.get doesn't return an AttributeModifier but an class com.google.common.collect.AbstractMapBasedMultimap$WrappedSet. Anyone knows how this works?

 

Thanks

 

K.

Link to comment
Share on other sites

In case anyone else needs it:

 

@SuppressWarnings({ "rawtypes", "unchecked" })

public static double getItemWeaponDamage(Item item) {

Multimap multimap = item.getItemAttributeModifiers();

 

if (multimap.containsKey(SharedMonsterAttributes.attackDamage.getAttributeUnlocalizedName())) {

if (multimap.get(SharedMonsterAttributes.attackDamage.getAttributeUnlocalizedName()).toArray().length>0 ) {

if (multimap.get(SharedMonsterAttributes.attackDamage.getAttributeUnlocalizedName()).toArray()[0] instanceof AttributeModifier) {

AttributeModifier weaponModifier=(AttributeModifier) multimap.get(SharedMonsterAttributes.attackDamage.getAttributeUnlocalizedName()).toArray()[0];

return weaponModifier.getAmount();

}

}

}

return 0;

}

 

This assumes the modifier will be in the first entry in the set and seems to work fine with the vanilla Minecraft weapons. No idea whether there are cases where this won't be true.

Link to comment
Share on other sites

For a collection with an expected size of 1, the actual difference isn't going to be very significant...

 

After that, I suppose it depends how often you can that method. If it's every tick then you need to be careful. If it's once in very specific circumstances then I'm skeptical the difference will amount to anything.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.