Jump to content

Recommended Posts

Posted

What im trying to do is make custom recipes for my custom furnace

 

private boolean canSmelt() {

if(this.slots[0] == null){

return false;

}else{

ItemStack itemstack = FurnaceRecipes.smelting().getSmeltingResult(this.slots[0]);

 

if(itemstack == null) return false;

if(this.slots[2] == null) return true;

if(!this.slots[2].isItemEqual(itemstack)) return false;

 

int result  = this.slots[2].stackSize + itemstack.stackSize;

 

return (result <= getInventoryStackLimit() && result <= itemstack.getMaxStackSize());

}

}

 

 

 

The ItemStack itemstack = FurnaceRecipes.smelting().getSmeltingResult(this.slots[0]); line makes any vanilla furnace recipe possible but I want only custom recipies. How am I able to do that?

 

Posted

Have you seen the mc code? its pretty hard to use and work with....

Really, all you need is a HashMap<ItemStack,ItemStack>.

Please, explain more. I know where the hash map thing is, but what do I do with it? Where do I put it (like do I create a method for it or add it to my mod base class)?

Posted

Please learn basic java.

You can put it wherever you want, but the "most OOP" way would be to make a new class for it.

I know basic java, but im new to modding.

You don't have to do this, but it would be great if you told my exactly what to do. If you don't want to, its ok, i'll keep trying to find out myself.

Posted

Just because I am bored. Please do not copy paste.

 

import static com.google.common.base.Preconditions.checkNotNull;

enum MyAwesomeMachineRecipes {

INSTANCE; // enum Singleton pattern

public void addRecipe(ItemStack input, ItemStack output) {
	recipes.put(checkNotNull(input), checkNotNull(output));
}

public ItemStack findResult(ItemStack input) {
	ItemStack result = recipes.get(input);
	if (result != null) {
		return result;
	}
	// if you don't need metadata-agnostic recipes you can remove this
	return recipes.get(new ItemStack(input.getItem(), 1, OreDictionary.WILDCARD_VALUE));
}

// use custom HashMap from Trove to support hashCode and equals for ItemStacks
// this implementation only uses the Item and the damage value, if you need NBT sensitive checks you need to
// include that
private final TMap<ItemStack, ItemStack> recipes = new TCustomHashMap<ItemStack, ItemStack>(new HashingStrategy<ItemStack>() {
	@Override
	public int computeHashCode(ItemStack stack) {
		// not the most efficient hashCode probably
		int result = stack.getItem().hashCode();
		result = 31 * result + stack.getItemDamage();
		return result;
	}

	@Override
	public boolean equals(ItemStack o1, ItemStack o2) {
		if (o1 == o2) {
			return true;
		}
		if (o1.getItem() != o2.getItem()) {
			return false;
		}
		if (o1.getItemDamage() != o2.getItemDamage()) {
			return false;
		}
		return true;
	}
});

}

 

This doesn't compare ItemStack NBT tags. If you need that, you'll have to add it.

Also: Untested.

 

 

OMG! Your the best! I thought you would just say "learn it yourself" or something, but no! You actually did it! +1 Karma

 

Edit: What do I put in my TileEntity class? For the vanilla recipies I would put: ItemStack itemstack = FurnaceRecipes.smelting().getSmeltingResult(this.slots[0]);

Posted

    @Override
      public int computeHashCode(ItemStack stack) {
         // not the most efficient hashCode probably
         int result = stack.getItem().hashCode();
         result = 31 * result + stack.getItemDamage();
         return result;
      }

 

Why the 31x in the packing?

I would have figured a bitshift to pack the two values, which would be a 2power multiplier,

but with that 31 you have the low 5 bits all set, but followed with a + instead of an AND to pack.... also, while block Metadata has the 16 limit, cant Items have far more 'damage' subtypes than would fit in a  31x& pack?

 

I am not using the code, I just want to understand it better.

If you just picked 31x cause it looked good, ok, I can live with that,

but I am wondering if there is some reason, some significance to using 31x that I am missing

Posted

Seriously? I give you full, working code and you don't even bother trying to read and understand it? Nope. Not gonna happen.

I have read the whole thing many, many times, even fixed some errors, but still, I can't figure out how to put it in my tileentity class. Its kind of obvious how to add a new recipe tho, I got that.

Posted

It should be kind of obvious on how to use it, too. Just call

findResult

with your input.

Ok, thanks, I finally got it to work, you can close the topic now

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi,  I'm using Forge 47.3.0 for Minecraft 1.20.1 I apologise if this is obvious I am very new to modding for Minecraft. I sucessfully made a mod that launched without errors or crashes (without it doing anything) but in order to add the features I need, I need to add "Custom Portal API [Forge]" as a dependency. However no matter the way I've tried to acheive this, it crashes. I am pretty sure it's not the way I'm putting it in the repositories, the dependencies or the way I'm refrencing it, as I've a hundred diffrent combinations and multiple Maven methods. And on all those diffrent variations I still get this crash: pastebin.com/UhumzZCZ Any tips would be invaluable as I've been loosing my mind over this!
    • Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.