Is there a tutorial on submitting a pull request?

Posted September 1, 201213 yr

I have figured out what I need to do to submit a pull request but I did not find a singular location describing how to do it and explaining the build environment. I am having concerns I did it wrong due to some of the things I have noticed while setting up my build environment. For example, if I set my workspace to "C:\ForgeFork\mcp71\MinecraftForge\eclipse" (after running "setup.bat") neither "Clean-Client" nor "Forge-Client" show up as projects and need to be added by hand

Is there any tutorial that I just missed? I just want to make sure I am not starting down the wrong path.

Quote

September 2, 201213 yr

You fork from the MinecraftForge repo on github, and then hit the pull request button, add a title and description, etc.

So, what would happen if I did push that shiny red button over there? ... Really? ... Can I try it? ... Damn.

Quote

September 2, 201213 yr

Author

Except that you skipped the part about if you don't name the folder "forge" instead of the default "ForgeClient" it breaks the build. Or that the two eclipse projects are not added and must be added by and that will mess up the ".metadata" folder so you will need to not commit those changes, or whats the difference between Clean-Client and Forge-Client, or how the build script works, or the 100 other little things that come up that could be easily explained in a step by tutorial.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/1821-is-there-a-tutorial-on-submitting-a-pull-request/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted 45 minutes ago45 min
incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Dealing with modded server issues can be a real headache been there! At least you can keep your look stress-free with a fresh low taper fade.

By AriaDawn · 1 hour ago1 hr
Help with file conversion

This is really helpful

By Brialeblanc · 6 hours ago6 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 12 hours ago12 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted 20 hours ago20 hr

TileEntity

Sign In

Is there a tutorial on submitting a pull request?

Featured Replies

Join the conversation

Posts

How to add my mob to another mod's biome in 1.20.1.

incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)