1.7.2 - There is a bug on the crafting recipes code and I can't see where it is

pta2002 · June 8, 2014

Hey, I am almost ending my mod and it was working fine when I run Minecraft to see if the craftable enchanted items where working (They worked) and then I decided to add one more item. I put it there, all fine but when I run the game, it crashed with the error: NullPointerException. All the times I got this error, I fixed it (always in the crafting). I removed all the shaped crafting code and Minecraft launched. I put the code back and I removed the recipe I added for the item I created. But this time, it crashed. I tried to see where the error is, since Eclipse wasn't showing me any error icon, but I didn't found it.

Do, I'm asking you if you can tell me what's wrong in the crafting code.

Here it is:

GameRegistry.addRecipe(new ItemStack(EmeraldHoe,1), new Object[] {"EE"," S "," S ",'E', Items.emerald, 'S', Items.stick});

GameRegistry.addRecipe(new ItemStack(EmeraldAxe,1), new Object[] {"EE ","ES "," S ",'E', Items.emerald, 'S', Items.stick});

GameRegistry.addRecipe(new ItemStack(EmeraldAxe,1), new Object[] {" EE"," SE"," S ",'E', Items.emerald, 'S', Items.stick});

ItemStack stack = new ItemStack(NetherSword,1);

stack.addEnchantment(Enchantment.fireAspect, 10);

GameRegistry.addRecipe(stack,

"X",

"B",'X', NetherIngot, 'B', Items.blaze_rod);

GameRegistry.addRecipe(new ItemStack(FusionGem,1), new Object[] {" D ","SEO"," E ",'D', Items.diamond,'S', SapphireGem,'E', Items.emerald,'O', Blocks.obsidian});

GameRegistry.addRecipe(new ItemStack(EmeraldPick,1), new Object[] {"XXX"," S "," S ", 'X', Items.emerald, 'S', Items.stick});

GameRegistry.addRecipe(new ItemStack(EmeraldShovel,1), new Object[] {"X","S","S",'X', Items.emerald, 'S', Items.stick});

GameRegistry.addRecipe(new ItemStack(EmeraldSword,1), new Object[] {"X","X","S",'X', Items.emerald, 'S', Items.stick});

GameRegistry.addRecipe(new ItemStack(ObsidianShovel,1), new Object[] {

"X","S","S",'X', Blocks.obsidian, 'S', Items.stick

});

ItemStack itemstack = new ItemStack(MegaPick, 1);

itemstack.addEnchantment(Enchantment.efficiency, 2);

GameRegistry.addRecipe(itemstack, "EOS", " F "," X ",'E', EmeraldPick,'O', ObsidianPick,'S', SapphirePick,'F', FusionGem,'X', Items.stick);

GameRegistry.addRecipe(new ItemStack(ObsidianHoe,1), new Object[] {

"XX","S","S",'X', Blocks.obsidian, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(ObsidianAxe,1), new Object[] {

"XX ","XS "," S ",'X', Blocks.obsidian, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(ObsidianAxe,1), new Object[] {

" XX"," SX"," S ",'X', Blocks.obsidian, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(ObsidianPick,1), new Object[] {

"XXX"," S ","S", 'X', Blocks.obsidian, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(ObsidianSword,1), new Object[] {

"X","X","S", 'X', Blocks.obsidian, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(SapphireBlock, 1), new Object[] {

"XXX",

"XXX",'X', SapphireGem

});

GameRegistry.addRecipe(new ItemStack(SapphireAxe, 1), new Object[] {

"XX ",

"XS ",

" S ", 'X', SapphireGem, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(SapphireAxe, 1), new Object[] {

" XX",

" SX",

" S ", 'X', SapphireGem, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(SapphireHoe, 1), new Object[] {

"XX ",

" S ",

" S ", 'X', SapphireGem, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(SapphireHoe, 1), new Object[] {

" XX",

" S ",

" S ", 'X', SapphireGem, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(SapphirePick, 1), new Object[] {

"XXX",

" S ",

" S ", 'X', SapphireGem, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(SapphireShovel, 1), new Object[] {

"X ",

"S ",

"S ", 'X', SapphireGem, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(SapphireShovel, 1), new Object[] {

" X ",

" S ",

" S ", 'X', SapphireGem, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(SapphireShovel, 1), new Object[] {

" X",

" S",

" S", 'X', SapphireGem, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(SapphireSword, 1), new Object[] {

"X ",

"S ", 'X', SapphireGem, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(SapphireSword, 1), new Object[] {

" X ",

" S ", 'X', SapphireGem, 'S', Items.stick

});

GameRegistry.addRecipe(new ItemStack(SapphireSword, 1), new Object[] {

" X",

" S", 'X', SapphireGem, 'S', Items.stick

});

LexManos · June 8, 2014

For the love of god, you don't need 'new Object[]{'

Thats compiler spam just makes your code UGLY.

Anyways your issue is that one of moe of the Items you're using to inialize your ItemStacks is Null at the time you're making the recipe. Check your order of code and see if your item init code runs before this code.

pta2002 · June 8, 2014

Here it is: (WTF? // I'm sorry, Dave? Who is Dave?

---- Minecraft Crash Report ----

// I'm sorry, Dave.

Time: 08-06-2014 16:17

Description: Initializing game

java.lang.StringIndexOutOfBoundsException: String index out of range: 8

at java.lang.String.charAt(String.java:658)

at net.minecraft.item.crafting.CraftingManager.addRecipe(CraftingManager.java:232)

at cpw.mods.fml.common.registry.GameRegistry.addShapedRecipe(GameRegistry.java:233)

at cpw.mods.fml.common.registry.GameRegistry.addRecipe(GameRegistry.java:228)

at com.pta.plusmod.PlusMod.<init>(PlusMod.java:165)

at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)

at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)

at java.lang.reflect.Constructor.newInstance(Constructor.java:526)

at java.lang.Class.newInstance(Class.java:374)

at cpw.mods.fml.common.ILanguageAdapter$JavaAdapter.getNewInstance(ILanguageAdapter.java:173)

at cpw.mods.fml.common.FMLModContainer.constructMod(FMLModContainer.java:486)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:606)

at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:47)

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

at com.google.common.eventbus.EventBus.post(EventBus.java:267)

at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:208)

at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:187)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:606)

at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:47)

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

at com.google.common.eventbus.EventBus.post(EventBus.java:267)

at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:118)

at cpw.mods.fml.common.Loader.loadMods(Loader.java:491)

at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:204)

at net.minecraft.client.Minecraft.startGame(Minecraft.java:522)

at net.minecraft.client.Minecraft.run(Minecraft.java:892)

at net.minecraft.client.main.Main.main(Main.java:112)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:606)

at net.minecraft.launchwrapper.Launch.launch(Launch.java:134)

at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

A detailed walkthrough of the error, its code path and all known details is as follows:

---------------------------------------------------------------------------------------

-- Head --

Stacktrace: