Jump to content

Recommended Posts

Posted

That helped clear some stuff up, thanks. Any simple way of changing how long an animation will take, or will I just have to do some custom timer type things.

 

The way I do animation cycle is with a 2D array of rotation values.  Each row by default represents 1 tick of the game.  So if you want to adjust the speed of the animation cycle you would add extra rows to the cycle (ideally with angles that are in between the angles of the rows above and below to ensure smooth animation).

 

That creates a cycle, but sometimes you want a cycle to happen once and sometimes you want it to happen repeatedly for some amount of time or sometimes you want it to happen continuously.

 

To control animations you will need some booleans and maybe int counters in your custom entity class, and you'll need to check those in your Model class to control the animation.  For example I have an EntityElephant that will rear up when attacked instead of running away.  So in the elephant class I create a public boolean field called isRearing and set it to true when attacked.  Then in the model I check the state of the isRearing variable and if true I set angles based on the animation cycle for rearing.  When the cycle index counter gets to the end of the animation I clear the isRearing field.  So this makes a one time animation.

 

But yes you could use a timer counter as well.  The main point is you do need other variables to control the animations, and it really depends on your situation.  For example another entity I created is a snake and so I control the animation based on movement -- I want it to slither when moving.  Another entity I created is an eagle and it has a lot of different types of animations -- the way it flaps its wings is different when it is soaring versus when it is diving.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Posted

Yeah, I had a feeling I would have to do something like that. I have just been looking at the iron golem class as I want to do something similar to when it attacks and I think I get what I am doing now, thanks.

Posted

Hrmm, I removed that, forgot I made it static, but now it isn't working at all.

ENTITY


public boolean attackEntityAsMob(Entity par1Entity) {

	this.attackTimer = 50;

        return par1Entity.attackEntityFrom(DamageSource.causeMobDamage(this), (float) getEntityAttribute(SharedMonsterAttributes.movementSpeed).getAttributeValue());
        
}

public void onLivingUpdate() {

        super.onLivingUpdate();

        if (this.attackTimer > 0) {
        	
            -- this.attackTimer;
            
        }
        
    }

    public int getAttackTimer() {

        return this.attackTimer;
        
    }

MODEL


public void setLivingAnimations(EntityLivingBase par1EntityLivingBase, float par2, float par3, float par4)
  {
      EntityGuardianStone entityguardianstone = (EntityGuardianStone)par1EntityLivingBase;
      int i = entityguardianstone.getAttackTimer();

      if (i > 0) {
    	  
          this.JabbyThing.offsetZ = (float) (- i * 0.02);
          
      } else {
    	  
    	  this.JabbyThing.offsetZ = (float) 0.01;
    	  
      }
      
  }

Posted

That looks fairly correct.  I suggest just putting in some console messages (with System.out.println() method) to print out where you are in the code and what the attackTimer value is at that time to help trace the code logic.  You should have console message when you first set the attackTimer to 50, then again after each if statement that tests the value.  That should tell you a fair bit.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Posted

Well I think it is just that in the setLivingAnimations() method, it isn't getting the updated value for int attackTimer, but I do not know why... It changes within the class attackTimer is created but not in the model class.

Posted

Oh, well one of the problems with doing animations is that the animation is done on the client side but usually the logic that controls the logic is done on the server side.  So you often need to use a packet to sync the two sides.  For example, you probably need to send a custom packet to keep the attackTimer synced.  It is a pain, but as far as I know necessary. 

 

To prove this, you should print out debug statements that show what side the code is executing on (i.e. the worldObj.isRemote kind of check).  I think you'll see that your attackTimer is being set on server and checked on client.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Posted

Will your custom packet handling tutorial help?

 

I currently use that system for controlling my animations, yes.  It does work, and I've used it for this purpose.

 

Recently, however, there seems to be confidence that we can switch to using the SimpleNetworkWrapper implementation provided by Forge.  I think if you're going to invest in implementing a packet system, you should try that first since it should be the one people use going forward.  I personally plan to switch over when I can find some time.

 

But mine does work fine too.  I think my tutorial is still good to teach the basic concepts -- all the Netty-based systems need to do the same general things, which I explain.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Posted

I am trying to learn what is going on but it is a bit overwhelming at the moment. I will start again tomorrow so I can concentrate more. Thanks for the help anyways, you have been a massive help to me.

Posted

I posted correction on your other thread with topic on the attacking, but I made mistake in the code for the mob attack -- instead of the movementSpeed attribute it should be (of course) the attackDamage attribute.  Be sure to correct your code.

 

public boolean attackEntityAsMob(Entity par1Entity) {

 

this.attackTimer = 50;

 

        return par1Entity.attackEntityFrom(DamageSource.causeMobDamage(this), (float) getEntityAttribute(SharedMonsterAttributes.attackDamage).getAttributeValue());

       

}

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Posted

Oh, well one of the problems with doing animations is that the animation is done on the client side but usually the logic that controls the logic is done on the server side.  So you often need to use a packet to sync the two sides.  For example, you probably need to send a custom packet to keep the attackTimer synced.  It is a pain, but as far as I know necessary. 

 

To prove this, you should print out debug statements that show what side the code is executing on (i.e. the worldObj.isRemote kind of check).  I think you'll see that your attackTimer is being set on server and checked on client.

 

Is there any other way around this, I literally have 1 variable I need to use in another class and this just seems, as you put it, overkill.

Posted

This is how i do it i set a command to tigrex in his Entity then do the animation in the model

 

 

public void animate(EntityTigrex tigrex, float f, float f1, float f2, float f3,float f4, float f5){

      if(tigrex.getNextAttack == 1 ){
               animateBite();
                else{
dobreatheAnim();
doWalkAnim[1];
doWalkAnim[2];
doWalkAnim[3];
doWalkAnim[4];
setRotationYawPitch(tigrex.rotationYaw);
}

             }
      
      

Posted

The problem I am having is that I can get the int value of my attack timer without i being static, so the animation would work  if the I could get its value.

Posted

I believe I have the exact same setup as the golem but it isn't working.

 

I think the problem is that the vanilla enitities do have number of packets traversing around to keep things in sync, and it is entirely possible that the golem attackTimer is somehow sync'ed with those.  I poked around in the various packets (e.g. look in net.minecraft.network.play.server and net.minecraft.network.play.client packages) and couldn't find an actual reference to this, but you can see from the sheer wealth of packet types that it is very possible that this sync is happening.

 

I think you could possibly use the DataWatcher to do the syncing, especially if your counter could be contained in a single byte.  I haven't used DataWatcher much, but it is basically a very small amount of data that is kept in sync for you.  It is really only suitable for passing booleans and bytes.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.