Jump to content

[1.7.2] Adding a new Melon crop.


J3FF97

Recommended Posts

Hello everyone.

 

I'm working on a mod now, ElementalMelons, which adds new melons that give potion effects while eaten etc.

Question is, how do I add the crops? I've been scouting through the MC code and the only thing I could think about crashed me while planting the crop.

I have everything for that's needed, a block (The melon), a seed and a Stem (Which is not working.)

Also, I've been thinking about using the melon stem from vanilla, but that would give me a regular melon, unless I altered MC's code, right?

If anyone could help me/give suggestions, that'd be awesome ^.^

 

~J

 

Code is on github: https://github.com/J3FF97/Elemental-Melons

Link to comment
Share on other sites

Thanks ^.^

 

It turns out that the only thing that's crashing me is the planting of the seed, the crops itself work like a charm (tested via /give ), they grow, are bonemealed and spawn the melon blocks.

@Jabelar I honestly did not find any tutorial about this, you having one and giving me a link to it, awesome ^.^ I'm just gonna use it for the seeds, since most of it is just the same as a regular melon. (Not even gonna use a different texture for the stem :P ) I'll keep you guys updated on this :)

Link to comment
Share on other sites

Unfortunately, no success.

The tutorial, albeit a very very nice one, is not helping me since you are doing things slightly different than I am used to, and you are making something different than I want to make (foodseed vs regular seed) And in my current status I am not able to convert it :P

 

Also, these are the crashlogs I am currently getting:

(I'm getting both client and server logs, even though I am only running a client.)

Server log: http://pastebin.com/KAcsEyAZ

Client log: http://pastebin.com/mvJQ5fnC

 

Link to comment
Share on other sites

I think the concepts should be same with regular seed and seed food.  I know there was a lot of info in my tutorial so you may have missed it but I explained that if you don't want it to be a seed food: "Note: If you don't want it to be a food, you could just extend Item while implementing IPlantable."

 

Basically an item becomes a seed by implementing IPlantable.

 

I also explain the important bits about how it determines if you can actually plant it, like the crop type, etc.

 

Anyway, you said that it was "crashing" when you're trying to plant it. Looking at your crash code it is just a null pointer exception.  When is this crash happening?  Right when you try to start the game?  Or after you're playing and try to plant the seed?

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

You're probably right, at the time I posted my last reply, It was late and I was tired xD So I didn't look into everything.

Instead of extending Item, I could also extend ItemSeeds right? That would have me go directly to the seeds classes, without me needing to create a new itemseed kind of class, like your tutorial is doing, nevertheless, I'm gonna try it out.

The crash is happening as soon as I plant one of the seeds, I can do everything else, just when I plant the seed it crashes.

 

I'll keep you updated, thanks again :)

 

(now onto texturing, ugh D: I hate that part D: )

Link to comment
Share on other sites

I've implemented the RecipeItemSeedFood class (as SeedHelper) and made the necessary adjustments. Still crashes.

 

Server log: http://pastebin.com/Gh6pEV6r

Client log: http://pastebin.com/zHjxa7C1

Again, getting a server log while I'm only on client, dunno where that came from :/

 

Running through the log, I can only see 1 line in which it crashed in my code, that is in the seedhelper:

  parWorld.setBlock(parX, parY+1, parZ, crop);

That's where the crash is.

 

Link to comment
Share on other sites

One thing that may be an issue that I've run into before: try switching the order of where you init your blocks versus init your items.  If you think about it, you're setting up a seed that tries to reference a block instance during construction, but that block isn't registered yet.

 

So switch it to this:

        ModBlocks.init();
        ModItems.init();

 

I should add this warning about registration order in my tutorial...

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

I haven't tried that yet honestly, since it doesn't crash during startup, meaning that everything got registered the way it's supposed to, I'l try it as soon as I get home, but I doubt it'll work to be honest :/

 

EDIT: Wow... That actually worked... Thanks! I just thought it would not, because I thought that could only cause problems at startup... hmm.. anyways, thanks :D

Link to comment
Share on other sites

I haven't tried that yet honestly, since it doesn't crash during startup, meaning that everything got registered the way it's supposed to, I'l try it as soon as I get home, but I doubt it'll work to be honest :/

 

EDIT: Wow... That actually worked... Thanks! I just thought it would not, because I thought that could only cause problems at startup... hmm.. anyways, thanks :D

 

I want to make sure you understand why the crash didn't happen during the initialization -- basically the seed constructor doesn't prevent you from passing a "null" block.  That type of "null" passed as parameter is legitimate (not a null pointer exception) at the time it is passed.  So only becomes a null pointer exception later when you actually try to plant (place that null block).

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

Hmm okay, I get it. I don't get why it still would crash when I planted the crop, because it has loaded the crop by then right? Or is it because it has loaded the crop as a null? Anyways, it's working now ^.^ Thanks :) Sometimes I just need someone to take a look at my code :P

Link to comment
Share on other sites

Java is bit weird as it treats primitive types different from objects.  In this case the difference is that for object fields the memory isn't allocated until the object is instantiated (I. E.  By using new keyword.  Since you passed the field before you instantiated it then the block pointed to in your seed was pointing nowhere.  When you later instantiate the block it doesn't update the seed because that references different memory location.  In other words the block gets updated someplace the seed isn't pointing to.

 

So yes it tried to plant a null object because the seed was pointing to null.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Sorry, heres the new logs https://paste.ee/p/bTpMZ the ending crash error is the same but instead of the Minecraft crash screen saying the error for drivers its now showing -1 
    • Thanks for the advice, I am also facing this issue, I didn't thought about it before.
    • When I add a search bar to CreativeModeTab, the text box is not rendered even though it's possible to input text. Additionally, the search is performed on all items. This issue has been occurring since 1.21. Is there something missing in my code? https://github.com/mgen256/AdditionalLights/blob/1.21/src/main/java/com/mgen256/al/AdditionalLights.java
    • This question would probably best be asked wherever fabric support is given; these are the Minecraft Forge forums. They aren't the same thing
    • client version: forge-1.7.10-10.13.4.1614-1.7.10 forgegradle version:forge-1.7.10-10.13.4.1614-1.7.10   i can run my mod in forgegradle but i put my mod into a client ,it will crash  cpw.mods.fml.common.LoaderException: java.lang.NoSuchMethodError: com.example.examplemod.items.CommonItem.setUnlocalizedName(Ljava/lang/String;)Lnet/minecraft/item/Item;     at cpw.mods.fml.common.LoadController.transition(LoadController.java:163)     at cpw.mods.fml.common.Loader.preinitializeMods(Loader.java:559)     at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:243)     at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:480)     at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:878)     at net.minecraft.client.main.Main.main(SourceFile:148)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:497)     at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)     at net.minecraft.launchwrapper.Launch.main(Launch.java:28)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:497)     at oolloo.jlw.Wrapper.invokeMain(Wrapper.java:71)     at oolloo.jlw.Wrapper.main(Wrapper.java:51) Caused by: java.lang.NoSuchMethodError: com.example.examplemod.items.CommonItem.setUnlocalizedName(Ljava/lang/String;)Lnet/minecraft/item/Item;     at com.example.examplemod.items.CommonItem.<init>(CommonItem.java:10)     at com.example.examplemod.proxy.register.ItemRegister.createItem(ItemRegister.java:30)     at com.example.examplemod.proxy.register.ItemRegister.registerItems(ItemRegister.java:18)     at com.example.examplemod.proxy.CommonProxy.preInit(CommonProxy.java:12)     at com.example.examplemod.proxy.ClientProxy.preInit(ClientProxy.java:6)     at com.example.examplemod.ExampleMod.preInit(ExampleMod.java:26)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:497)     at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:532)     at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:497)     at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)     at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)     at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)     at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)     at com.google.common.eventbus.EventBus.post(EventBus.java:275)     at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:212)     at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:190)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:497)     at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)     at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)     at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)     at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)     at com.google.common.eventbus.EventBus.post(EventBus.java:275)     at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:119)     at cpw.mods.fml.common.Loader.preinitializeMods(Loader.java:556)     ... 16 more  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.