Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

Hey everyone,

 

I've been playing around with fluids and I want to add a custom recipe to enable a player to get it in survival. I noticed that that when you do craft the item (dust + water bucket), the player gets an extra empty bucket. I assume that this is because Minecraft recognizes that in vanilla recipes (Cake for Example) you don't want to take the bucket from the player.

 

This lead me to believe that I should get a handler that subscribes to ItemCraftedEvent, looks at the event to see if my custom bucket is created and if there is an empty bucket in the players inventory, and removes one bucket using "consumeInventoryItem"

 

However, after further inspection, it appears that empty bucket that is given to the user shows up after the event has been triggered and thus doesn't removed.

 

Is there a good method to handle this situation?

 

Update on 2014/07/30

 

I have discovered a potential answer to this solution. I simply added ".setContainItem(null)" to the "Items.water_bucket" in my crafting recipe. The final code would looks like this (Note, this is just an example:

 

GameRegistry.addShapelessRecipe(
    new ItemStack( myItem ),
    new Object[] {
         Items.ender_pearl,
         Items.water_bucket.setContainerItem(null)}
);

  • Author

To provide some further information, here's the event handler class that I have.

 

package net.roymond.testingMod.EventHandler;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.roymond.testingMod.mainClass;
import cpw.mods.fml.common.eventhandler.SubscribeEvent;
import cpw.mods.fml.common.gameevent.PlayerEvent;
import cpw.mods.fml.common.gameevent.PlayerEvent.ItemCraftedEvent;

public class CraftingHandler {

public static CraftingHandler INSTANCE = new CraftingHandler();

private CraftingHandler(){
}

@SubscribeEvent
public void PlayerEvent(ItemCraftedEvent event){
	ItemStack craftedItem = event.crafting;

	if (event.crafting.getItem() == mainClass.roymondBucket){
		System.out.println("Desired item has been crafted.");
		for (int i=0; i< event.player.inventory.mainInventory.length; i++){
			System.out.println(event.player.inventory.mainInventory[i]);
			//Prints each slot out on a line.
		}

		if (event.player.inventory.hasItem(Items.bucket)){
			System.out.println("Player has Item. Cleared to remove it");
		}
	}
}


}

 

So this will report to me that the desire item has been crafted and will report back the player's inventory but if you go through the player's inventory you will not see a bucket (Items.bucket).

 

Any ideas on how I can capture this bucket so I can get rid of it?

  • Author

I have discovered a potential answer to this solution. I simply added ".setContainItem(null)" to the "Items.water_bucket" in my crafting recipe. The final code would looks like this (Note, this is just an example:

 

GameRegistry.addShapelessRecipe(
    new ItemStack( myItem ),
    new Object[] {
         Items.ender_pearl,
         Items.water_bucket.setContainerItem(null)}
);

 

Hopefully this helps someone in the future.

  • 2 months later...

Yeah, you are right.

Is there nothing like "if you craft the with a water bucket and you have crafted a malt bucket, then return this.setContainerItem(null) else return this.setContainerItem(items.bucket)"?

Creator of the Master Chef Mod and many more to come.

 

If I helped you, please click the 'thank you' button.

I appreciate your help, I will try to figure out a way. Hopefully there is!

Creator of the Master Chef Mod and many more to come.

 

If I helped you, please click the 'thank you' button.

  • 1 year later...

guys found a pretty easy way

Item lavaNoContainer = Items.lava_bucket;
lavaNoContainer.setContainerItem(null);

Item waterNoContainer = Items.water_bucket;
waterNoContainer.setContainerItem(null);

 

Then use these to items to craft your stuff. This worked for me and shouldn't break other mods. The weird thing is that it worked without registering which is really great

Currently developing a mod called Lot'O'Stuff for 1.7.10 (I know very well its outdated.)

[me=Draco18s]skips the local variable assignment.[/me]

 

Items.lava_bucket.setContainerItem(null);

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Yeah ur right tried it. is there any other way to do this in 1.7.10?

Currently developing a mod called Lot'O'Stuff for 1.7.10 (I know very well its outdated.)

Suggestion: Change ur whole approach to brew a potion instead (3 bottles of water plus dust ingredient yields 3 bottles of new mystery fluid). Then you just need a way to convert your potion into a fluid source block when you use it in the world.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.