DamageSource.getEntity() and DamageSource.getSourceOfDamage() return the same?

[Goz3rr]

I've read the sticky, but a console log doesn't really seem needed here.

 

I'm using MC1.3.2, Forge 4.1.4.272 and FML 3.1.15.378

 

To reproduce this:

Make a class subscribed to LivingDropsEvent, run this code on that event:

	ModLoader.getMinecraftInstance().thePlayer.addChatMessage(event.source.getSourceOfDamage().getClass().toString());		
	ModLoader.getMinecraftInstance().thePlayer.addChatMessage(event.source.getEntity().getClass().toString());	

 

Kill an animal, chat will show "class net.minecraft.src.EntityPlayerMP" twice, which is the player. Shouldn't getEntity() return the entity that died?

 

The wiki says:

Calling source.getEntity() will return an Entity if the damage source is an entity or null otherwise.

 

And when looking at DamageSource.java:

    public Entity getSourceOfDamage()
    {
        return this.getEntity();
    }

    public Entity getEntity()
    {
        return null;
    }

 

what.

[LexManos]

EntityDamageSource

Basic vanilla functionality.

[SanAndreaP]

EntityDamageSource

Basic vanilla functionality.

^ this

 

Also there is a difference between those two methods, but only in certain DamageSource instances. For example the damage source from an arrow returns the arrow entity itself with getSourceOfDamage() and the entity which shot that arrow (e.g. the player) with getEntity(), or the arrow itself again if the shooting entity instance is null.