[1.7.10]Containers and Guis[Solved]

[hnsdieter]

Dear Community,

 

Im pretty new to the scene and got a basic knowledge of modding I hope.

 

I followed the Guide for this on the wiki and figuered out how parts of it work.

As you might know the tutorial is outdated so Ive got a few questions:

 

When Im in game and shift click the items out, the items double like( 1, 2, 4, 8 and so on) what can I do to prevent mc from doing this? And I cant shift click into the bottom item slots.

 

How can I let the items spread out on break, the code seems not to work?[solved]

 

And the items in the gui are not saving, if i restart the world/server, how can I fix that?[solved]

 

Code:

package hnsdieter.chargecore.container;

import hnsdieter.chargecore.tileentity.BaseGeneratorTileEntity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.*;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;


/**
* Created by Andy on 31.08.2014.
*/
public class ContainerGenerator extends net.minecraft.inventory.Container{

    protected BaseGeneratorTileEntity tileEntity1;

    public ContainerGenerator(InventoryPlayer inventoryPlayer, TileEntity te){
        tileEntity1 = (BaseGeneratorTileEntity) te;

        for (int i = 0; i < 3; i++){
            for (int j = 0; j < 3; j++){
                addSlotToContainer(new Slot(tileEntity1, j + i * 3, 62 + j * 18, 17 + i * 18));
            }
        }
        bindPlayerInventory(inventoryPlayer);
    }

    protected  void bindPlayerInventory(InventoryPlayer inventoryPlayer){
        for(int i = 0; i < 3; i++){
            for (int j = 0; j < 9; j++){
                addSlotToContainer(new Slot(inventoryPlayer, j + i * 9 + 9, 8 + j * 18, 84 + i * 18));
            }
        }

        for(int i = 0; i < 9; i++){
            addSlotToContainer(new Slot(inventoryPlayer, i, 8 + i * 18, 142));
        }
    }

    public ItemStack transferStackInSlot(EntityPlayer player, int slot){
        ItemStack stack = null;
        Slot slotObject = (Slot) inventorySlots.get(slot);

        if(slotObject != null && slotObject.getHasStack()){
            ItemStack stackInSlot = slotObject.getStack();
            stack = stackInSlot.copy();

            if(slot < 9){
                if(!this.mergeItemStack(stackInSlot, 0, 35, true)){
                    return null;
                }
            }else if(!this.mergeItemStack(stackInSlot, 0, 9, false)){
                return null;
            }

            if(stackInSlot.stackSize == 0){
                slotObject.putStack(null);
            }else{
                slotObject.onSlotChanged();
            }

            if(stackInSlot.stackSize == stack.stackSize){
                return null;
            }
            slotObject.onPickupFromSlot(player, stackInSlot);
        }
        return stack;
    }

    @Override
    public boolean canInteractWith(EntityPlayer player) {
        return tileEntity1.isUseableByPlayer(player);
    }
}

package hnsdieter.chargecore.gui;

import hnsdieter.chargecore.container.ContainerGenerator;
import hnsdieter.chargecore.reference.Reference;
import hnsdieter.chargecore.tileentity.BaseGeneratorTileEntity;
import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.StatCollector;
import org.lwjgl.opengl.GL11;

/**
* Created by Andy on 31.08.2014.
*/
public class GuiBaseGenerator extends GuiContainer {
    public GuiBaseGenerator(InventoryPlayer inventoryPlayer, BaseGeneratorTileEntity tileEntity) {
        super(new ContainerGenerator(inventoryPlayer, tileEntity));
    }

    protected void drawGuiContainerForegroundLayer(int par1, int par2){
        fontRendererObj.drawString("BaseGenerator", 8, 6, 4210752);
        fontRendererObj.drawString(StatCollector.translateToLocal("container.inventory"), 8, ySize - 96 + 2, 4210752);
    }

    @Override
    protected void drawGuiContainerBackgroundLayer(float p_146976_1_, int p_146976_2_, int p_146976_3_) {
        ResourceLocation texture = new ResourceLocation(Reference.ID + ":" + "/textures/gui/crafting.png");

        GL11.glColor4f(1.0F, 1.0F, 1.0F, 10.F);
        this.mc.renderEngine.bindTexture(texture);
        int x = (width - xSize) / 2;
        int y = (height - ySize) / 2;
        this.drawTexturedModalRect(x, y, 0, 0, xSize, ySize);
    }
}

package hnsdieter.chargecore.gui;

import cpw.mods.fml.common.network.IGuiHandler;
import hnsdieter.chargecore.container.ContainerGenerator;
import hnsdieter.chargecore.tileentity.BaseGeneratorTileEntity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;

/**
* Created by Andy on 31.08.2014.
*/
public class GuiHandler implements IGuiHandler {

    @Override
    public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
        TileEntity tileEntity = world.getTileEntity(x, y, z);
        if(tileEntity instanceof BaseGeneratorTileEntity){
            return new ContainerGenerator(player.inventory, (TileEntity) tileEntity);
        }
        return null;
    }

    @Override
    public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
        TileEntity tileEntity = world.getTileEntity(x, y, z);
        if(tileEntity instanceof BaseGeneratorTileEntity){
            return new GuiBaseGenerator(player.inventory, (BaseGeneratorTileEntity) tileEntity);
        }
        return null;
    }
}

package hnsdieter.chargecore.tileentity;

import hnsdieter.chargecore.block.BaseGenerator;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;

/**
* Created by Andy on 31.08.2014.
*/
public class BaseGeneratorTileEntity extends TileEntity implements IInventory {

    private  ItemStack[] itemStacks;
    private  String invName;

    public BaseGeneratorTileEntity(int size, String displayName){
        itemStacks = new ItemStack[size];
        invName = displayName;
    }
    /*NBT*/
    @Override
    public void readFromNBT(NBTTagCompound nbtTagCompound){
        super.readFromNBT(nbtTagCompound);

        NBTTagList tagList = nbtTagCompound.getTagList("Inventory", 10);
        for (int i = 0; i < tagList.tagCount(); i++){
            NBTTagCompound nbtTagCompound1 = (NBTTagCompound)tagList.getCompoundTagAt(i);
            byte slot = nbtTagCompound1.getByte("Slot");
            if(slot >= 0 && slot < itemStacks.length){
                itemStacks[slot] = ItemStack.loadItemStackFromNBT(nbtTagCompound1);
            }
        }
    }

    @Override
    public  void writeToNBT(NBTTagCompound nbtTagCompound){
        super.writeToNBT(nbtTagCompound);

        NBTTagList tagList = new NBTTagList();
        for(int i = 0; i < itemStacks.length; i++){
            ItemStack itemStack = itemStacks[i];
            if(itemStack != null){
                NBTTagCompound nbtTagCompound1 = new NBTTagCompound();
                nbtTagCompound1.setByte("Slot", (byte) i );
                itemStack.writeToNBT(nbtTagCompound1);
                tagList.appendTag(nbtTagCompound1);
            }
        }
        nbtTagCompound.setTag("Inventory", tagList);
    }

    /*Inventory*/
    @Override
    public int getSizeInventory() {
        return itemStacks.length;
    }

    @Override
    public ItemStack getStackInSlot(int slot) {
        return itemStacks[slot];
    }

    @Override
    public ItemStack decrStackSize(int slot, int amount) {
        ItemStack itemStack = getStackInSlot(slot);
        if(itemStack != null){
            if(itemStack.stackSize <= amount){
                setInventorySlotContents(slot, null);
            }else {
                itemStack = itemStack.splitStack(amount);
                if(itemStack.stackSize == 0){
                    setInventorySlotContents(slot, null);
                }
            }
        }
        return itemStack;
    }

    @Override
    public ItemStack getStackInSlotOnClosing(int slot) {
        ItemStack itemStack = getStackInSlot(slot);
        if(itemStack != null){
            setInventorySlotContents(slot, null);
        }
        return itemStack;
    }

    @Override
    public void setInventorySlotContents(int slot, ItemStack stack) {
        itemStacks[slot] = stack;
        if(stack != null && stack.stackSize > getInventoryStackLimit()){
            stack.stackSize = getInventoryStackLimit();
        }
    }

    @Override
    public String getInventoryName() {
        if(hasCustomInventoryName() == true){
            return invName;
        }else{
            return null;
        }
    }

    @Override
    public boolean hasCustomInventoryName() {
        if (invName != null && invName.length() < 0) {
            return true;
        } else {
            return false;

        }
    }

    @Override
    public int getInventoryStackLimit() {
        return 64;
    }

    @Override
    public boolean isUseableByPlayer(EntityPlayer player) {
        return worldObj.getTileEntity(xCoord, yCoord, zCoord) == this &&
                player.getDistanceSq(xCoord + 0.5, yCoord + 0.5, zCoord + 0.5) < 64;
    }

    @Override
    public void openInventory() {

    }

    @Override
    public void closeInventory() {

    }

    @Override
    public boolean isItemValidForSlot(int p_94041_1_, ItemStack p_94041_2_) {
        return false;
    }
}

package hnsdieter.chargecore.block;

import cpw.mods.fml.common.eventhandler.SubscribeEvent;
import hnsdieter.chargecore.ChargeCore;
import hnsdieter.chargecore.tileentity.BaseGeneratorTileEntity;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;
import net.minecraftforge.event.world.BlockEvent;

import java.util.Random;

/**
* Created by Andy on 31.08.2014.
*/
public class BaseGenerator extends BaseBlock {

    public BaseGenerator(Material material) {
        super(material);
    }

    @Override
    public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int metadata, float what, float these, float are){
        TileEntity tileEntity = world.getTileEntity(x, y, z);
        if(tileEntity == null || player.isSneaking()){
            return false;
        }

        player.openGui(ChargeCore.instance, 0, world, x, y, z);
        return true;
    }

    @Override
    public void breakBlock(World world, int x, int y, int z, Block block, int par6){
        Random rand = new Random();

        BaseGeneratorTileEntity tileEntity = (BaseGeneratorTileEntity) world.getTileEntity(x, y, z);

        if(tileEntity != null) {
            for (int i = 0; i < tileEntity.getSizeInventory(); i++) {
                ItemStack itemStack = tileEntity.getStackInSlot(i);

                if (itemStack != null) {
                    float rx = rand.nextFloat() * 0.8F + 0.1F;
                    float rz = rand.nextFloat() * 0.8F + 0.1F;

                    EntityItem entityItem;

                    for (float ry = rand.nextFloat() * 0.8F + 0.1F; itemStack.stackSize > 0; world.spawnEntityInWorld(entityItem)) {

                        int j1 = rand.nextInt(21) + 10;

                        if (j1 > itemStack.stackSize) {
                            j1 = itemStack.stackSize;
                        }

                        itemStack.stackSize -= j1;
                        entityItem = new EntityItem(world, (double) ((float) x + rx), (double) ((float) y + rz), (double) ((float) z + ry));
                        float factor = 0.05F;
                        entityItem.motionX = rand.nextGaussian() * factor;
                        entityItem.motionY = rand.nextGaussian() * factor + 0.2F;
                        entityItem.motionZ = rand.nextGaussian() * factor;

                        if (itemStack.hasTagCompound()) {
                            entityItem.getEntityItem().setTagCompound((NBTTagCompound) itemStack.getTagCompound().copy());
                        }
                    }
                }
            }
            world.func_147453_f(x, y, z, block);
        }
        super.breakBlock(world, x, y, z, block, par6);
    }

    public TileEntity createNewTileEntity(World world, int par2){
        return  new BaseGeneratorTileEntity(9, "BaseGenerator");
    }
}

[Alexiy]

You need to add this to tile entity:

@Override
public Packet getDescriptionPacket() {
NBTTagCompound tag = new NBTTagCompound();
writeToNBT(tag);
return new S35PacketUpdateTileEntity(xCoord, yCoord, zCoord, 1, tag);
}
@Override
public void onDataPacket(NetworkManager net, S35PacketUpdateTileEntity pkt) {
readFromNBT(pkt.func_148857_g());
}

This is supposed to solve not saving, because it synchronises tiles.

[hnsdieter]

Ty, but that doesnt work the thing is that Ive no idea. The items are nit saving if I close and reopen the world

[hnsdieter]

After a closer look at TileEntityChest I came up with this solution, but it still doesnt work:

package hnsdieter.chargecore.tileentity;

import hnsdieter.chargecore.block.BaseGenerator;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.ISidedInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.Packet;
import net.minecraft.network.play.server.S35PacketUpdateTileEntity;
import net.minecraft.tileentity.TileEntity;

/**
* Created by Andy on 31.08.2014.
*/
public class BaseGeneratorTileEntity extends TileEntity implements ISidedInventory{

    private  ItemStack[] itemStacks;
    private  String invName;

    public BaseGeneratorTileEntity(int size, String displayName){
        itemStacks = new ItemStack[size];
        invName = displayName;
    }



    /*NBT*/
    @Override
    public void readFromNBT(NBTTagCompound nbtTagCompound){
        super.readFromNBT(nbtTagCompound);

        NBTTagList tagList = nbtTagCompound.getTagList("Inventory", 10);
        for (int i = 0; i < tagList.tagCount(); i++){
            NBTTagCompound nbtTagCompound1 = (NBTTagCompound)tagList.getCompoundTagAt(i);
            byte slot = nbtTagCompound1.getByte("Slot");
            if(slot >= 0 && slot < itemStacks.length){
                itemStacks[slot] = ItemStack.loadItemStackFromNBT(nbtTagCompound1);
            }
        }
    }

    @Override
    public  void writeToNBT(NBTTagCompound nbtTagCompound){
        super.writeToNBT(nbtTagCompound);

        NBTTagList tagList = new NBTTagList();
        for(int i = 0; i < itemStacks.length; i++){
            ItemStack itemStack = itemStacks[i];
            if(itemStack != null){
                NBTTagCompound nbtTagCompound1 = new NBTTagCompound();
                nbtTagCompound1.setByte("Slot", (byte) i );
                itemStack.writeToNBT(nbtTagCompound1);
                tagList.appendTag(nbtTagCompound1);
            }
        }
        nbtTagCompound.setTag("Inventory", tagList);
    }

    @Override
    public void updateEntity(){
        super.updateEntity();
    }

    /*Inventory*/
    @Override
    public int getSizeInventory() {
        return itemStacks.length;
    }

    @Override
    public ItemStack getStackInSlot(int slot) {
        return itemStacks[slot];
    }

    @Override
    public ItemStack decrStackSize(int slot, int amount) {
        if(this.itemStacks != null){
            ItemStack item;
            if(this.itemStacks[slot].stackSize <= amount){
                item = this.getStackInSlot(slot);
                this.setInventorySlotContents(slot, null);
                this.markDirty();
                return item;
            }else{
                item = this.getStackInSlot(slot).splitStack(amount);
                if(this.itemStacks[slot].stackSize == 0){
                    this.setInventorySlotContents(slot, null);
                }
                this.markDirty();
                return  item;
            }
        }else{
            return null;
        }
    }

    @Override
    public ItemStack getStackInSlotOnClosing(int slot) {
        if(itemStacks[slot] != null){
            ItemStack item = this.itemStacks[slot];
            this.itemStacks[slot] = null;
            return item;
        }else{
            return null;
        }
    }

    @Override
    public void setInventorySlotContents(int slot, ItemStack stack) {
        itemStacks[slot] = stack;
        if(stack != null && stack.stackSize > getInventoryStackLimit()){
            stack.stackSize = getInventoryStackLimit();
        }
        this.markDirty();
    }

    @Override
    public String getInventoryName() {
        if(hasCustomInventoryName() == true){
            return invName;
        }else{
            return null;
        }
    }

    @Override
    public boolean hasCustomInventoryName() {
        if (invName != null && invName.length() < 0) {
            return true;
        } else {
            return false;

        }
    }

    @Override
    public int getInventoryStackLimit() {
        return 64;
    }

    @Override
    public boolean isUseableByPlayer(EntityPlayer player) {
        return worldObj.getTileEntity(xCoord, yCoord, zCoord) == this &&
                player.getDistanceSq(xCoord + 0.5, yCoord + 0.5, zCoord + 0.5) < 64;
    }

    @Override
    public Packet getDescriptionPacket() {
        NBTTagCompound tag = new NBTTagCompound();
        writeToNBT(tag);
        return new S35PacketUpdateTileEntity(xCoord, yCoord, zCoord, 1, tag);
}
    @Override
    public void onDataPacket(NetworkManager net, S35PacketUpdateTileEntity pkt) {
        readFromNBT(pkt.func_148857_g());
    }

    @Override
    public void openInventory() {

    }

    @Override
    public void closeInventory() {

    }

    @Override
    public boolean isItemValidForSlot(int p_94041_1_, ItemStack p_94041_2_) {
        return false;
    }
}

[MultiMote]

You can use InventoryBasic

[wildex999]

For the Inventory not saving, what debugging have you tried?

If you are using Eclipse you can set-up debug points around writeToNBT and readFromNBT at different points and see if it actually writes/reads your items. Then you can figre out if it's a problem with the saving/loading or if there's a problem with the inventory slots etc.

Or if you are not using Eclipse, use good old prints(System.out.println).

 

 

[SnowyEgret]

After struggling with similar problems on this thread http://www.minecraftforge.net/forum/index.php/topic,22360.msg114869.html#msg114869, it was pointed out to me that the gui should be opened on the server side only:

 

if (!world.isRemote) {
        player.openGui(ChargeCore.instance, 0, world, x, y, z);
        return true;
}

 

If you put printlns in your two gui handler methods, you can see what effect this has on how they are called.

 

The suggestion by MultiMote to use InventoryBasic will reduce the amount of code you are writing and help pinpoint the problem. Give your tile entity an InventoryBasic instead of implementing IInventory:

 

public class BaseGeneratorTileEntity extends TileEntity {

    IInventory inventory = new InventoryBasic("BaseGenerator", false, 9);

[hnsdieter]

After a closer look with the println() I saw that the NBT data are written and readed if I place the Block, when i close the world they are written, but if i reopen they give me this crashlog I must totally missed the last days as I was trying to make it work:

 

java.lang.InstantiationException: hnsdieter.chargecore.tileentity.BaseGeneratorTileEntity
at java.lang.Class.newInstance(Class.java:359)
at net.minecraft.tileentity.TileEntity.createAndLoadEntity(TileEntity.java:127)
at net.minecraft.world.chunk.storage.AnvilChunkLoader.loadEntities(AnvilChunkLoader.java:525)
at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:41)
at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:12)
at net.minecraftforge.common.util.AsynchronousExecutor.skipQueue(AsynchronousExecutor.java:344)
at net.minecraftforge.common.util.AsynchronousExecutor.getSkipQueue(AsynchronousExecutor.java:302)
at net.minecraftforge.common.chunkio.ChunkIOExecutor.syncChunkLoad(ChunkIOExecutor.java:12)
at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:146)
at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:121)
at net.minecraft.server.MinecraftServer.initialWorldChunkLoad(MinecraftServer.java:315)
at net.minecraft.server.integrated.IntegratedServer.loadAllWorlds(IntegratedServer.java:79)
at net.minecraft.server.integrated.IntegratedServer.startServer(IntegratedServer.java:96)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:455)
at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:762)

 

And if I give the TileEntity InventoryBasic I need to bind the Container and GUI manually, or not?

[MultiMote]

Add default constructor to your TileEntity.

[hnsdieter]

Ive got a cnstructur is it a matter if i got parameters in there?

 

    private  ItemStack[] itemStacks;
    private  String invName;

    public BaseGeneratorTileEntity(int size, String displayName){
        itemStacks = new ItemStack[size];
        invName = displayName;
    }