[1.7.10] Custom Painting Rendering Half Block Off

[gottsch]

Hi.

 

I am having a rendering issue with a custom painting. I simply extended all the painting classes as vanilla as possible, just changing the texture image to use (and of course to point to my classes). However, the image always renders a half block higher than it should. If I make the wall higher, then it will climb, full blocks higher. Has anyone encountered this before? ( I found one thread for an older version, but it didn't really help me).

 

Thanks,

 

gottsch

 

MyItemHangingEntity:

 

  Reveal hidden contents

 

public class MyItemHangingEntity extends ItemHangingEntity {

 

@SuppressWarnings("rawtypes")

public MyItemHangingEntity(Class p_i45342_1_) {

super(p_i45342_1_);

this.setCreativeTab(Treasure.treasureTab);

}

 

/**

* Callback for item usage. If the item does something special on right clicking, he will have one of those. Return

* True if something happen and false if it don't. This is for ITEMS, not BLOCKS

*/

@Override

public boolean onItemUse(ItemStack p_77648_1_, EntityPlayer p_77648_2_, World p_77648_3_, int p_77648_4_, int p_77648_5_, int p_77648_6_, int p_77648_7_, float p_77648_8_, float p_77648_9_, float p_77648_10_)

{

if (p_77648_7_ == 0)

{

return false;

}

else if (p_77648_7_ == 1)

{

return false;

}

else

{

int i1 = Direction.facingToDirection[p_77648_7_];

EntityHanging entityhanging = this.createHangingEntity(p_77648_3_, p_77648_4_, p_77648_5_, p_77648_6_, i1);

Treasure.logger.debug("My entity hanging = " + entityhanging);

if (!p_77648_2_.canPlayerEdit(p_77648_4_, p_77648_5_, p_77648_6_, p_77648_7_, p_77648_1_))

{

return false;

}

else

{

if (entityhanging != null && entityhanging.onValidSurface())

{

if (!p_77648_3_.isRemote)

{

p_77648_3_.spawnEntityInWorld(entityhanging);

}

 

--p_77648_1_.stackSize;

}

 

return true;

}

}

}

 

/**

* Create the hanging entity associated to this item.

*/

private EntityHanging createHangingEntity(World p_82810_1_, int p_82810_2_, int p_82810_3_, int p_82810_4_, int p_82810_5_)

{

return (EntityHanging) new MyEntityPainting(p_82810_1_, p_82810_2_, p_82810_3_, p_82810_4_, p_82810_5_);

}

}

 

 

 

MyEntityPainting:

 

  Reveal hidden contents

public class MyEntityPainting extends EntityPainting {

 

public MyEntityPainting(World world) {

super(world);

}

 

public MyEntityPainting(World p_i1600_1_, int p_i1600_2_, int p_i1600_3_, int p_i1600_4_, int p_i1600_5_) {

super(p_i1600_1_, p_i1600_2_, p_i1600_3_, p_i1600_4_, p_i1600_5_);

}

}

 

 

 

MyRenderPainting: (exact coopy of RenderPainting except changing the texture)

 

  Reveal hidden contents

public class MyRenderPainting extends RenderPainting {

 

@Override

protected ResourceLocation getEntityTexture(Entity painting) {

return new ResourceLocation(Treasure.modid + ":textures/painting/paintings-16.png");

}

 

/**

* Actually renders the given argument. This is a synthetic bridge method, always casting down its argument and then

* handing it off to a worker function which does the actual work. In all probabilty, the class Render is generic

* (Render<T extends Entity) and this method has signature public void func_76986_a(T entity, double d, double d1,

* double d2, float f, float f1). But JAD is pre 1.5 so doesn't do that.

*/

public void doRender(EntityPainting p_76986_1_, double p_76986_2_, double p_76986_4_, double p_76986_6_, float p_76986_8_, float p_76986_9_)

{

GL11.glPushMatrix();

GL11.glTranslated(p_76986_2_, p_76986_4_, p_76986_6_);

GL11.glRotatef(p_76986_8_, 0.0F, 1.0F, 0.0F);

GL11.glEnable(GL12.GL_RESCALE_NORMAL);

this.bindEntityTexture(p_76986_1_);

EntityPainting.EnumArt enumart = p_76986_1_.art;

float f2 = 0.0625F;

GL11.glScalef(f2, f2, f2);

this.func_77010_a(p_76986_1_, 16, 16, 0, 0);

GL11.glDisable(GL12.GL_RESCALE_NORMAL);

GL11.glPopMatrix();

}

 

private void func_77010_a(EntityPainting p_77010_1_, int sizeX, int sizeY, int p_77010_4_, int p_77010_5_)

{

float f = (float)(-sizeX) / 2.0F;

float f1 = (float)(-sizeY) / 2.0F;

float f2 = 0.5F;

float f3 = 0.75F;

float f4 = 0.8125F;

float f5 = 0.0F;

float f6 = 0.0625F;

float f7 = 0.75F;

float f8 = 0.8125F;

float f9 = 0.001953125F;

float f10 = 0.001953125F;

float f11 = 0.7519531F;

float f12 = 0.7519531F;

float f13 = 0.0F;

float f14 = 0.0625F;

 

for (int i1 = 0; i1 < sizeX / 16; ++i1)

{

for (int j1 = 0; j1 < sizeY / 16; ++j1)

{

float f15 = f + (float)((i1 + 1) * 16);

float f16 = f + (float)(i1 * 16);

float f17 = f1 + (float)((j1 + 1) * 16);

float f18 = f1 + (float)(j1 * 16);

this.lighting(p_77010_1_, (f15 + f16) / 2.0F, (f17 + f18) / 2.0F);

float f19 = (float)(p_77010_4_ + sizeX - i1 * 16) / 256.0F;

float f20 = (float)(p_77010_4_ + sizeX - (i1 + 1) * 16) / 256.0F;

float f21 = (float)(p_77010_5_ + sizeY - j1 * 16) / 256.0F;

float f22 = (float)(p_77010_5_ + sizeY - (j1 + 1) * 16) / 256.0F;

Tessellator tessellator = Tessellator.instance;

tessellator.startDrawingQuads();

tessellator.setNormal(0.0F, 0.0F, -1.0F);

tessellator.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f20, (double)f21);

tessellator.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f19, (double)f21);

tessellator.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f19, (double)f22);

tessellator.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f20, (double)f22);

tessellator.setNormal(0.0F, 0.0F, 1.0F);

tessellator.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f3, (double)f5);

tessellator.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f4, (double)f5);

tessellator.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f4, (double)f6);

tessellator.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f3, (double)f6);

tessellator.setNormal(0.0F, 1.0F, 0.0F);

tessellator.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f7, (double)f9);

tessellator.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f8, (double)f9);

tessellator.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f8, (double)f10);

tessellator.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f7, (double)f10);

tessellator.setNormal(0.0F, -1.0F, 0.0F);

tessellator.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f7, (double)f9);

tessellator.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f8, (double)f9);

tessellator.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f8, (double)f10);

tessellator.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f7, (double)f10);

tessellator.setNormal(-1.0F, 0.0F, 0.0F);

tessellator.addVertexWithUV((double)f15, (double)f17, (double)f2, (double)f12, (double)f13);

tessellator.addVertexWithUV((double)f15, (double)f18, (double)f2, (double)f12, (double)f14);

tessellator.addVertexWithUV((double)f15, (double)f18, (double)(-f2), (double)f11, (double)f14);

tessellator.addVertexWithUV((double)f15, (double)f17, (double)(-f2), (double)f11, (double)f13);

tessellator.setNormal(1.0F, 0.0F, 0.0F);

tessellator.addVertexWithUV((double)f16, (double)f17, (double)(-f2), (double)f12, (double)f13);

tessellator.addVertexWithUV((double)f16, (double)f18, (double)(-f2), (double)f12, (double)f14);

tessellator.addVertexWithUV((double)f16, (double)f18, (double)f2, (double)f11, (double)f14);

tessellator.addVertexWithUV((double)f16, (double)f17, (double)f2, (double)f11, (double)f13);

tessellator.draw();

}

}

}

 

private void lighting(EntityPainting p_77008_1_, float p_77008_2_, float p_77008_3_)

{

int i = MathHelper.floor_double(p_77008_1_.posX);

int j = MathHelper.floor_double(p_77008_1_.posY + (double)(p_77008_3_ / 16.0F));

int k = MathHelper.floor_double(p_77008_1_.posZ);

 

if (p_77008_1_.hangingDirection == 2)

{

i = MathHelper.floor_double(p_77008_1_.posX + (double)(p_77008_2_ / 16.0F));

}

 

if (p_77008_1_.hangingDirection == 1)

{

k = MathHelper.floor_double(p_77008_1_.posZ - (double)(p_77008_2_ / 16.0F));

}

 

if (p_77008_1_.hangingDirection == 0)

{

i = MathHelper.floor_double(p_77008_1_.posX - (double)(p_77008_2_ / 16.0F));

}

 

if (p_77008_1_.hangingDirection == 3)

{

k = MathHelper.floor_double(p_77008_1_.posZ + (double)(p_77008_2_ / 16.0F));

}

 

int l = this.renderManager.worldObj.getLightBrightnessForSkyBlocks(i, j, k, 0);

int i1 = l % 65536;

int j1 = l / 65536;

OpenGlHelper.setLightmapTextureCoords(OpenGlHelper.lightmapTexUnit, (float)i1, (float)j1);

GL11.glColor3f(1.0F, 1.0F, 1.0F);

}

 

/**

* Actually renders the given argument. This is a synthetic bridge method, always casting down its argument and then

* handing it off to a worker function which does the actual work. In all probabilty, the class Render is generic

* (Render<T extends Entity) and this method has signature public void func_76986_a(T entity, double d, double d1,

* double d2, float f, float f1). But JAD is pre 1.5 so doesn't do that.

*/

public void doRender(Entity p_76986_1_, double p_76986_2_, double p_76986_4_, double p_76986_6_, float p_76986_8_, float p_76986_9_)

{

this.doRender((MyEntityPainting)p_76986_1_, p_76986_2_, p_76986_4_, p_76986_6_, p_76986_8_, p_76986_9_);

}

}

 

 

 

In MyMod:

 

  Reveal hidden contents

int entityID = EntityRegistry.findGlobalUniqueEntityId();

 

EntityRegistry.registerModEntity(MyEntityPainting.class, "myEntityPainting", entityID, instance, 128, 1, true);

 

 

 

In ClientProxy:

 

  Reveal hidden contents

RenderingRegistry.registerEntityRenderingHandler(MyEntityPainting.class, new MyRenderPainting());

 

 

Image:

https://dl.dropboxusercontent.com/u/67605173/2014-11-01_20.30.44.png[/img]

[yariplus]

this.func_77010_a(p_76986_1_, 16, 16, 0, 0);

 

This line is not the same, try using the original maybe?

 

this.func_77010_a(p_76986_1_, enumart.sizeX, enumart.sizeY, enumart.offsetX, enumart.offsetY);

[gottsch]

Thanks, but that line is referring to the dimensions and offset of the image to display on the painting.  The enumart is referring to a property of EntityPainting:

 

    public static enum EnumArt
    {
        Kebab("Kebab", 16, 16, 0, 0),
...

So I just used the values to always use the first image.

[Manslaughter777]

Firstly, u should rename your params, it will make everything a lot easier.

And secondly, when u hover over the painting is the hitbox around the painting or is the hitbox half a block down? (Like the stone)

[gottsch]

  Quote

Firstly, u should rename your params, it will make everything a lot easier.

Yes, I typically do.  I just threw this "basic" set of classes together to get it to work, as the actual version in my mod does the same thing.

 

  Quote

And secondly, when u hover over the painting is the hitbox around the painting or is the hitbox half a block down? (Like the stone)

Good question.  I don't see the hitbox (black wireframe) even highlight when I hover over the painting.  The block's behind the painting will show their hitbox as if the painting wasn't there.

[JavaMatrix]

In your item, try changing:

EntityHanging entityhanging = this.createHangingEntity(p_77648_3_, p_77648_4_, p_77648_5_, p_77648_6_, i1);

to

EntityHanging entityhanging = this.createHangingEntity(p_77648_3_, p_77648_4_, p_77648_5_ + 0.5, p_77648_6_, i1);

[Manslaughter777]

  On 11/2/2014 at 10:06 PM, gottsch said:

  Quote

Firstly, u should rename your params, it will make everything a lot easier.

Yes, I typically do.  I just threw this "basic" set of classes together to get it to work, as the actual version in my mod does the same thing.

 

  Quote

And secondly, when u hover over the painting is the hitbox around the painting or is the hitbox half a block down? (Like the stone)

Good question.  I don't see the hitbox (black wireframe) even highlight when I hover over the painting.  The block's behind the painting will show their hitbox as if the painting wasn't there.

Sorry that was my mistake, pretty sure entities don't have hit boxes

[gottsch]

  Quote

In your item, try changing:

EntityHanging entityhanging = this.createHangingEntity(p_77648_3_, p_77648_4_, p_77648_5_, p_77648_6_, i1);

to

EntityHanging entityhanging = this.createHangingEntity(p_77648_3_, p_77648_4_, p_77648_5_ + 0.5, p_77648_6_, i1);

Thanks, but these params are ints, so this value will just get truncated back to the whole int value.  But for good measure, I attempted with +/-1.  The outcome was the same (just a full block in a different direction).

 

Just to make clear, the painting initially renders in the correct place, but then almost immediately shifts upwards.  If I add more block to make a higher wall, it will shift even higher depending on the way I look at it.

[Sokaya]

Anybody fixed that?

[BlackCrafer666]

I copypaste this code, but my item spawn paintings with random default textures. Whats wrong?