Jump to content

Recommended Posts

Posted

I'm making a mod. I wanted to make the code look nicer and make it easier. I tried to make like and API that will register my block and item and the crafting recipe. Here's an example:

 

Methods in the API class:

 

public static void createPair(Block pairBlock, Item pairItem, Item pairSubItem, String pairName) {	
	pairBlock = new PairBlock().setHardness(0.5F).setStepSound(Block.soundTypeCloth).setBlockName(pairName).setBlockTextureName(pairName);
	pairItem = new PairItem(pairBlock).setMaxStackSize(1).setUnlocalizedName(pairName).setTextureName(pairName); 

	registerBlock(pairBlock, pairName);
	registerItem(pairItem, pairName);

	GameRegistry.addRecipe(new ItemStack(pairItem), new Object[]{"B", "S", "B", 'B', pairBlock, 'S', pairSubItem});
}
private static void registerBlock(Block block, String name) {
	GameRegistry.registerBlock(block, block.getUnlocalizedName());
	LanguageRegistry.addName(block, name);
}

private static void registerItem(Item item, String name) {
	GameRegistry.registerItem(item, item.getUnlocalizedName());
	LanguageRegistry.addName(item, name);
}

 

 

And this is in my main class:

PairAPI.createPair(PairBlockTest, PairItemTest, ItemSubTest, "pair");

 

But Minecraft just keep crashing. Where am I making a mistake?

_         

___ ___| |__  _ __ 

/ __/ __| '_ \| '_ \

\__ \__ \ | | | | | |

|___/___/_| |_|_| |_|

Posted

I also noticed that when you use addRecipe, you do "B", instead of " B ".. spaces matter, as there should be 3 chars.. space = no item in the crafting recipe.

 

By the way.. you should post the crash log and the main class.. we aren't wizards

I try my best, so apologies if I said something obviously stupid!

Posted

 

[20:08:15] [main/INFO]: Loading tweak class name cpw.mods.fml.common.launcher.FMLTweaker

[20:08:16] [main/INFO]: Using primary tweak class name cpw.mods.fml.common.launcher.FMLTweaker

[20:08:16] [main/INFO]: Calling tweak class cpw.mods.fml.common.launcher.FMLTweaker

[20:08:17] [main/INFO]: Forge Mod Loader version 7.10.1.1152 for Minecraft 1.7.10 loading

[20:08:17] [main/INFO]: Java is Java HotSpot Client VM, version 1.7.0_51, running on Windows 7:x86:6.1, installed at C:\Program Files\Java\jre7

[20:08:17] [main/INFO]: Managed to load a deobfuscated Minecraft name- we are in a deobfuscated environment. Skipping runtime deobfuscation

[20:08:18] [main/INFO]: Loading tweak class name cpw.mods.fml.common.launcher.FMLInjectionAndSortingTweaker

[20:08:18] [main/INFO]: Loading tweak class name cpw.mods.fml.common.launcher.FMLDeobfTweaker

[20:08:18] [main/INFO]: Calling tweak class cpw.mods.fml.common.launcher.FMLInjectionAndSortingTweaker

[20:08:18] [main/INFO]: Calling tweak class cpw.mods.fml.common.launcher.FMLInjectionAndSortingTweaker

[20:08:18] [main/INFO]: Calling tweak class cpw.mods.fml.relauncher.CoreModManager$FMLPluginWrapper

[20:08:22] [main/ERROR]: The binary patch set is missing. Either you are in a development environment, or things are not going to work!

[20:09:22] [main/ERROR]: The minecraft jar file:/C:/Users/root/.gradle/caches/minecraft/net/minecraftforge/forge/1.7.10-10.13.0.1152/forgeSrc-1.7.10-10.13.0.1152.jar!/net/minecraft/client/ClientBrandRetriever.class appears to be corrupt! There has been CRITICAL TAMPERING WITH MINECRAFT, it is highly unlikely minecraft will work! STOP NOW, get a clean copy and try again!

[20:09:22] [main/ERROR]: FML has been ordered to ignore the invalid or missing minecraft certificate. This is very likely to cause a problem!

[20:09:22] [main/ERROR]: Technical information: ClientBrandRetriever was at jar:file:/C:/Users/root/.gradle/caches/minecraft/net/minecraftforge/forge/1.7.10-10.13.0.1152/forgeSrc-1.7.10-10.13.0.1152.jar!/net/minecraft/client/ClientBrandRetriever.class, there were 0 certificates for it

[20:09:22] [main/ERROR]: FML appears to be missing any signature data. This is not a good thing

[20:09:22] [main/INFO]: Calling tweak class cpw.mods.fml.relauncher.CoreModManager$FMLPluginWrapper

[20:09:22] [main/INFO]: Calling tweak class cpw.mods.fml.common.launcher.FMLDeobfTweaker

[20:09:30] [main/INFO]: Launching wrapped minecraft {net.minecraft.client.main.Main}

[20:09:58] [main/INFO]: Setting user: ForgeDevName

[20:10:23] [Client thread/INFO]: LWJGL Version: 2.9.1

[20:10:39] [Client thread/INFO]: Attempting early MinecraftForge initialization

[20:10:39] [Client thread/INFO]: MinecraftForge v10.13.0.1152 Initialized

[20:10:40] [Client thread/INFO]: Replaced 182 ore recipies

[20:10:41] [Client thread/INFO]: Completed early MinecraftForge initialization

[20:10:53] [Client thread/INFO]: Searching G:\ytrujeauj\fghdhjgfs 2\1.7.10\PieCraft\eclipse\mods for mods

[20:11:05] [Client thread/ERROR]: FML has detected a mod that is using a package name based on 'net.minecraft.src' : net.minecraft.src.FMLRenderAccessLibrary. This is generally a severe programming error.  There should be no mod code in the minecraft namespace. MOVE YOUR MOD! If you're in eclipse, select your source code and 'refactor' it into a new package. Go on. DO IT NOW!

[20:11:17] [Client thread/INFO]: Forge Mod Loader has identified 4 mods to load

[20:11:23] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:23] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:23] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:23] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:23] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:23] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:23] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:23] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:23] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:23] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

[20:11:24] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

Nov 04, 2014 8:11:24 PM com.google.common.eventbus.EventBus$LoggingSubscriberExceptionHandler handleException

SEVERE: Could not dispatch event: FMLMod:piecraft{5.3} to public void cpw.mods.fml.common.FMLModContainer.constructMod(cpw.mods.fml.common.event.FMLConstructionEvent)

[20:11:24] [Client thread/ERROR]: Fatal errors were detected during the transition from CONSTRUCTING to PREINITIALIZATION. Loading cannot continue

[20:11:24] [Client thread/ERROR]:

mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) Unloaded->Constructed

FML{7.10.1.1152} [Forge Mod Loader] (forgeSrc-1.7.10-10.13.0.1152.jar) Unloaded->Constructed

Forge{10.13.0.1152} [Minecraft Forge] (forgeSrc-1.7.10-10.13.0.1152.jar) Unloaded->Constructed

piecraft{5.3} [§6PieCraft] (bin) Unloaded->Errored

[20:11:24] [Client thread/ERROR]: The following problems were captured during this phase

[20:11:24] [Client thread/ERROR]: Caught exception from piecraft

java.lang.NullPointerException

at com.nuclearbanana.piecraft.PieCraft.registerItem(PieCraft.java:509) ~[bin/:?]

at com.nuclearbanana.piecraft.PieCraft.<init>(PieCraft.java:499) ~[bin/:?]

at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:1.7.0_51]

at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) ~[?:1.7.0_51]

at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) ~[?:1.7.0_51]

at java.lang.reflect.Constructor.newInstance(Unknown Source) ~[?:1.7.0_51]

at java.lang.Class.newInstance(Unknown Source) ~[?:1.7.0_51]

at cpw.mods.fml.common.ILanguageAdapter$JavaAdapter.getNewInstance(ILanguageAdapter.java:173) ~[forgeSrc-1.7.10-10.13.0.1152.jar:?]

at cpw.mods.fml.common.FMLModContainer.constructMod(FMLModContainer.java:486) ~[forgeSrc-1.7.10-10.13.0.1152.jar:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_51]

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_51]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_51]

at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_51]

at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74) ~[guava-16.0.jar:?]

at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47) ~[guava-16.0.jar:?]

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322) ~[guava-16.0.jar:?]

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304) ~[guava-16.0.jar:?]

at com.google.common.eventbus.EventBus.post(EventBus.java:275) ~[guava-16.0.jar:?]

at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:208) ~[forgeSrc-1.7.10-10.13.0.1152.jar:?]

at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:187) ~[forgeSrc-1.7.10-10.13.0.1152.jar:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_51]

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_51]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_51]

at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_51]

at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74) ~[guava-16.0.jar:?]

at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47) ~[guava-16.0.jar:?]

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322) ~[guava-16.0.jar:?]

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304) ~[guava-16.0.jar:?]

at com.google.common.eventbus.EventBus.post(EventBus.java:275) ~[guava-16.0.jar:?]

at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:118) [LoadController.class:?]

at cpw.mods.fml.common.Loader.loadMods(Loader.java:492) [Loader.class:?]

at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:204) [FMLClientHandler.class:?]

at net.minecraft.client.Minecraft.startGame(Minecraft.java:532) [Minecraft.class:?]

at net.minecraft.client.Minecraft.run(Minecraft.java:941) [Minecraft.class:?]

at net.minecraft.client.main.Main.main(Main.java:164) [Main.class:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_51]

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_51]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_51]

at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_51]

at net.minecraft.launchwrapper.Launch.launch(Launch.java:134) [launchwrapper-1.9.jar:?]

at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.9.jar:?]

[20:11:24] [Client thread/INFO]: Reloading ResourceManager: Default, FMLFileResourcePack:Forge Mod Loader, FMLFileResourcePack:Minecraft Forge, FMLFileResourcePack:§6PieCraft

---- Minecraft Crash Report ----

// I feel sad now :(

 

Time: 11/4/14 8:11 PM

Description: Initializing game

 

java.lang.NullPointerException: Initializing game

at com.nuclearbanana.piecraft.PieCraft.registerItem(PieCraft.java:509)

at com.nuclearbanana.piecraft.PieCraft.<init>(PieCraft.java:499)

at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)

at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)

at java.lang.reflect.Constructor.newInstance(Unknown Source)

at java.lang.Class.newInstance(Unknown Source)

at cpw.mods.fml.common.ILanguageAdapter$JavaAdapter.getNewInstance(ILanguageAdapter.java:173)

at cpw.mods.fml.common.FMLModContainer.constructMod(FMLModContainer.java:486)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)

at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)

at com.google.common.eventbus.EventBus.post(EventBus.java:275)

at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:208)

at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:187)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)

at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)

at com.google.common.eventbus.EventBus.post(EventBus.java:275)

at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:118)

at cpw.mods.fml.common.Loader.loadMods(Loader.java:492)

at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:204)

at net.minecraft.client.Minecraft.startGame(Minecraft.java:532)

at net.minecraft.client.Minecraft.run(Minecraft.java:941)

at net.minecraft.client.main.Main.main(Main.java:164)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at net.minecraft.launchwrapper.Launch.launch(Launch.java:134)

at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

 

 

A detailed walkthrough of the error, its code path and all known details is as follows:

---------------------------------------------------------------------------------------

 

-- Head --

Stacktrace:

at com.nuclearbanana.piecraft.PieCraft.registerItem(PieCraft.java:509)

at com.nuclearbanana.piecraft.PieCraft.<init>(PieCraft.java:499)

at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)

at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)

at java.lang.reflect.Constructor.newInstance(Unknown Source)

at java.lang.Class.newInstance(Unknown Source)

at cpw.mods.fml.common.ILanguageAdapter$JavaAdapter.getNewInstance(ILanguageAdapter.java:173)

at cpw.mods.fml.common.FMLModContainer.constructMod(FMLModContainer.java:486)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)

at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)

at com.google.common.eventbus.EventBus.post(EventBus.java:275)

at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:208)

at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:187)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)

at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)

at com.google.common.eventbus.EventBus.post(EventBus.java:275)

at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:118)

at cpw.mods.fml.common.Loader.loadMods(Loader.java:492)

at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:204)

at net.minecraft.client.Minecraft.startGame(Minecraft.java:532)

 

-- Initialization --

Details:

Stacktrace:

at net.minecraft.client.Minecraft.run(Minecraft.java:941)

at net.minecraft.client.main.Main.main(Main.java:164)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at net.minecraft.launchwrapper.Launch.launch(Launch.java:134)

at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

 

-- System Details --

Details:

Minecraft Version: 1.7.10

Operating System: Windows 7 (x86) version 6.1

Java Version: 1.7.0_51, Oracle Corporation

Java VM Version: Java HotSpot Client VM (mixed mode), Oracle Corporation

Memory: 959727912 bytes (915 MB) / 1060372480 bytes (1011 MB) up to 1060372480 bytes (1011 MB)

JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M

AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used

IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0

FML: MCP v9.05 FML v7.10.1.1152 Minecraft Forge 10.13.0.1152 4 mods loaded, 4 mods active

mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) Unloaded->Constructed

FML{7.10.1.1152} [Forge Mod Loader] (forgeSrc-1.7.10-10.13.0.1152.jar) Unloaded->Constructed

Forge{10.13.0.1152} [Minecraft Forge] (forgeSrc-1.7.10-10.13.0.1152.jar) Unloaded->Constructed

piecraft{5.3} [§6PieCraft] (bin) Unloaded->Errored

Launched Version: 1.7

LWJGL: 2.9.1

OpenGL: AMD Radeon HD 6290 Graphics GL version 4.1.11251 Compatibility Profile Context, ATI Technologies Inc.

GL Caps: Using GL 1.3 multitexturing.

Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.

Anisotropic filtering is supported and maximum anisotropy is 16.

Shaders are available because OpenGL 2.1 is supported.

 

Is Modded: Definitely; Client brand changed to 'fml,forge'

Type: Client (map_client.txt)

Resource Packs: []

Current Language: ~~ERROR~~ NullPointerException: null

Profiler Position: N/A (disabled)

Vec3 Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used

Anisotropic Filtering: Off (1)

#@!@# Game crashed! Crash report saved to: #@!@# G:\ytrujeauj\fghdhjgfs 2\1.7.10\PieCraft\eclipse\.\crash-reports\crash-2014-11-04_20.11.25-client.txt

 

 

_         

___ ___| |__  _ __ 

/ __/ __| '_ \| '_ \

\__ \__ \ | | | | | |

|___/___/_| |_|_| |_|

Posted
package com.nuclearbanana.piecraft;

@Mod(modid = PieCraft.modid, name = "PieCraft", version = "5.3")

public class PieCraft {

public static final String modid = "piecraft";

@Instance(modid)
public static PieCraft instance;

@SidedProxy(clientSide = "com.nuclearbanana.piecraft.ClientBanana", serverSide = "com.nuclearbanana.piecraft.ServerBanana")
public static ServerBanana proxy;

public static CreativeTabs pieTab = new CreativeTabs("pieTab"){
	public Item getTabIconItem() {
		return ItemApplePie;
	}		
};

public static Block PairBlock;
public static Item PairItem;
public static Item PairSubItem; 

@EventHandler
public static void preLoad(FMLPreInitializationEvent PreEvent){
	proxy.renderInformation();
}

@EventHandler
public void init(FMLInitializationEvent e) {

}

@EventHandler
public void loadServer(FMLServerStartingEvent event) {
}

public PieCraft() {   
        //registerBlock(PairBlock, "Pair Block");
        //registerItem(PairItem, "Pair Item");
        PieAPI.createPair(PairBlock, PairItem, PairSubItem, "pair");
}

public static void registerBlock(Block block, String name) {
	GameRegistry.registerBlock(block, block.getUnlocalizedName());
	LanguageRegistry.addName(block, name);
}

public static void registerItem(Item item, String name) {
	GameRegistry.registerItem(item, item.getUnlocalizedName());
	LanguageRegistry.addName(item, name);
}
}

_         

___ ___| |__  _ __ 

/ __/ __| '_ \| '_ \

\__ \__ \ | | | | | |

|___/___/_| |_|_| |_|

Posted

Ah, yeah, that's not how Java works. If you pass the fields to createPair and then alter the value in createPair you are only altering the local variable (the parameter) in createPair. The Field is not changed.

 

Also, this:

[20:11:23] [Client thread/WARN]: The mod FMLMod:piecraft{5.3} is attempting to register a block whilst it it being constructed. This is bad modding practice - please use a proper mod lifecycle event.

 

Don't register your blocks/items in your constructor, in fact, you shouldn't even have one. Do that stuff in your preInit.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Posted

please use a proper mod lifecycle event.

 

Pre-initialization is where you should be constructing your block/item and after that, you should register them. If not, you get all sorts of errors. Your items are null, your blocks are null and you're field is not being changed, like disesieben07 was saying. That's why you're getting a NPE.

 

 

As a side note (nothing to do with the issue, but it's a bad practice), stop being lazy and don't use LanguageRegistry anymore. Use the en_US.lang (or whatever lang file you use).

-Mitchellbrine

 

Minecraft can do ANYTHING, it's coded in Java and you got the full power of Java behind you when you code. So nothing is impossible.

It may be freaking fucking hard though, but still possible ;)

 

If you create a topic on Modder Support, live by this motto:

I don't want your charity, I want your information

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.