Jump to content

CanProcess() method returning false when it shouldn't do


Roboguy99

Recommended Posts

I've just changed my code around a bit in my mod so to make room for faster development. Essentially I've created a template off of which I can build similar machines to my pre-existing ones (3-slot machines which work similar to a vanilla furnace). In doing so, I have broken the only machine which currently uses the template. Previously you placed cobblestone in the slot with id 1, wheat in the slot with the id 0 and the output comes in slot 3 after a processing time. Now though, my canProcess() method is always returning false. I've narrowed it down to the problem being with the first if statement in the method, but this worked before. Please can someone help? My code is below and any further code can be found at https://github.com/Roboguy99/Food-Tech if you need it. Thanks in advance.

 

TileGrindstone code:

 

 

package roboguy99.foodTech.common.tile;

import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import roboguy99.foodTech.common.tile.prefab.TileThreeSlotMachine;
import roboguy99.foodTech.util.recipe.GrindstoneRecipes;

public class TileGrindstone extends TileThreeSlotMachine
{	
private ItemStack[] slot = new ItemStack[3];

private static final int MAX_STONE = 16;
private static final int PROCESS_TIME = 200;
public int stone = 0;
private int processTimeRemaining;
public int timeSpentProcessing;

public void updateEntity()
{	
	boolean shouldMarkDirty = false;
	ItemStack slotStone = getStackInSlot(1);

	//Check for stone in buffer and fill from itemstack in bottom slot
	if(slotStone != null && slotStone.getItem() == Item.getItemFromBlock(Blocks.cobblestone) && stone < MAX_STONE)
	{
		this.stone += MAX_STONE; //1 cobblestone = 1 full tank
		slotStone.stackSize--;
		shouldMarkDirty = true;

		if (slotStone.stackSize <= 0)
        {
            slotStone = null;
            this.setInventorySlotContents(1, null);
            shouldMarkDirty = true;
        }
	}

	//Check for inventory contents and process any items
	if(!worldObj.isRemote && this.canProcess() && this.stone >= 1 && this.processTimeRemaining == 0)
	{
		this.processItem();
		this.processTimeRemaining = TileGrindstone.PROCESS_TIME;
		this.timeSpentProcessing = 0;
	}
	if(this.processTimeRemaining > 0 && this.canProcess()) 
	{
		this.processTimeRemaining--;
		this.timeSpentProcessing++;
	}

	if(shouldMarkDirty)
	{
		this.markDirty();
	}
}

public int getStoneScaled(int scaled)
{
	return (int) (this.stone * scaled / TileGrindstone.MAX_STONE);
}

public int getProgressScaled(int scaled)
{
	return (int) (this.timeSpentProcessing * scaled / TileGrindstone.PROCESS_TIME);
}

/**
     * Returns true if the grindstone can smelt an item, i.e. has a source item, destination stack isn't full, etc.
     */
    protected boolean canProcess()
    {
    	if (this.slot[0] == null || this.stone == 0)
        {
            return false;
        }
        else //TODO switch if and else around
        {
        	ItemStack itemstack = GrindstoneRecipes.processing().getProcessResult(this.slot[0]);
            if (itemstack == null) return false;
            if (this.slot[2] == null) return true;
            if (!this.slot[2].isItemEqual(itemstack)) return false;
            int result = slot[2].stackSize + itemstack.stackSize;
            return result <= getInventoryStackLimit() && result <= this.slot[2].getMaxStackSize(); //Forge BugFix: Make it respect stack sizes properly.
        }
    }

    /**
     * Turn one item from the grindstone source stack into the appropriate processed item in the furnace result stack
     */
    public void processItem()
    {	
    	this.processTimeRemaining = TileGrindstone.PROCESS_TIME;
    	
    	if(this.canProcess())
    {
    		ItemStack itemstack = GrindstoneRecipes.processing().getProcessResult(this.slot[0]);

        if (this.slot[2] == null)
        {
            this.slot[2] = itemstack.copy();
        }
        else if (this.slot[2].getItem() == itemstack.getItem())
        {
            this.slot[2].stackSize += itemstack.stackSize; // Forge BugFix: Results may have multiple items
        }

        --this.slot[0].stackSize;
        --this.stone;

        if (this.slot[0].stackSize <= 0)
        {
            this.slot[0] = null;
        }
    }	
    }
}

 

 

 

Template code:

 

 

package roboguy99.foodTech.common.tile.prefab;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.ISidedInventory;
import net.minecraft.item.ItemStack;

/**
* Used for machines which have three slots, similar to that of a vanilla furnace
* @author Jake
*
*/
public abstract class TileThreeSlotMachine extends Tile implements ISidedInventory
{
private ItemStack[] slot = new ItemStack[3];
private String customName;

@Override
public ItemStack decrStackSize(int i, int j) 
{
		if(this.slot[i] != null)
		{
			ItemStack itemStack;

			if(this.slot[i].stackSize <= j)
			{
				itemStack = this.slot[i];
				this.slot[i] = null;
				return itemStack;
			}
			else
			{
				itemStack = this.slot[i].splitStack(j);

				if(this.slot[i].stackSize == 0)
				{
					this.slot[i] = null;
					this.setInventorySlotContents(i, null);
				}

				return itemStack;
			}
		}

	return null;
}

public ItemStack getStackInSlot(int i) 
{
	return this.slot[i];
}

public ItemStack getStackInSlotOnClosing(int i) 
{
	if(this.slot[i] != null)
	{
		ItemStack itemStack = this.slot[i];
		this.slot[i] = null;
		return itemStack;
	}

	return null;
}

public boolean isItemValidForSlot(int slot, ItemStack itemStack)
{
	return slot == 2 ? false : true;
}

public boolean isUseableByPlayer(EntityPlayer entityPlayer) 
{
	return true;
}

public void setInventorySlotContents(int i, ItemStack itemStack) 
{
	this.slot[i] = itemStack;

	if(itemStack != null && itemStack.stackSize > this.getInventoryStackLimit())
	{
		itemStack.stackSize = this.getInventoryStackLimit();
	}
}

public boolean canExtractItem(int i, ItemStack var2, int j) 
{
	return true;
}

public boolean canInsertItem(int slot, ItemStack itemStack, int side) 
{
	return this.isItemValidForSlot(slot, itemStack);
}

public int[] getAccessibleSlotsFromSide(int i) 
{
	return null;
}

public String getInventoryName() 
{
	return this.hasCustomInventoryName() ? this.customName : "container.threeSlotMachine";
}

public boolean hasCustomInventoryName() 
{
	return this.customName != null && this.customName.length() > 0;
}

public int getInventoryStackLimit() 
{
	return 64;
}

public int getSizeInventory() 
{
	return this.slot.length;
}

public void openInventory() {}
public void closeInventory() {}

protected abstract boolean canProcess();
protected abstract void processItem();
}

 

 

I have no idea what I'm doing.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.