Hi all,

 

I'm attempting to create a block that during the day, has a fairly dull texture, but at night changes to an animated texture, lights up and produces particles. So far I've managed to get a single instance of the block to match this behaviour perfectly via metadata, but I can only get to work on one instance. If multiple instances are present, it seems that only one is chosen (seemingly randomly) for an update.

 

I've added the relevant classes below, anyone have any idea how I can get all instances of these blocks to update correctly?

 

Here's the block class

import java.util.Random;

import net.minecraft.block.material.Material;
import net.minecraft.client.Minecraft;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.IIcon;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import uk.co.thisishillman.particles.EntityFXColoredDust;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class BlockMetalPrecious extends CustomBlock {

    private static String[] names;

    private boolean isNight;
    
public BlockMetalPrecious(Material mat, String unlocalizedName, String... subNames) {
	super(mat, unlocalizedName, subNames);
	this.names = subNames;

	//this.setTickRandomly(true);
}

@Override
public void registerRecipe() {
	//TODO
}

@Override
public Item getItemDropped(int meta, Random rand, int fortune) {
        return Item.getItemFromBlock(this);
    }

@Override
public void randomDisplayTick(World world, int x, int y, int z, Random rand) {
	boolean previousState = isNight;
	int meta = world.getBlockMetadata(x, y, z);
	long worldTime = world.getWorldTime();

	if( (worldTime > 13000) && (worldTime < 23000) ) {
		isNight = true;
	} else {
		isNight = false;
	}

	if(previousState != isNight) {
		if(meta == 2 || meta == 3) {

			if(!previousState && isNight) {
				world.setBlock(x, y, z, this, 3, 2);

			} else if(previousState && !isNight) {
				world.setBlock(x, y, z, this, 2, 2);
			}

			world.notifyBlockChange(x, y, z, this);
			System.out.println("Updated block at: " + x + ", " + y + ", " + z);
			//world.markBlockForUpdate(x, y, z);
		}
	}

	if(isNight && meta == 3 && rand.nextInt(10) <= 2) {
		spawnParticle(world, x, y, z);
	}
}

private void spawnParticle(World world, int x, int y, int z) {
        Random random = world.rand;

        for(int side = 0; side < 6; ++side) {
        	
            double d1 = (double) ((float) x + random.nextFloat());
            double d2 = (double) ((float) y + random.nextFloat());
            double d3 = (double) ((float) z + random.nextFloat());

            if(side == 0 && !world.getBlock(x, y + 1, z).isOpaqueCube()) {
                d2 = (double) (y + 1) + 0.0625;
            }

            if(side == 1 && !world.getBlock(x, y - 1, z).isOpaqueCube()) {
                d2 = (double) (y + 0) - 0.0625;
            }

            if(side == 2 && !world.getBlock(x, y, z + 1).isOpaqueCube()) {
                d3 = (double) (z + 1) + 0.0625;
            }

            if(side == 3 && !world.getBlock(x, y, z - 1).isOpaqueCube()) {
                d3 = (double) (z + 0) - 0.0625;
            }

            if(side == 4 && !world.getBlock(x + 1, y, z).isOpaqueCube()) {
                d1 = (double) (x + 1) + 0.0625;
            }

            if(side == 5 && !world.getBlock(x - 1, y, z).isOpaqueCube()) {
                d1 = (double) (x + 0) - 0.0625;
            }

            if(d1 < (double)x || d1 > (double)(x + 1) || d2 < 0.0 || d2 > (double)(y + 1) || d3 < (double)z || d3 > (double)(z + 1)) {
            	
            	EntityFXColoredDust dust = new EntityFXColoredDust(world, d1, d2, d3, 0.0f, 0.0f, 0.0f);
            	dust.setColor(97f/255f, 1f, 227f/255f);
            	Minecraft.getMinecraft().effectRenderer.addEffect(dust);
            }
        }
    }

@Override
public void updateTick(World world, int x, int y, int z, Random rand) {
	randomDisplayTick(world, x, y, z, new Random());
	world.scheduleBlockUpdate(x, y, z, this, 20);
}

@Override
public int getLightValue(IBlockAccess access, int x, int y, int z) {
	int meta = access.getBlockMetadata(x, y, z);
	if(meta == 3) return 15;

	return super.getLightValue(access, x, y, z);
}

@Override
@SideOnly(Side.CLIENT)
public void registerBlock() {
	GameRegistry.registerBlock(this, ItemBlockMetalPrecious.class, super.getUnlocalizedName());
}

@Override
@SideOnly(Side.CLIENT)
    public IIcon getIcon(int side, int meta) {
	return super.getIcon(side, meta);
    }

}
//End of class.

 

And it's abstract parent...

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.IIcon;
import net.minecraft.world.World;
import uk.co.thisishillman.CustomTabs;
import uk.co.thisishillman.Velociraptor;
import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public abstract class CustomBlock extends Block {

/** Viewable block name (without Mod-ID) */
private final String superName;

/** Viewable sub-block names (without Mod-ID) */
private String[] subNames;

/* */
@SideOnly(Side.CLIENT)
private IIcon[] blockIcons;

/** Initialise a new CustomBlock and register it's unlocalised name.
 * 
 * @param name Viewable block name (without Mod-ID).
 */
public CustomBlock(Material mat, String unlocalizedName, String... subNames) {
	super(mat);
	superName = unlocalizedName;

	if(subNames != null) {
		this.subNames = subNames;
	}

	setBlockName(unlocalizedName);
	setBlockBounds(0.0f, 0.0f, 0.0f, 1.0f, 1.0f, 1.0f);
	setCreativeTab(CustomTabs.materialsTab);
}

@Override
public boolean isOpaqueCube() {
	return true;
}

@Override
public int damageDropped (int metadata) {
	return metadata;
}

@SideOnly(Side.CLIENT)
@Override
public void registerBlockIcons(IIconRegister iconRegister) {
	if(subNames == null) {
		blockIcons = new IIcon[1];
		blockIcons[0] = iconRegister.registerIcon(Velociraptor.ID + ":" + superName);

	} else {
		blockIcons = new IIcon[subNames.length];
		for(int i = 0; i < subNames.length; i++) {
			blockIcons[i] = iconRegister.registerIcon(Velociraptor.ID + ":" + superName + "." + subNames[i]);
		}
	}
}

@Override
@SideOnly(Side.CLIENT)
    public IIcon getIcon(int side, int meta) {
	return blockIcons[meta];
    }

@Override
public ArrayList<ItemStack> getDrops(World world, int x, int y, int z, int metadata, int fortune) {
        return new ArrayList<ItemStack>(Arrays.asList(new ItemStack(this, 1, metadata)));
    }

@SideOnly(Side.CLIENT)
@Override
public void getSubBlocks(Item item, CreativeTabs creativeTabs, List list) {
	for(int i = 0; i < subNames.length; i++) {
		list.add(new ItemStack(this, 1, i));
	}
}

/** This method should call the GameRegistry.registerItem() method to 
 * register the item within MineCraft.
 * 
 * @param The mod-unique name of the item.
 */
public abstract void registerBlock();

/** This method should call the GameRegistry class to register the 
 * appropriate (if any) crafting recipe(s). */
public abstract void registerRecipe();

}
//End of class.

 

And the ItemBlock class if that helps...

import net.minecraft.block.Block;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemStack;

public class ItemBlockMetalPrecious extends ItemBlock {

/** Viewable sub-block names (without Mod-ID) */
private String[] subNames = new String[] {"mithril", "tilkal", "ithildin_unlit", "ithildin_lit"};

public ItemBlockMetalPrecious(Block block) {
	super(block);
	setHasSubtypes(true);
}

@Override
public int getMetadata(int damageValue) {
	return damageValue;
}

@Override
public String getUnlocalizedName(ItemStack itemstack) {
	if(subNames == null) {
		return getUnlocalizedName();
	}
	return getUnlocalizedName() + "." + subNames[itemstack.getItemDamage()];
}


}
//End of class.

Oi!  Blocks are singleton classes!  This won't work!

 

if(previousState != isNight) <-- the first block will see this as true, then the second block will see it as false!

 

You can't store additional data at the block level, that's what metadata is for.  If metadata isn't sufficient, then you must use a TileEntity.

Ah, that'd explain it. Thanks!

You can basically also use the metadata like:

isNight & previousState  metadata = 1

isNight & !previousState  metadata = 2

!isNight & previousState  metadata = 3

!isNight & !previousState  metadata = 4