[1.6.4] Block playing a sound when powered (not working)

[alphawolf918]

Hello everyone. My friends and I have a 1.6.4 Tekkit server and I have been asked to make a mod using sirens that let off alarms when powered. Yes, I know that Atomic Science has this, but we want just the sirens from it and I've been able to do everything so far except get the sound to work. Right now either 1 of 2 things happens: either A.) it will play as soon as I set it down, without power, or B.) it will not play at all, even when it has power. Seems I can't find a happy medium between these two.

 

The current code can be found here: https://github.com/alphawolf918/SirenMod

 

Thank you in advance to anyone who helps, I just need help with this small thing and then I'll be good. I look forward to advice. Also, please no vague answers. If you don't know or don't want to 'waste your time with this', then please don't respond. I'm only interested in people that will actually give thorough advice. Thanks, again.

 

edit:: Nevermind, got it fixed.

[TheGreyGhost]

Hi

 

You are using static variables for the siren state.  That will for sure lead to problems.

Either remove the static, so eg your ironSirenOn and ironSirenOff have their own siren state, or combine ironSirenOn and ironSirenOff into a single ironSiren and use block metadata to store whether it is on or off.

 

You probably don't need the make your siren a BlockContainer either.  Just extend Block instead.

 

-TGG

[alphawolf918]

Alright, thank you very much. I will look into that. For now I have it working, but trust me I will definitely take your advice on that. Just gonna be a bit before I re-upload it to Git. Thanks again.