Jump to content

Huh, that's weird. ItemStack oddity


Draco18s

Recommended Posts

So I was altering how one of my blocks creates items, changing it from dropping the ore to dropping the dust.  Previously everything worked fine, but in this change, the item stacks it would push into the world were somehow getting a stack size of 0 (no matter how many of them went into the world, the player would only pick up 1 and the ItemEntity itself would look like a larger stack for a short while before "collapsing" to be a stack of 1).

 

Here's the code

 

OreDataHooks.subOreData(worldObj, xCoord+bestj*24, yCoord, zCoord+bestk*24, b, 16);
System.out.println("Found " + b.getUnlocalizedName());
ItemStack is = new ItemStack(b.getItemDropped(0, this.rand, 0), 1, b.damageDropped(0)); //gets the ore chunk from my ore block
System.out.println(is + " " + is.getDisplayName() + ":" + is.stackSize);
if(is.getItem() != Items.redstone && is.getItemDamage() != 2) { //if its one of the ones that can be ground into dust
is = RecipeManager.getMillResult(is); //grind it (makes a stack of 2)
is.stackSize = 1; //make the stack size 1
System.out.println(is + " " + is.getItem() + ":" + is.stackSize);
}
mergeStacks(is);

 

Here's what the printlns print out:

 

1xitem.redstone@0 Redstone:1
1xitem.null@1 Raw Gold Ore:1
1xitem.null@1 com.draco18s.ores.item.ItemOreDustSmall@efad89:1

 

What caught my eye was "1xitem.null" part.  Huh?  They're all registered properly and list their sub items.

 

And why do the dusts end up as a (nearly) empty stack, but the ores don't?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

1) Your code does not match up with the output (there is no "Found: " text in the output)

2) The "item.null" happens if you don't set the unlocalized name.

 

1) Oh, sorry, I clipped that line.  I'd been meaning to only include the relavent bits when I did that copy/paste and forgot to remove the extra out line.  Here's a bunch:

Found tile.ore_gold
1xitem.null@1 Raw Gold Ore:1
1xitem.null@1 com.draco18s.ores.item.ItemOreDustSmall@efad89:1
Found tile.ore_redstone
1xitem.redstone@0 Redstone:1
Found tile.ore_gold
1xitem.null@1 Raw Gold Ore:1
1xitem.null@1 com.draco18s.ores.item.ItemOreDustSmall@efad89:1

2) Ah.  I override getUnlocalizedName, due to the subItems all needing different names.  That makes sense.

 

Any thoughts on why the item entities have an apparent size of 0?

Here's the mergeStack function, which is responsible:

private void mergeStacks(ItemStack stack) {
	if(worldObj.isRemote) return;

	float rx = 0.5F;
	float ry = rand.nextFloat() * 0.25F + 0.25F;
	float rz = 0.5F;

	EntityItem entityItem = new EntityItem(worldObj,xCoord + rx, yCoord + ry, zCoord + rz,stack);

	float factor = 0.05F;
	entityItem.motionX = 0;
	entityItem.motionY = 0;
	entityItem.motionZ = 0;
	entityItem.delayBeforeCanPickup = 10;
	worldObj.spawnEntityInWorld(entityItem);
}

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

D'oh.  That's exactly the problem.  (And neither should it!  I should be cloning the result here).

Ah, the limits of human RAM: we can only hold seven objects in memory at once.  I'd forgotten that I'd need to do that.

 

(I do love the implications of not cloning it though: the item exists in multiple places at the same time.  \o/ And physicists tell us that's not possible. :P)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Okay, so I actually downgraded the mod to 1.20.6 because I did not want to have to deal with vanilla datacomponents. I followed a youtube tutorial and now have a capability I made attach to my modded item. However I am now unsure how to actually retrieve and manipulate the capability of an itemstack. I saw a getCapability function in some tutorials but that seems to have been deprecated...
    • https://pastebin.com/MRaP223K
    • Hallo all! I'm working on a custom mod pack for a few friends an I. However, whenever I launch it, it crashes and returns this error code. It appears to be crashing while trying to render some sprites from different mods, but I can't find a way to fix this.      The game crashed whilst stitching Error:      net.minecraft.client.renderer.texture.StitcherException:      Unable to fit: minecolonies:entity/citizen/nether/noblemale3_b - size: 128x64 -      Maybe try a lower resolution resourcepack? Here's the pastebin of the crash report: https://pastebin.com/17hgAPFS
    • when i join it looks normal until i look a mob or i have some thing in my hand and my screen starts turning different colors when i look around. i can see my inventory and the menu but not mobs or blocks in my hand I've tried to turn off the anti virus  uninstall and reinstalling the best driver  going back from version 20 to 8 and putting a ton of ram into minecraft. if i could get any help. thank you
    • Hi fellow minecrafter,   We've got exciting news from the Pacific Laboratory for Artificial Intelligence (PLAI) at UBC! We're merging the worlds of Minecraft and AI research, and you're invited to join through our platform, plaicraft.ai, to aid our data collection process. It's not just playing games; it's contributing to cutting-edge AI research.   BetterStructures and more!!: We want to make the server as fun as possible for everyone so we recently added a bunch of structural plugins that adds over a hundred of new structures and sites for you to explore and challenge. We are also working on PVP, bedwars and skyblock content, which will make the server even more fun!   Here’s how you can get involved! -Register on plaicraft.ai with your email(you can fake one, as long as you can receive email from it it's fine). -Complete a consent form. -Play Minecraft and contribute to science! (all you need is a Chrome browser and a steady internet, you'll be playing on VM)   Why You Should Participate? -Support AI Research: Your gameplay directly contributes to important AI advancements.  -Free Minecraft Access: Enjoy the game without any cost. -We have shaders and a bunch of cool mods loaded on our instances  -Great Community: Our server currently has a fantastic community, with many awesome players you can meet.   Elephant in the room: Now I want to address some obvious concerns, I sure did a good job making us sound like a scam by the above content. I know that the "free Minecraft" thing has always been taboo in the Minecraft community. So how can I prove to you that this is not a scam? - The easiest way and most official way is that we are approved by the University of British Columbia ethics board, our BREB number is H23-02389. You can verify this case number yourself. - The harder way is that I'll explain the technical details of this project and why we choose to provide free Minecraft. So the goal of this project is very similar to the paper MineDojo or MineRL, we want to collect a multi-modal dataset that consists of video, audio, keyboard and mouse movement. Minecraft has been a very important simulation environment for the ML community and there are tons of papers related to it. Now we obviously don't have enough money like those big tech companies who can just pay people to play, so we have to turn to the Minecraft community. To record all the data mentioned, there needs to be a lot of setup and coding, and it's definitely impossible for us to ask people to run these recording programs on their personal computers. So we carefully configured the AWS EC2 instance to run Minecraft alongside the programs. And that's where and why we also provide you with free Minecraft licenses, of course, we are not giving the account to you, just allowing you to be able to play Minecraft on these instances. You might ask, "Why can't I log in with my account on the instances?", that's because first login with your personal Minecraft account is another privacy risk; second not all our target audiences have an account; and lastly we restricted a lot on what you can do on the instance, basically all you can do is play Minecraft and that's all the data we want, allowing you to log in will make things complicated to control.   For more information on the project and the team, visit Dr. Frank Wood’s website or follow @frankdonaldwood on Twitter. You can also learn more about PLAI lab research on our website (just search ubc plai). Join us in transforming your gaming experience into a meaningful contribution to AI research. Let’s push the boundaries of what gaming can achieve together! Happy plaiing!   Best,  The PLAI Team
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.