[1.7.10]NBT data reverts to 0 after right click

[blfngl]

So I've made a gun that used to store bullets as a local variable and am now switching it to be NBT stored, however the gun's "clip count" (how many bullets are loaded) keeps reverting to 0 before it ever fires a shot, even after being reloaded. Help?

 

ItemGun:

package blfngl.fallout.item.guns;

import java.util.List;

import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.EnumChatFormatting;
import net.minecraft.world.World;
import blfngl.fallout.Fallout;
import blfngl.fallout.entity.projectile.EntityBullet;
import blfngl.fallout.item.ItemFallout;
import blfngl.fallout.player.FalloutPlayer;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class ItemGun extends ItemFallout
{
Item ammoType;
String name;
double reloadTime;
double shotTime;
int clipSize;
float damage;
float baseDamage;
String fireSound;
String reloadSound;
int durability;

int currentShotTime = 0;
int currentReloadTime = 0;

/**
 * @param par1 ammo
 * @param par2 unlocalized name
 * @param par3 reload time
 * @param par4 shot time
 * @param par5 clip size
 * @param par6 damage
 * @param par7 fire sound
 * @param par8 reload sound
 * @param par9 durability
 */
public ItemGun(Item par1, String par2, double par3, double par4, int par5, float par6, String par7, String par8, int par9)
{
	maxStackSize = 1;
	setCreativeTab(Fallout.tabGuns);
	name = par2;
	setUnlocalizedName(name);
	ammoType = par1;
	reloadTime = par3;
	shotTime = par4;
	clipSize = par5;
	damage =  4 * par6;
	baseDamage = damage;
	fireSound = "fallout:" + par7;
	reloadSound = "fallout:" + par8;
	setMaxDamage(par9);
	durability = par9;
}

@Override
public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player)
{
	if (itemStack.stackTagCompound == null)
	{
		itemStack.stackTagCompound = new NBTTagCompound();
		System.out.println("created new tag");
		itemStack.stackTagCompound.setInteger("clip", 0);
	}

	FalloutPlayer props = FalloutPlayer.get(player);
	float actualDamage = damage * ((50 + (props.getSkillValue("guns") * .5F)) / 100);
	int clipCount = itemStack.stackTagCompound.getInteger("clip");

	if (player.capabilities.isCreativeMode && !world.isRemote)
	{
		if  (currentShotTime >= shotTime * 20.0)
		{
			world.spawnEntityInWorld(new EntityBullet(world, player, actualDamage));
			world.playSoundAtEntity(player, fireSound, 1.0F, 1);
			currentShotTime = 0;
		}
	}

	else if (clipCount > 0 && currentShotTime >= shotTime * 20.0 && !world.isRemote && currentReloadTime > (40 * reloadTime)) // && !Fallout.isReloading && extPlayer.getReloadingState() == 0)
	{
		if (!Fallout.isReloading)
		{
			world.spawnEntityInWorld(new EntityBullet(world, player, actualDamage));
			world.playSoundAtEntity(player, fireSound, 1.0F, 1);
			currentShotTime = 0;
			itemStack.stackTagCompound.setInteger("clip", clipCount - 1);
			System.out.println("fired");
			//itemStack.damageItem(1, player);
		}
	}

	System.out.println(clipCount);
	return itemStack;
}

@Override
public void onUpdate(ItemStack itemStack, World world, Entity entity, int p_77663_4_, boolean p_77663_5_)
{
	if (itemStack.stackTagCompound == null)
	{
		itemStack.stackTagCompound = new NBTTagCompound();
		System.out.println("created new tag");
		itemStack.stackTagCompound.setInteger("clip", 0);
	}

	currentShotTime++;
	currentReloadTime++;

	if (entity instanceof EntityPlayer)
	{
		int clipCount = itemStack.stackTagCompound.getInteger("clip");

		EntityPlayer player = (EntityPlayer) entity;
		FalloutPlayer extPlayer = FalloutPlayer.get(player);

		if (clipCount < clipSize && Fallout.isReloading && player.inventory.hasItem(ammoType)) //extPlayer.getReloadingState() == 1)
		{
			player.playSound(reloadSound, 1.0F, 1);

			for (int i = 0; i < clipSize; i++)
			{
				if (player.inventory.hasItem(ammoType) && clipCount < clipSize)
				{
					player.inventory.consumeInventoryItem(ammoType);
					clipCount++;
				}
			}

			itemStack.stackTagCompound.setInteger("clip", clipCount);
			currentReloadTime = 0;
			Fallout.isReloading = false;
			System.out.println("finishedReload" + clipCount);
		}
	}
}

@Override
@SideOnly(Side.CLIENT)
public void addInformation(ItemStack itemStack, EntityPlayer player, List list, boolean p_77624_4_)
{
	/**int clipCount;

	if (itemStack.stackTagCompound == null)
	{
		itemStack.stackTagCompound = new NBTTagCompound();
		itemStack.stackTagCompound.setInteger("clip", 0);
		clipCount = itemStack.stackTagCompound.getInteger("clip");
	}

	else
	{
		clipCount = itemStack.stackTagCompound.getInteger("clip");
	}

	FalloutPlayer props = FalloutPlayer.get(player);
	float displayDamage = damage * ((50 + (props.getSkillValue("guns") * .5F)) / 100);

	//list.add("");
	list.add("\u00A79Damage: " + displayDamage);
	list.add("\u00A79Ammo Loaded: " + clipCount + " / " + clipSize);
	list.add("");*/
	list.add(EnumChatFormatting.RED + "Base Stats:");
	list.add(EnumChatFormatting.RED + "Damage: " + baseDamage);
	list.add(EnumChatFormatting.RED + "Ammo Type: " + ammoType.getItemStackDisplayName(new ItemStack(ammoType)));
	list.add(EnumChatFormatting.RED + "Fire Rate: " + shotTime);
	list.add(EnumChatFormatting.RED + "Reload Rate: " + reloadTime);
	//list.add("Durability: " + (durability - getDamage(itemStack)) + " / " + durability);
}

@Override
public void registerIcons(IIconRegister iconRegister)
{
	itemIcon = iconRegister.registerIcon("fallout:" + getUnlocalizedName().substring(getUnlocalizedName().indexOf(".") + 1));
}

@Override
@SideOnly(Side.CLIENT)
public boolean isFull3D()
{
	return true;
}
}

 

[blfngl]

You cannot store any data that is unique per Item in the Item class (do not make fields for it). You must get that data from the ItemStack every time.

So I removed all of my

int clip = itemStack.stackTagCompound.getInteger("clip");

and replaced it with just the itemStack.stackTagCompound line, but I get the same result.

[Draco18s]

You cannot store any data that is unique per Item in the Item class (do not make fields for it). You must get that data from the ItemStack every time.

So I removed all of my

int clip = itemStack.stackTagCompound.getInteger("clip");

and replaced it with just the itemStack.stackTagCompound line, but I get the same result.

 

No, not that.  Those are local variables.  He means this chunk and anything that references these:

	Item ammoType;
String name;
double reloadTime;
double shotTime;
int clipSize;
float damage;
float baseDamage;
String fireSound;
String reloadSound;
int durability;

int currentShotTime = 0;
int currentReloadTime = 0;

[blfngl]

You cannot store any data that is unique per Item in the Item class (do not make fields for it). You must get that data from the ItemStack every time.

So I removed all of my

int clip = itemStack.stackTagCompound.getInteger("clip");

and replaced it with just the itemStack.stackTagCompound line, but I get the same result.

 

No, not that.  Those are local variables.  He means this chunk and anything that references these:

	Item ammoType;
String name;
double reloadTime;
double shotTime;
int clipSize;
float damage;
float baseDamage;
String fireSound;
String reloadSound;
int durability;

int currentShotTime = 0;
int currentReloadTime = 0;

All of the variables excpet for the two at the bottom are static for everyone and I was going to change the last two once I could figure this out. Does having them effect the NBT data anyways?