How can I make a timer for onItemRightClick? [Solved]

[FishSauce]

Works now, thanks everyone for the help

[knokko]

Override this method in Item to update your item every tick.

Now create a simple field and edit it every tick.

public void onUpdate(ItemStack item, World world, Entity entity, int a, boolean b)

[FishSauce]

Override this method in Item to update your item every tick.

Now create a simple field and edit it every tick.

public void onUpdate(ItemStack item, World world, Entity entity, int a, boolean b)

Sorry, but could you give an example of the code?

[coolAlias]

Don't make a field in your Item class - every single one of your weapons will then be on the same timer, so if I right-click, my friend's timer will start, too. This is because Items are each a static object, i.e. there is only ONE of each Item in the game.

 

Instead, you need to store the timer in the ItemStack's NBT compound. See the Forge Wiki article.

[FishSauce]

Don't make a field in your Item class - every single one of your weapons will then be on the same timer, so if I right-click, my friend's timer will start, too. This is because Items are each a static object, i.e. there is only ONE of each Item in the game.

 

Instead, you need to store the timer in the ItemStack's NBT compound. See the Forge Wiki article.

Some of that is outdated, and I am not sure what they have changed to. Like the hold.itemID

[Draco18s]

hold.getItem() ?

[FishSauce]

hold.getItem() ?

That removes the error for that bit, but still the line next to that wont work. It doesnt have getItem() or itemID

[coolAlias]

hold.getItem() ?

That removes the error for that bit, but still the line next to that wont work. It doesnt have getItem() or itemID

And we're supposed to magically know what the next line is?

 

As for the article being outdated, sure, slightly, but any required code changes would be readily apparent with just a bit of Java knowledge and poking around a little in vanilla code.

 

Anyway, show your code or we cannot help.

[FishSauce]

hold.getItem() ?

That removes the error for that bit, but still the line next to that wont work. It doesnt have getItem() or itemID

And we're supposed to magically know what the next line is?

 

As for the article being outdated, sure, slightly, but any required code changes would be readily apparent with just a bit of Java knowledge and poking around a little in vanilla code.

 

Anyway, show your code or we cannot help.

http://pastebin.com/2t0H4vw6

[coolAlias]

I don't see anywhere in there where you tried to implement what I suggested, storing the cooldown in the ItemStack's NBT tag. The way you have it now, every single player with your item is using the same cooldown field (which doesn't even cool down, since you didn't implement onUpdate).

 

Item#onCreated only gets called if the item is crafted, btw, so your NBT tag will not be initialized if you get one from the Creative tab, by command, as loot, or any other such means.

[FishSauce]

I don't see anywhere in there where you tried to implement what I suggested, storing the cooldown in the ItemStack's NBT tag. The way you have it now, every single player with your item is using the same cooldown field (which doesn't even cool down, since you didn't implement onUpdate).

 

Item#onCreated only gets called if the item is crafted, btw, so your NBT tag will not be initialized if you get one from the Creative tab, by command, as loot, or any other such means.

1. Im not sure how to store the cooldown in the Itemstack's NBT tag.

2. I didnt implement onUpdate because Im not sure what to do with it. That is why I am here

[Minothor]

The wiki provides an excellent primer tut on NBT here:

http://www.minecraftforge.net/wiki/Creating_NBT_for_items

 

The two methods that have been suggested to you so far both involve the onUpdate function (called every tick by the game)

Cool's has a variable stored per Itemstack that could be named "coolDownTicksToGo" which is the number of ticks left until the item can be reused. The update function just decreases the number if it's >=0.

Using the item sets the variable to the number of ticks needed to count down.

 

Sieben's provides a bit more accuracy since tick rate can be variable. He stores the date/time (a 'Long' type in Java) the item was last used in the Itemstack nbt tag and uses the update function to check if the time difference between that stored time and the current time is >= the cooldown period.

Using the item just sets have var to the current time.

[Minothor]

Ah, righto, I was assuming that it would feed back into either an animation or other visual cooldown indicator of some kind. Yeah, without that, it's less work for both the coder and the server!

[FishSauce]

I get that you guys aren't going to do my mod for me, but I need an example

[FishSauce]

What do you need an example of?

How to store things in NBT and like the whole Cooldown thing

[Draco18s]

nbt.setInteger("MyCooldown",400) ?

[FishSauce]

ItemStack#stackTagCompound

is the NBT data for an ItemStack, put anything you want into it.

For the cooldown use

World#getTotalWorldTime

it gives you the amount of ticks since the world was created. Using that you can then check how many ticks have passed since the last time the Item was used.

Yeah but how do I use those, I haven't messed with really anthing like these before

[Draco18s]

They're variables like any other variable.  Use them as variables that have values and do whatever you want to.

[FishSauce]

They're variables like any other variable.  Use them as variables that have values and do whatever you want to.

I realise that. But if its as easy as you guys are implying it then why can't anyone give me an example?

[Anon10W1z]

My two cents.

 

 

It's better to teach a man to fish than to give him fish.

[coolAlias]

Here's what you need to know:

 

1. NBT tags can be made to store pretty much anything - use your IDE to check out NBTTagCompound's class methods and you should get a pretty good idea.

2. To access an 'Item' NBT, you need an ItemStack, because ItemStacks are what actually store the individual 'Item' data (such as current item damage).

3. ItemStack has class methods that allow you to create, modify and access a class field which stores an NBTTagCompound

 

Thus, all you need to do is use your ItemStack instance (which is provided as a parameter in pretty much every single class method of Item), get the tag compound from it (or create one if it does not yet exist), then access and modify as needed whatever tags you have stored in there.

 

It's as simple as that. If you don't understand how to use class methods and fields, you should take some time to brush up on Java basics. If you don't understand what we mean by nbt tags, just look at vanilla code for a second.

 

 

[FishSauce]

My two cents.

 

 

It's better to teach a man to fish than to give him fish.

Except if I see the code I can learn it, I know you were using it as a metaphor but you cant learn how to fish by looking at a fish. Two completely different things.

[FishSauce]

Ok, I get the whole NBT thing now. Still the cooldown doesn't work.

[Draco18s]

I realise that. But if its as easy as you guys are implying it then why can't anyone give me an example?

 

Because that would require that I instruct you on the basics of Java.

At which point I point you at my signature.

[Player131]

Ok, I already done that, it's seriously the most simple in my drone launcher weapon. Take example on the code, here is my github link https://github.com/Yuri6037/AncientAddinMod/blob/master/src/main/java/net/yuri6037/AncientAddinMod/items/ItemHandDroneLauncher.java

 

Just watch on my onUpdate and onItemRightClick, it's not as much complicated, just use the Minecraft damage system to make the timer, and use some nbt booleans.