Jump to content

[1.7.10] Getting the itemstack while in a GUI


Thornack

Recommended Posts

I have a gui and I wish to get the current itemstack that the player is holding so that I may conditionally apply damage to it depending on what happens in the GUI whenever a certain key is released. I have the key release code working but havent been able to get the itemstack. Is there a simple solution. I tried the following and the key release code works. Now all I need is to get the itemstack that the player is currently holding.

 

private void keyReleased(int key, int event){
	if(key==Keyboard.KEY_W){
		this.random = 0;
		this.numberOfGuesses ++;
		if(mc.thePlayer.getHeldItem() != null && (mc.thePlayer.getHeldItem().getItem()==CommonProxy.Customitem)){
			int damage = 0;
			 // here is where I need to get the itemstack but I am unsure how to do it

		}
	}
}

 

Link to comment
Share on other sites

It will never work. KeyBindings are client side. You will need to send packet to server if you want to apply any kind of changes.

How To: On KeyBinding send packet, get sender from context, get his inventory, get itemstack, check nulls, get item, update item.

 

Good tutorial on packets:

http://www.minecraftforum.net/forums/mapping-and-modding/mapping-and-modding-tutorials/2137055-1-7-x-1-8-customizing-packet-handling-with

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Ok so I wrote this class but I am not sure what to do in the last method

public class MessageUpdateCustomItem extends MyCustomAbstractMessage<MessageUpdateCustomItem>{


private int itemDamage;

public MessageUpdateCustomItem(){}

public MessageUpdateLCustomItem(CustomItem theCustomItem, int damage){

	this.itemDamage = damage;
}

@Override
public void fromBytes(ByteBuf buf) {

	this.itemDamage = buf.readInt();
}

@Override
public void toBytes(ByteBuf buf) {

	buf.writeInt(this.itemDamage);
}

@Override
public IMessage handleClientMessage(EntityPlayer player, MessageUpdateCustomItem message, MessageContext ctx) {
	//handle(player, message, ctx);
	return null;
}

@Override
public IMessage handleServerMessage(EntityPlayer player, MessageUpdateCustomItem message, MessageContext ctx) {
	handle(player, message, ctx);
	return message;
}

private void handle(EntityPlayer player, MessageUpdateCustomItem message, MessageContext ctx){	
				//I am not sure what to do here
	}
}

Link to comment
Share on other sites

General note: You SHOULDN'T allow client to edit server values, that is very unsafe if you ask me.

 

CustomItem theCustomItem - you don't need to send it.

 

Basically (following my previous post) you wan't to send new damageValue, then in handler you will need to:

ctx.getServerHandler().playerEntity.inventory //ctx is MsgContext

 

Then get your item and edit it on server side. After editing, given ItemStack will auto-update to all since ItemStacks are auto updated. Note that you can only edit meta and NBT (you probably know that).

 

Remember to properly register packet (Side.SERVER) - everything is included in tut i linked :)

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Good Point regarding the hacking bit, would this work since Gui is on client side. Player presses a keyboard key then inside the

@Override public void handleKeyboardInput() 

method i check if the key was released and if the key was released then I add 1 to an itemdamage variable and send a request to server (maybe my own packet or the same way as item enchant is done). That request contains the name of requested item that I want to damage. Then somehow get the Server to get this request and make the server get player from server side container (EntityPlayerMP#opencontainer) and then get the itemstack that i want and update the itemstacks damage. Im not 100% sure on how to implement this but logically i think this would work wouldnt it and would get around the hacking issue you mentioned i think?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.