Search the Forums BEFORE making a new post.

Trouble with for loops for a simple multiblock

Posted January 8, 201510 yr

Hey there,

I'm not too experienced with modding, but have been making a mod for the past month or so, and have certainly improved. However, I'm attempting to make my currently extremely crude code more compact and simplified by using for loops to detect whether all of the blocks needed for the multiblock structure are there.

However, I am clearly doing something wrong: the block is only caring about 6 of the blocks out of the 150 of the structure, and only searches in those places - here is the block class, where everything important is, and the multiblock detection method is at the bottom, with the commented out section at the beginning of the method being the old system.

package com.nr.mod.blocks.tileentities;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.command.ICommandSender;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.IChatComponent;
import net.minecraft.util.IIcon;
import net.minecraft.util.MathHelper;
import net.minecraft.world.World;

import com.nr.mod.NuclearRelativistics;
import com.nr.mod.blocks.NRBlocks;

import cpw.mods.fml.common.network.internal.FMLNetworkHandler;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class BlockFissionReactorGraphite extends BlockContainer
{
private Random rand = new Random();

private final boolean isActive;
public static int MBNumber;

@SideOnly(Side.CLIENT)
private IIcon iconFront;

private static boolean keepInventory;

public BlockFissionReactorGraphite(boolean isActive)
{
super(Material.iron);

this.isActive = isActive;
}

@SideOnly(Side.CLIENT)
@Override
public void registerBlockIcons(IIconRegister iconRegister)
{
this.blockIcon = iconRegister.registerIcon("nr:" + "reactorBlock");
this.iconFront = iconRegister.registerIcon("nr:" + "fissionReactorGraphite" + "Front" + (this.isActive ? "Active" : "Idle"));
}

public Item getItemDropped(int par1, Random random, int par3)
{
	return Item.getItemFromBlock(NRBlocks.fissionReactorGraphiteIdle);
}

public void onBlockAdded(World world, int x, int y, int z)
{
	super.onBlockAdded(world, x, y, z);
	this.setDefaultDirection(world, x, y, z);
}

private void setDefaultDirection(World world, int x, int y, int z)
 {
        if (!world.isRemote)
        {
            Block block = world.getBlock(x, y, z - 1);
            Block block1 = world.getBlock(x, y, z + 1);
            Block block2 = world.getBlock(x - 1, y, z);
            Block block3 = world.getBlock(x + 1, y, z);
            byte b0 = 3;

            if (block.func_149730_j() && !block1.func_149730_j())
            {
                b0 = 3;
            }

            if (block1.func_149730_j() && !block.func_149730_j())
            {
                b0 = 2;
            }

            if (block2.func_149730_j() && !block3.func_149730_j())
            {
                b0 = 5;
            }

            if (block3.func_149730_j() && !block2.func_149730_j())
            {
                b0 = 4;
            }

            world.setBlockMetadataWithNotify(x, y, z, b0, 2);
        }
    }

@SideOnly(Side.CLIENT)
 public IIcon getIcon(int side, int metadata) {
	return metadata == 0 && side == 3 ? this.iconFront : (side == metadata ? this.iconFront : this.blockIcon);
    }

public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int side, float hitX, float hitY, float hitZ)
{
	 if(world.isRemote)
	 {
		 return true; 
	 }
	 else
	 {
		 FMLNetworkHandler.openGui(player, NuclearRelativistics.instance, NuclearRelativistics.guiIdFissionReactorGraphite, world, x, y, z);
	 }
	 return true;
 }

public TileEntity createNewTileEntity(World world, int par1)
{
	return new TileEntityFissionReactorGraphite();
}

public void onBlockPlacedBy(World world, int x, int y, int z, EntityLivingBase entityLivingBase, ItemStack itemstack)
{
	 int l = MathHelper.floor_double((double)(entityLivingBase.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

        if (l == 0)
        {
            world.setBlockMetadataWithNotify(x, y, z, 2, 2);
        }

        if (l == 1)
        {
        	world.setBlockMetadataWithNotify(x, y, z, 5, 2);
        }

        if (l == 2)
        {
        	world.setBlockMetadataWithNotify(x, y, z, 3, 2);
        }

        if (l == 3)
        {
        	world.setBlockMetadataWithNotify(x, y, z, 4, 2);
        }

        if (itemstack.hasDisplayName())
        {
            ((TileEntityFissionReactorGraphite)world.getTileEntity(x, y, z)).setGuiDisplayName(itemstack.getDisplayName());
        }
        
        //itemstack = new ItemStack(NRItems.book, 1);
    	//player.inventory.addItemStackToInventory(itemstack);
    	
    	IChatComponent localIChatComponent;
    	localIChatComponent = IChatComponent.Serializer.func_150699_a("[{text:\"Click here to see how to build the multiblock reactor\",color:aqua,italic:false,clickEvent:{action:open_url,value:\"https://www.dropbox.com/s/vy7ld0dgd71utxu/fission%20reactor%20setup.bmp?dl=0\"}}]");

    	((ICommandSender) entityLivingBase).addChatMessage(localIChatComponent);
    }

public static void updateFissionReactorGraphiteBlockState(boolean active, World worldObj, int xCoord, int yCoord, int zCoord)
{
	int i = worldObj.getBlockMetadata(xCoord, yCoord, zCoord);

	TileEntity tileentity = worldObj.getTileEntity(xCoord, yCoord, zCoord);
	keepInventory = true;

	if(active)
	{
		worldObj.setBlock(xCoord, yCoord, zCoord, NRBlocks.fissionReactorGraphiteActive);
	}
	else
	{
		worldObj.setBlock(xCoord, yCoord, zCoord, NRBlocks.fissionReactorGraphiteIdle);
	}

	keepInventory = false;

	worldObj.setBlockMetadataWithNotify(xCoord, yCoord, zCoord, i, 2);

	if(tileentity != null)
	{
		tileentity.validate();
		worldObj.setTileEntity(xCoord, yCoord, zCoord, tileentity);
	}
}

public void breakBlock(World world, int x, int y, int z, Block oldBlockID, int oldMetadata)
{
	if(!keepInventory)
	{
		TileEntityFissionReactorGraphite tileentity = (TileEntityFissionReactorGraphite) world.getTileEntity(x, y, z);

		if(tileentity != null)
		{
			for(int i = 0; i < tileentity.getSizeInventory(); i++)
			{
				ItemStack itemstack = tileentity.getStackInSlot(i);

				if(itemstack != null)
				{
					float f = this.rand.nextFloat() * 0.8F + 0.1F;
					float f1 = this.rand.nextFloat() * 0.8F + 0.1F;
					float f2 = this.rand.nextFloat() * 0.8F + 0.1F;

					while(itemstack.stackSize > 0)
					{
						int j = this.rand.nextInt(21) + 10;

						if(j > itemstack.stackSize)
						{
							j = itemstack.stackSize;
						}

						itemstack.stackSize -= 	j;
						EntityItem item = new EntityItem(world, (double) ((float) x + f), ((float) y + f1), ((float) z + f2),
						new ItemStack (itemstack.getItem(), j, itemstack.getItemDamage()));

						if(itemstack.hasTagCompound())
						{
							item.getEntityItem().setTagCompound((NBTTagCompound) itemstack.getTagCompound().copy());
						}

						float f3 = 0.05F;
						item.motionX = (double)((float) this.rand.nextGaussian() * f3);
						item.motionY = (double)((float) this.rand.nextGaussian() * f3 + 0.2F);
						item.motionZ = (double)((float) this.rand.nextGaussian() * f3);

						world.spawnEntityInWorld(item);

					}
				}
			}

			world.func_147453_f(x, y, z, oldBlockID);
		}
	}

	super.breakBlock(world, x, y, z, oldBlockID, oldMetadata);
}

public boolean hasComparatorInputOverride()
{
	return true;
}

public int getComparatorInputOverride(World world, int x, int y, int z, int i)
{
	return Container.calcRedstoneFromInventory((IInventory)world.getTileEntity(x, y, z));
}

public Block idPicked(World world, int x, int y, int z)
{
	return NRBlocks.fissionReactorGraphiteIdle;
}

    public static boolean isMultiBlock(World world, int x, int y, int z)
    {
    	/*if (world.getBlock(x-2, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-2, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-3, y+1, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x+3, y+1, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-2, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+5, z) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-2, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+5, z-6) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-3, y, z-1) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-2) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-3) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-4) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-5) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-1) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-2) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-3) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-4) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-5) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-2, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-1, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+1, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+2, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-2, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-1, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+1, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			
    			&& world.getBlock(x-3, y, z-1) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-2) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-3) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-4) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-5) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-1) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-2) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-3) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-4) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-5) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-2, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-1, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+1, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+2, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-2, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-1, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+1, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			
        		)*/
    	for (int i1 = 0; i1 < 5; i1++) {
    		for (int i2 = 0; i2 < 5; i2++) {
    			if (world.getBlock(x-2+i1, y, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x-2+i1, y+6, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x-3, y+1+i1, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x+3, y+1+i1, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x-2+i1, y+1+i2, z) == NRBlocks.reactorBlock
    				&& world.getBlock(x-2+i1, y+1+i2, z-6) == NRBlocks.reactorBlock) {
    				MBNumber = 1;
    				return true;
    			}
    	
    						/*else if (world.getBlock(x-1, y, z-1) == NRBlocks.reactorBlock
    								&& world.getBlock(x-1, y, z-1) == NRBlocks.reactorBlock) {
    							MBNumber = 2;
    							return true;
    						}
    						else if (world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteActive) {
    							MBNumber = 3;
    							return true;
    						}
    						else if (world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteActive) {
    							MBNumber = 4;
    							return true;
    						}*/

    		}
    	} MBNumber = 0; return false;
    }
}

Thanks in advance for anyone better at this than me for noticing why this won't work

Quote

January 8, 201510 yr

Because you return true if the first time the loop runs it finds the blocks. You didn't let the loop finish.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

January 8, 201510 yr

Author

Ah yes - true, thank you I understand why that doesn't work now, but I am still a little confused about where to put the for loops How would I allow the method to run through all the blocks before making a decision?

Quote

January 8, 201510 yr

Author

Does anyone know how to make this work?

Quote

January 9, 201510 yr

loop {
    if(condition == true) {
        //your current return true, commented out
    }
    else {
        return false; //new
    }
    return true; //new
}

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

January 10, 201510 yr

Author

You're a great guy Thanks a bunch for the help.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/26464-trouble-with-for-loops-for-a-simple-multiblock/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

My Minecraft crashes after I try to load into a world.

No - position and inventory are lost - so you may have to search for your buildings

By TileEntity · 11 hours ago11 hr
My Minecraft crashes after I try to load into a world.

but the broken world is a brand new world @TileEntity

By FoxyWoxy · 14 hours ago14 hr
Mod for world Templates

WorldTools (Constructor) Allows you to capture and save detailed snapshots of server worlds (terrain, entities, metadata, etc.).

By moyiv · 22 hours ago22 hr
jarJar not working

Try replacing implementation with minecraftLibrary. Dependencies in the minecraftLibrary configuration are added to your compile and runtime classpaths in ForgeGradle 6.

By Jonathing · Yesterday at 11:32 AM1 day
Failed loading villager cartographer registered at cartographer - frozen tick

Allocated 10 Gb of ram. Could try again with more but I read using too much can slow things down as well. Going to try another big modpack and see if i can replicate the problem. It seems like this cartographer problem is kind of popular and doesn't have a solid solution yet, but i suspect its some generation mod since it's a crash that happens when specific chunks are being loaded. so i'll still try to lookout for what mod it could be as i add. i'll report back after testing as you suggested for a bit

By chemba21 · Yesterday at 06:56 AM1 day

Sign In

Trouble with for loops for a simple multiblock

Featured Replies

Join the conversation

Posts

My Minecraft crashes after I try to load into a world.

My Minecraft crashes after I try to load into a world.

Mod for world Templates

jarJar not working

Failed loading villager cartographer registered at cartographer - frozen tick

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)