[1.7.10] Item NBT Not Working

[FlashBash21]

PLEASE NOT THAT I'M NEW TO NBT'S AND AM STILL LEARNING IT!

 

Hello! I'm currently attempting to use an NBT to store information in an item I'm using. I want to the item to store a charge in it every time you hit a mob, so for that I'm gonna use an NBT. I want the the charge of the item to be displayed in the lore of the item but it doesn't show up(note that It doesn't store charges when you hit mobs yet I'm adding that later). I don't know much about NBT's so I've found some tutorials but they aren't too great or don't explain NBT's for items. Any help or advice at all would be well appreciated, Thanks!

 

Here is my class:

 

package com.LegendsAndArtifacts.items;



import java.util.List;

import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemSword;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.ChatComponentText;
import net.minecraft.world.World;

public class AxeInfernal extends ItemSword{

boolean isCharged = false;
int itemCharge = 0;

public AxeInfernal(ToolMaterial p_i45356_1_) {
	super(p_i45356_1_);

}

    @Override
    public void onCreated(ItemStack stack, World world, EntityPlayer player) {
    	 stack.stackTagCompound = new NBTTagCompound();
    	 stack.stackTagCompound.setInteger("currentCharge", itemCharge);
    }

    public void addInformation(ItemStack stack, EntityPlayer player, List list, boolean par4) {
    	 if (stack.stackTagCompound != null) {
             int charge = stack.stackTagCompound.getInteger("currentCharge");
             list.add("Current Charge: " + charge);
     }
    }
}

[Ernio]

First of all - you can'r use global fields in Item class. There is only one instance of item.

 

Note: onCreated is only called when you craft item with workbench. (You are probably pulling it from Creative Tab, thats why it doesn't have NBT)

Everytime you try to do anything with NBT you should access that data directly (inside method, with local fields).

 

That's pretty much all about NBT.

[FlashBash21]

First of all - you can'r use global fields in Item class. There is only one instance of item.

 

Note: onCreated is only called when you craft item with workbench. (You are probably pulling it from Creative Tab, thats why it doesn't have NBT)

Everytime you try to do anything with NBT you should access that data directly (inside method, with local fields).

 

That's pretty much all about NBT.

Ok so I got the charge to show up so thanks! But how do I update the NBT(I'm testing it with the onItemRightClick method)? I'm guessing I should use the onUpdate method or is there something to do that for me? And if I use onUpdate what do I put in it? here is my class :

 

package com.LegendsAndArtifacts.items;



import java.util.List;

import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemSword;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.ChatComponentText;
import net.minecraft.world.World;

public class AxeInfernal extends ItemSword{

private boolean isCharged = false;
private int itemCharge = 0;

public AxeInfernal(ToolMaterial p_i45356_1_) {
	super(p_i45356_1_);

}

    @Override
    public void onCreated(ItemStack stack, World world, EntityPlayer player) {
    	 stack.stackTagCompound = new NBTTagCompound();
    	 stack.stackTagCompound.setInteger("currentCharge", itemCharge);
    }

    public void addInformation(ItemStack stack, EntityPlayer player, List list, boolean par4) {
    	 if (stack.stackTagCompound != null) {
             int charge = stack.stackTagCompound.getInteger("currentCharge");
             list.add("Current Charge: " + charge);
     }
    }
    
    public void onUpdate(ItemStack stack, World world, Entity entity, int par4, boolean par5) {
    	
    	//?
    }
    public ItemStack onItemRightClick(ItemStack stack, World world, EntityPlayer player){
    	itemCharge++;
    	return stack;
    }
}

 

I think that using itemCharge++ is probably the wrong way to increment it but I'm not sure what the right way is. Again thanks for any help that you might give!

[shadowfacts]

Not sure about this but theoretically you could use GameRegistry.registerCustomItemStack(String name, ItemStack itemstack) with an ItemStack that already has the default NBT data on it.

[TheGreyGhost]

Hi

 

Here's an example of how an item might use and update NBT.

 

The item is a "gem" that stores your current [x,y,z] location when you shift-click.

 

When you 'use' it, it retrieves those coordinates and teleports there.

 

There should be enough there for you to figure out how to store and retrieve your integer (eg nbtTagCompound.setInteger())

 

MyItem::

  // called when the player starts holding right click;
  // --> if the gem is unbound, store the current location
  //  if the gem is bound, start the charge up sequence
  @Override
  public ItemStack onItemRightClick(ItemStack itemStackIn, World worldIn, EntityPlayer playerIn) {
    NBTTagCompound nbtTagCompound = itemStackIn.getTagCompound();

    if (playerIn.isSneaking()) { // shift pressed; save (or overwrite) current location
      if (nbtTagCompound == null) {
        nbtTagCompound = new NBTTagCompound();
        itemStackIn.setTagCompound(nbtTagCompound);
      }
      nbtTagCompound.setBoolean("Bound", true);
      nbtTagCompound.setDouble("X", (int) playerIn.posX);
      nbtTagCompound.setDouble("Y", (int)playerIn.posY);
      nbtTagCompound.setDouble("Z", (int)playerIn.posZ);
    } else { // attempting to use gem teleport
      boolean bound = false;
      if (nbtTagCompound != null && nbtTagCompound.hasKey("Bound")  ) {
        bound = nbtTagCompound.getBoolean("Bound");
      }
      if (bound) {
        playerIn.setItemInUse(itemStackIn, this.getMaxItemUseDuration(itemStackIn)); // start the charge up sequence
      } else {
        if (worldIn.isRemote) {  // only on the client side, else you will get two messages..
          playerIn.addChatComponentMessage(new ChatComponentText("Gem doesn't have a stored location! Shift right click to store your current location"));
        }
      }
    }
    return itemStackIn;
  }

  // called when the player has held down the right click for the full charge-up duration
  // in this case - destroy the item
  @Override
  public ItemStack onItemUseFinish(ItemStack stack, World worldIn, EntityPlayer playerIn)
  {
    NBTTagCompound nbtTagCompound = stack.getTagCompound();
    if (nbtTagCompound == null || !nbtTagCompound.hasKey("Bound") || nbtTagCompound.getBoolean("Bound") != true ) {
      return stack;
    }

    // teleport
    if (!worldIn.isRemote) { // server side only - will automatically update to client
      double x = nbtTagCompound.getDouble("X");  // returns a default if not present
      double y = nbtTagCompound.getDouble("Y");
      double z = nbtTagCompound.getDouble("Z");
      if (playerIn instanceof EntityPlayerMP) { // should be an EntityPlayerMP check first just to be sure to avoid crash
        EntityPlayerMP entityPlayerMP = (EntityPlayerMP) playerIn;

        entityPlayerMP.playerNetServerHandler.setPlayerLocation(x, y, z, entityPlayerMP.rotationYaw, entityPlayerMP.rotationPitch);
        worldIn.playSoundEffect(x, y, z, "mob.endermen.portal", 1.0F, 1.0F);
      }
    }
    return null;
//    for items with multiple count, decrease stack size and return the itemstack, eg
//    stack.stackSize--;
//    return stack;
  }

  // adds 'tooltip' text
  @SideOnly(Side.CLIENT)
  @SuppressWarnings("unchecked")
  @Override
  public void addInformation(ItemStack stack, EntityPlayer playerIn, List tooltip, boolean advanced) {
    NBTTagCompound nbtTagCompound = stack.getTagCompound();
    if (nbtTagCompound != null && nbtTagCompound.hasKey("Bound") && nbtTagCompound.getBoolean("Bound") == true ) {
      tooltip.add("Stored destination=");
      tooltip.add("X: " + nbtTagCompound.getInteger("X"));
      tooltip.add("Y: " + nbtTagCompound.getInteger("Y"));
      tooltip.add("Z: " + nbtTagCompound.getInteger("Z"));
    }
    else
    {
      tooltip.add("Hold down shift and then right click to store your current location");
    }
  }
}

 

-TGG