Jump to content

Recommended Posts

Posted

I have a block, that have TileEntity. When I "re-log" to the world, all my Blocks-with-tileEntity are rotated to 0(South)

Can you help me with fixing it?

Sorry, if you find mistaches in my posts.

I am not EN.

And when I post anything on Modder support, it means, I can't help myself and I need your help. And when you decide to delete my topic, just PM me with the reason, please.

Posted

Likely you need these two functions:

 

	@Override
    public void readFromNBT(NBTTagCompound tc) {
        super.readFromNBT(tc);
        //load your variables
    }

    @Override
    public void writeToNBT(NBTTagCompound tc) {
        super.writeToNBT(tc);
        //save your variables
    }

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Oh, sorry.

I forgot to place my code inside of my post.

 

Here is it:

 

 

package com.ec.tileentity;

import java.util.Random;

import com.ec.blocks.MyBlocks;
import com.ec.lib.MainLib;

import net.minecraft.block.Block;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;

public class TileEntityExcavator extends TileEntity{

public int direction = 0;
public boolean active = false;

@Override
public void writeToNBT(NBTTagCompound tag)
{
	super.writeToNBT(tag);
	tag.setInteger("direction", direction);
	tag.setBoolean("active", active);
}

@Override
public void readFromNBT(NBTTagCompound tag)
{
	super.readFromNBT(tag);
	this.direction = tag.getInteger("direction");
	this.active = tag.getBoolean("active");
}

@Override
public void updateEntity()
{
	int[] BTD = new int[3];

	switch(this.direction)
	{
	case 0:
		//South
		BTD[0] = xCoord;
		BTD[1] = yCoord;
		BTD[2] = zCoord + 1;
		break;
	case 1:
		//West
		BTD[0] = xCoord - 1;
		BTD[1] = yCoord;
		BTD[2] = zCoord;
		break;
	case 2:
		//North
		BTD[0] = xCoord;
		BTD[1] = yCoord;
		BTD[2] = zCoord - 1;
		break;
	case 3:
		//East
		BTD[0] = xCoord + 1;
		BTD[1] = yCoord;
		BTD[2] = zCoord;
		break;
	}



	if(!worldObj.isRemote)
	{
		float[] floatLocation = MainLib.centerBlock(xCoord, yCoord, zCoord);
		double x = (double) floatLocation[0];
		double y = (double) floatLocation[1] + 1;
		double z = (double) floatLocation[2];

		Block destroyedBlock = worldObj.getBlock(BTD[0], BTD[1], BTD[2]);

		if(worldObj.getBlockPowerInput(xCoord, yCoord, zCoord) > 0)
		{
			if(destroyedBlock != Blocks.air)
			{
				worldObj.setBlockToAir(BTD[0], BTD[1], BTD[2]);
				worldObj.spawnEntityInWorld(new EntityItem(worldObj, x, y + 1, z, new ItemStack(Item.getItemFromBlock(destroyedBlock))));
			}
		}
	}
}
}

 

 

 

And, how can I notify this block of neighbour change (Make this block update or update its texture)?

Sorry, if you find mistaches in my posts.

I am not EN.

And when I post anything on Modder support, it means, I can't help myself and I need your help. And when you decide to delete my topic, just PM me with the reason, please.

Posted

Oh, sorry.

I forgot to place my code inside of my post.

 

Here is it:

 

 

package com.ec.tileentity;

import java.util.Random;

import com.ec.blocks.MyBlocks;
import com.ec.lib.MainLib;

import net.minecraft.block.Block;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.world.World;

public class TileEntityExcavator extends TileEntity{

public int direction = 0;
public boolean active = false;

@Override
public void writeToNBT(NBTTagCompound tag)
{
	super.writeToNBT(tag);
	tag.setInteger("direction", direction);
	tag.setBoolean("active", active);
}

@Override
public void readFromNBT(NBTTagCompound tag)
{
	super.readFromNBT(tag);
	this.direction = tag.getInteger("direction");
	this.active = tag.getBoolean("active");
}

@Override
public void updateEntity()
{
	int[] BTD = new int[3];

	switch(this.direction)
	{
	case 0:
		//South
		BTD[0] = xCoord;
		BTD[1] = yCoord;
		BTD[2] = zCoord + 1;
		break;
	case 1:
		//West
		BTD[0] = xCoord - 1;
		BTD[1] = yCoord;
		BTD[2] = zCoord;
		break;
	case 2:
		//North
		BTD[0] = xCoord;
		BTD[1] = yCoord;
		BTD[2] = zCoord - 1;
		break;
	case 3:
		//East
		BTD[0] = xCoord + 1;
		BTD[1] = yCoord;
		BTD[2] = zCoord;
		break;
	}



	if(!worldObj.isRemote)
	{
		float[] floatLocation = MainLib.centerBlock(xCoord, yCoord, zCoord);
		double x = (double) floatLocation[0];
		double y = (double) floatLocation[1] + 1;
		double z = (double) floatLocation[2];

		Block destroyedBlock = worldObj.getBlock(BTD[0], BTD[1], BTD[2]);

		if(worldObj.getBlockPowerInput(xCoord, yCoord, zCoord) > 0)
		{
			if(destroyedBlock != Blocks.air)
			{
				worldObj.setBlockToAir(BTD[0], BTD[1], BTD[2]);
				worldObj.spawnEntityInWorld(new EntityItem(worldObj, x, y + 1, z, new ItemStack(Item.getItemFromBlock(destroyedBlock))));
			}
		}
	}
}
}

 

 

 

And, how can I notify this block of neighbour change (Make this block update or update its texture)?

 

You need these two functions in your class:

public Packet getDescriptionPacket() {

NBTTagCompound tag = new NBTTagCompound();
writeToNBT(tag);
return new S35PacketUpdateTileEntity(this.xCoord, this.yCoord, this.zCoord, 1, tag);

}

public void onDataPacket(NetworkManager net, S35PacketUpdateTileEntity packet) {

readFromNBT(packet.func_148857_g());

}

 

This will send data updates to the client when the chunk with the TE is loaded. It will work on singleplayer and multiplayer.

Romejanic

 

Creator of Witch Hats, Explosive Chickens and Battlefield!

Posted

I explain, why I think they are not saved. But I am not sure, because of this:

1. I place one block (from my mod:excavator) and when I placed it, it created tileentity and writes to it a INT direction. Then, is writed in code: every tick check if is powered by redstone. If true, set BOOLEAN active to true. This boolean is used only for texture. This block will check every tick, if behind it is any block, if true, then drops it on this(machine) block.

2. I leave(exit from) the world and again join (play) the world.

3. I looked at the blocks. All are rotated to the default direction-South(0).

When I place a block next to it's back texture side, and power it with redstone, nothing happens, but when I place a block at side, where back texture side was rototated before, it destroy the block and drop it.

And about the block update.

I made this block react to redstone-when I turn the power ON, the block must change it's texture. But nothing happens while I place or destroy block next to it. I wanted when is redstone on, update or notify block.

 

Sorry, if you find any mistakes, I am writing from mobile now and the keyboard is too small.

Sorry, if you find mistaches in my posts.

I am not EN.

And when I post anything on Modder support, it means, I can't help myself and I need your help. And when you decide to delete my topic, just PM me with the reason, please.

Posted

But, to what class? To my TileEntity class or my block's class?

Sorry, if you find mistaches in my posts.

I am not EN.

And when I post anything on Modder support, it means, I can't help myself and I need your help. And when you decide to delete my topic, just PM me with the reason, please.

Posted

OK, it worked. :D

And...

Can you explainme, what does this packet? Or how this packet work? It worked, but I don't understand it.

Sorry, if you find mistaches in my posts.

I am not EN.

And when I post anything on Modder support, it means, I can't help myself and I need your help. And when you decide to delete my topic, just PM me with the reason, please.

Posted

On the server side, the

getDescriptionPacket

method is called, and that method returns a

S35PacketUpdateTileEntity

containing and

NBTTagCompound

containing the data you have written to it. Then it sends the packet to the client side and it calls the

onDataPacket

with the packet returned from the

getDescriptionPacket

, in which you read all the data from the

NBTTagCompound

in the packet.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

Well, I understood. :D

Sorry, I am going off topic...

Do you know about good tutorial for leanring TileEntities, that implement IInventory?

I never made them, but I want to learn how-to them.

Sorry, if you find mistaches in my posts.

I am not EN.

And when I post anything on Modder support, it means, I can't help myself and I need your help. And when you decide to delete my topic, just PM me with the reason, please.

Posted

But this tutorial you recommend for me is outdated.

Sorry, if you find mistaches in my posts.

I am not EN.

And when I post anything on Modder support, it means, I can't help myself and I need your help. And when you decide to delete my topic, just PM me with the reason, please.

Posted

1.7? Should be pretty similar. Just follow the tutorial and should an error turn up compare your code with the furnace code.

Thats how I created some of my first Machines.

Here could be your advertisement!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.